Fix CEL to actually block deprecated resource create

Author: carlydf

api/v1alpha1/deprecated_temporalconnection_types.go

@@ -51,7 +51,7 @@ type TemporalConnectionStatus struct {
 //+kubebuilder:resource:shortName=tconn
 //+kubebuilder:printcolumn:name="Host",type="string",JSONPath=".spec.hostPort",description="Temporal server endpoint"
 //+kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Age"
-// +kubebuilder:validation:XValidation:rule="oldSelf != null",message="TemporalConnection is deprecated and cannot be created. Use Connection instead."
+// +kubebuilder:validation:XValidation:rule="oldSelf.hasValue()",message="TemporalConnection is deprecated and cannot be created. Use Connection instead.",optionalOldSelf=true
 // +kubebuilder:deprecatedversion:warning="TemporalConnection is deprecated. Use Connection instead."
 
 // TemporalConnection is the Schema for the temporalconnections API

api/v1alpha1/deprecated_temporalworkerdeployment_types.go

@@ -158,7 +158,7 @@ type TemporalWorkerDeploymentStatus struct {
 //+kubebuilder:printcolumn:name="Ramp %",type="number",JSONPath=".status.targetVersion.rampPercentage",description="Ramp percentage"
 //+kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Age"
 // +kubebuilder:validation:XValidation:rule="size(self.metadata.name) <= 63",message="name cannot be more than 63 characters"
-// +kubebuilder:validation:XValidation:rule="oldSelf != null",message="TemporalWorkerDeployment is deprecated and cannot be created. Use WorkerDeployment instead."
+// +kubebuilder:validation:XValidation:rule="oldSelf.hasValue()",message="TemporalWorkerDeployment is deprecated and cannot be created. Use WorkerDeployment instead.",optionalOldSelf=true
 // +kubebuilder:deprecatedversion:warning="TemporalWorkerDeployment is deprecated. Use WorkerDeployment instead."
 
 // TemporalWorkerDeployment is the Schema for the temporalworkerdeployments API

helm/temporal-worker-controller-crds/templates/temporal.io_temporalconnections.yaml

@@ -115,7 +115,8 @@ spec:
         x-kubernetes-validations:
         - message: TemporalConnection is deprecated and cannot be created. Use Connection
             instead.
-          rule: oldSelf != null
+          optionalOldSelf: true
+          rule: oldSelf.hasValue()
     served: true
     storage: true
     subresources:

helm/temporal-worker-controller-crds/templates/temporal.io_temporalworkerdeployments.yaml

@@ -4216,7 +4216,8 @@ spec:
           rule: size(self.metadata.name) <= 63
         - message: TemporalWorkerDeployment is deprecated and cannot be created. Use
             WorkerDeployment instead.
-          rule: oldSelf != null
+          optionalOldSelf: true
+          rule: oldSelf.hasValue()
     served: true
     storage: true
     subresources: