Make TemporalWorkerDeploymentFinalizer constant internal

Changed the exported constant TemporalWorkerDeploymentFinalizer to
temporalWorkerDeploymentFinalizer (lowercase) to make it package-private
since it's only used within the controller package.

Addresses: #97 (comment)

Author: jlegrone

internal/controller/finalizer_test.go

@@ -54,7 +54,7 @@ func TestFinalizerAddition(t *testing.T) {
 	}
 
 	// Verify finalizer is not present initially
-	if controllerutil.ContainsFinalizer(workerDeploy, TemporalWorkerDeploymentFinalizer) {
+	if controllerutil.ContainsFinalizer(workerDeploy, temporalWorkerDeploymentFinalizer) {
 		t.Error("Finalizer should not be present initially")
 	}
 
@@ -79,7 +79,7 @@ func TestFinalizerAddition(t *testing.T) {
 	}
 
 	// Verify finalizer was added
-	if !controllerutil.ContainsFinalizer(updated, TemporalWorkerDeploymentFinalizer) {
+	if !controllerutil.ContainsFinalizer(updated, temporalWorkerDeploymentFinalizer) {
 		t.Error("Finalizer should be present after update")
 	}
 }
@@ -202,7 +202,7 @@ func TestHandleDeletion(t *testing.T) {
 	workerDeploy := testhelpers.ModifyObj(testhelpers.MakeTWDWithName("test-worker", "default"), func(twd *temporaliov1alpha1.TemporalWorkerDeployment) *temporaliov1alpha1.TemporalWorkerDeployment {
 		twd.UID = "worker-uid-123"
 		twd.DeletionTimestamp = &now
-		twd.Finalizers = []string{TemporalWorkerDeploymentFinalizer}
+		twd.Finalizers = []string{temporalWorkerDeploymentFinalizer}
 		twd.Spec.WorkerOptions = temporaliov1alpha1.WorkerOptions{
 			TemporalNamespace:  "test-namespace",
 			TemporalConnection: "test-connection",
@@ -222,7 +222,7 @@ func TestHandleDeletion(t *testing.T) {
 	logger := testlogr.New(t)
 
 	// Verify finalizer is present before deletion
-	if !controllerutil.ContainsFinalizer(workerDeploy, TemporalWorkerDeploymentFinalizer) {
+	if !controllerutil.ContainsFinalizer(workerDeploy, temporalWorkerDeploymentFinalizer) {
 		t.Error("Finalizer should be present before deletion handling")
 	}
 

internal/controller/worker_controller.go

@@ -37,8 +37,8 @@ const (
 	// TODO(jlegrone): add this everywhere
 	deployOwnerKey = ".metadata.controller"
 	buildIDLabel   = "temporal.io/build-id"
-	// TemporalWorkerDeploymentFinalizer is the finalizer used to ensure proper cleanup of resources
-	TemporalWorkerDeploymentFinalizer = "temporal.io/temporal-worker-deployment-finalizer"
+	// temporalWorkerDeploymentFinalizer is the finalizer used to ensure proper cleanup of resources
+	temporalWorkerDeploymentFinalizer = "temporal.io/temporal-worker-deployment-finalizer"
 
 	// Cleanup timeout and polling constants
 	cleanupTimeout      = 2 * time.Minute
@@ -94,8 +94,8 @@ func (r *TemporalWorkerDeploymentReconciler) Reconcile(ctx context.Context, req
 	}
 
 	// Add finalizer if it doesn't exist
-	if !controllerutil.ContainsFinalizer(&workerDeploy, TemporalWorkerDeploymentFinalizer) {
-		controllerutil.AddFinalizer(&workerDeploy, TemporalWorkerDeploymentFinalizer)
+	if !controllerutil.ContainsFinalizer(&workerDeploy, temporalWorkerDeploymentFinalizer) {
+		controllerutil.AddFinalizer(&workerDeploy, temporalWorkerDeploymentFinalizer)
 		if err := r.Update(ctx, &workerDeploy); err != nil {
 			l.Error(err, "unable to add finalizer")
 			return ctrl.Result{}, err
@@ -217,7 +217,7 @@ func (r *TemporalWorkerDeploymentReconciler) Reconcile(ctx context.Context, req
 func (r *TemporalWorkerDeploymentReconciler) handleDeletion(ctx context.Context, l logr.Logger, workerDeploy *temporaliov1alpha1.TemporalWorkerDeployment) (ctrl.Result, error) {
 	l.Info("Handling deletion of TemporalWorkerDeployment")
 
-	if !controllerutil.ContainsFinalizer(workerDeploy, TemporalWorkerDeploymentFinalizer) {
+	if !controllerutil.ContainsFinalizer(workerDeploy, temporalWorkerDeploymentFinalizer) {
 		// Finalizer has already been removed, allow deletion to proceed
 		return ctrl.Result{}, nil
 	}
@@ -229,7 +229,7 @@ func (r *TemporalWorkerDeploymentReconciler) handleDeletion(ctx context.Context,
 	}
 
 	// Remove the finalizer to allow deletion
-	controllerutil.RemoveFinalizer(workerDeploy, TemporalWorkerDeploymentFinalizer)
+	controllerutil.RemoveFinalizer(workerDeploy, temporalWorkerDeploymentFinalizer)
 	if err := r.Update(ctx, workerDeploy); err != nil {
 		l.Error(err, "Failed to remove finalizer")
 		return ctrl.Result{}, err