Commit c09c580
authored
<!--- Note to EXTERNAL Contributors -->
<!-- Thanks for opening a PR!
If it is a significant code change, please **make sure there is an open
issue** for this.
We work best with you when we have accepted the idea first before you
code. -->
<!--- For ALL Contributors 👇 -->
## What was changed and why
#### Problem
Namespaces with many TemporalWorkerDeployment objects can trigger
Temporal's per-namespace DescribeWorkerDeployment rate limit
(frontend.globalNamespaceWorkerDeploymentReadRPS, default 50 RPS). When
this happens, the reconciler was returning the error immediately,
causing the workqueue to requeue with an exponential backoff starting at
~5ms — effectively a tight retry loop that makes the rate-limit problem
worse.
The error comes back as *serviceerror.ResourceExhausted (not a standard
gRPC codes.ResourceExhausted status), so it must be detected with
errors.As rather than grpcstatus.FromError.
#### Changes
- internal/controller/worker_controller.go: detect
*serviceerror.ResourceExhausted from GetWorkerDeploymentState and return
RequeueAfter: 30s instead of an immediate error requeue. Sets
ConditionProgressing=False with ReasonTemporalStateFetchFailed and a
"Rate limited" message so the condition is visible to users.
- internal/tests/internal/rate_limit_integration_test.go: new
integration test that creates 10 TWDs against a 1 RPS limit, confirming
the error surfaces with the expected condition reason and message.
- go.mod / go.sum / go.work: bump Temporal server dependency to
v1.31.0-154.2, which is the first version that enforces
globalNamespaceWorkerDeploymentReadRPS.
## Checklist
1. Closes #278
2. How was this tested:
- KUBEBUILDER_ASSETS=.../bin/k8s/1.27.1-darwin-arm64 go test -tags
test_dep ./internal/tests/internal -run "TestIntegration/rate-limit"
-timeout 120s -v passes
- Same test fails when the errors.As block is removed (reverts to
immediate retry with generic message)
- Full integration suite passes: go test -tags test_dep
./internal/tests/internal -run TestIntegration -timeout 600s
3. Any docs updates needed?
<!--- update README if applicable
or point out where to update docs.temporal.io -->
1 parent 1255472 commit c09c580
3 files changed
Lines changed: 115 additions & 0 deletions
File tree
- internal
- controller
- tests/internal
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
242 | 243 | | |
243 | 244 | | |
244 | 245 | | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
245 | 254 | | |
246 | 255 | | |
247 | 256 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
950 | 950 | | |
951 | 951 | | |
952 | 952 | | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
953 | 964 | | |
954 | 965 | | |
955 | 966 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
0 commit comments