address comments

Author: Shivs11

config/rbac/role.yaml

@@ -24,7 +24,7 @@ import (
 type ClientPoolKey struct {
 	HostPort        string
 	Namespace       string
-	MutualTLSSecret string // Include secret name in key to invalidate cache when the secret name itself changes
+	MutualTLSSecret string // Include secret name in key to invalidate cache when the secret name changes
 }
 
 type ClientInfo struct {

config/webhook/manifests.yaml

@@ -226,19 +226,19 @@ func (r *TemporalWorkerDeploymentReconciler) findTWDsUsingConnection(ctx context
 	var requests []reconcile.Request
 
 	// Find all TWDs in same namespace that reference this TC
-	var workers temporaliov1alpha1.TemporalWorkerDeploymentList
-	if err := r.List(ctx, &workers, client.InNamespace(tc.GetNamespace())); err != nil {
+	var twds temporaliov1alpha1.TemporalWorkerDeploymentList
+	if err := r.List(ctx, &twds, client.InNamespace(tc.GetNamespace())); err != nil {
 		return requests
 	}
 
 	// Filter to ones using this connection
-	for _, worker := range workers.Items {
-		if worker.Spec.WorkerOptions.TemporalConnection == tc.GetName() {
-			// Add the TWD object as a reconcile request
+	for _, twd := range twds.Items {
+		if twd.Spec.WorkerOptions.TemporalConnection == tc.GetName() {
+			// Enqueue a reconcile request for this TWD
 			requests = append(requests, reconcile.Request{
 				NamespacedName: types.NamespacedName{
-					Name:      worker.Name,
-					Namespace: worker.Namespace,
+					Name:      twd.Name,
+					Namespace: twd.Namespace,
 				},
 			})
 		}

internal/controller/clientpool/clientpool.go

@@ -88,7 +88,10 @@ func GeneratePlan(
 	return plan, nil
 }
 
-// checkAndUpdateDeploymentConnectionSpec checks if a deployment needs to be updated. This is true if the connection spec it's using is outdated.
+// checkAndUpdateDeploymentConnectionSpec determines whether the Deployment for the given versionID is
+// out-of-date with respect to the provided TemporalConnectionSpec. If an update is required, it mutates
+// the existing Deployment in-place and returns a pointer to that Deployment. If no update is needed or
+// the Deployment does not exist, it returns nil.
 func checkAndUpdateDeploymentConnectionSpec(
 	versionID string,
 	k8sState *k8s.DeploymentState,