Skip to content

Commit fa4e883

Browse files
committed
remove go.work and binaries from source control
There were two binary files in the source code repository. Removed them from source control and added them to .gitignore. Removes the go.work and go.work.sum files as well, since it's best practice to not have those in source control. Finally, moved the go-vet Github Action step from the `test-integration` workflow into the `linters` workflow since `go vet` is a linter. Standardized the linter steps to always cache the setup-go Github Action results. Issue #302 Issue #303 Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
1 parent dc57c5c commit fa4e883

7 files changed

Lines changed: 41 additions & 2347 deletions

File tree

.github/workflows/linters.yml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ jobs:
1515
with:
1616
go-version-file: 'go.mod'
1717
check-latest: true
18+
cache: true
1819

1920
- name: lint actions
2021
run: |
@@ -33,6 +34,7 @@ jobs:
3334
with:
3435
go-version-file: 'go.mod'
3536
check-latest: true
37+
cache: true
3638

3739
- name: format golang import statements
3840
run: |
@@ -58,6 +60,7 @@ jobs:
5860
with:
5961
go-version-file: 'go.mod'
6062
check-latest: true
63+
cache: true
6164

6265
- name: lint code
6366
run: |
@@ -72,12 +75,29 @@ jobs:
7275
exit 1
7376
fi
7477
78+
go-vet:
79+
runs-on: ubuntu-latest
80+
steps:
81+
- uses: actions/checkout@v4
82+
with:
83+
fetch-depth: 0
84+
85+
- uses: actions/setup-go@v5
86+
with:
87+
go-version-file: 'go.mod'
88+
check-latest: true
89+
cache: true
90+
91+
- name: Run go vet
92+
run: go vet ./...
93+
7594
linters-succeed:
7695
name: All Linters Succeed
7796
needs:
7897
- lint-actions
7998
- fmt-imports
8099
- golangci
100+
- go-vet
81101
runs-on: ubuntu-latest
82102
if: always()
83103
env:

.github/workflows/test-integration.yml

Lines changed: 17 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,17 @@ jobs:
6161
steps:
6262
- name: Checkout code
6363
uses: actions/checkout@v4
64-
64+
65+
- name: setup go workspace
66+
run: go work init && go work use -r .
67+
6568
- name: Set up Go
66-
uses: actions/setup-go@v5
69+
uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6.3.0
6770
with:
68-
go-version-file: 'go.mod'
71+
go-version-file: go.work
72+
cache-dependency-path: |
73+
go.work.sum
74+
**/go.sum
6975
check-latest: true
7076
cache: true
7177

@@ -115,11 +121,17 @@ jobs:
115121
steps:
116122
- name: Checkout code
117123
uses: actions/checkout@v4
124+
125+
- name: setup go workspace
126+
run: go work init && go work use -r .
118127

119128
- name: Set up Go
120-
uses: actions/setup-go@v5
129+
uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6.3.0
121130
with:
122-
go-version-file: 'go.mod'
131+
go-version-file: go.work
132+
cache-dependency-path: |
133+
go.work.sum
134+
**/go.sum
123135
check-latest: true
124136
cache: true
125137

@@ -144,24 +156,3 @@ jobs:
144156
cover.out
145157
bin/
146158
retention-days: 7
147-
148-
go-vet:
149-
name: Run Go Vet
150-
runs-on: ubuntu-latest
151-
152-
steps:
153-
- name: Checkout code
154-
uses: actions/checkout@v4
155-
156-
- name: Set up Go
157-
uses: actions/setup-go@v5
158-
with:
159-
go-version-file: 'go.mod'
160-
check-latest: true
161-
cache: true
162-
163-
- name: Download dependencies
164-
run: go mod download
165-
166-
- name: Run go vet
167-
run: go vet ./...

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,7 @@ certs
1212
cover.out
1313

1414
.claude
15-
config
15+
configinternal/demo/worker
16+
internal/demo/helloworld/worker
17+
go.work
18+
go.work.sum

go.work

Lines changed: 0 additions & 7 deletions
This file was deleted.

go.work.sum

Lines changed: 0 additions & 2313 deletions
This file was deleted.

internal/demo/helloworld/worker

-30.3 MB
Binary file not shown.

internal/demo/worker

-30.4 MB
Binary file not shown.

0 commit comments

Comments
 (0)