Skip to content

Commit 187d65e

Browse files
stephanosclaude
andcommitted
Use softassert for "dirty mutable state" log
So failed assertions can be searched/grouped via the FailedAssertion tag. The trailing panic is intentionally left in place; this commit only changes the logger.Error call to softassert.Fail. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent d6e7e59 commit 187d65e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

service/history/workflow/cache/cache.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,8 +377,8 @@ func (c *cacheImpl) makeReleaseFunc(
377377
isDirty := wfContext.IsDirty()
378378
if isDirty {
379379
wfContext.Clear()
380-
logger := log.With(shardContext.GetLogger(), tag.ComponentHistoryCache)
381-
logger.Error("Cache encountered dirty mutable state transaction",
380+
softassert.Fail(shardContext.GetLogger(), "Cache encountered dirty mutable state transaction",
381+
tag.ComponentHistoryCache,
382382
tag.WorkflowNamespaceID(wfContext.GetWorkflowKey().NamespaceID),
383383
tag.WorkflowID(wfContext.GetWorkflowKey().WorkflowID),
384384
tag.WorkflowRunID(wfContext.GetWorkflowKey().RunID),

0 commit comments

Comments
 (0)