Fix sql tool error in windows (#7519)

## What changed?
Use `path.Join()` instead of `filepath.Join()`

## Why?
#7454

## How did you test it?
Tested locally

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
None

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
None

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No

Author: san127127

schema/embed.go

@@ -52,7 +52,7 @@ func PathsByDir(dbSubDir string) []string {
 		}
 		if d.IsDir() {
 			if d.Name() == "versioned" {
-				dirs = append(dirs, filepath.Dir(path))
+				dirs = append(dirs, filepath.ToSlash(filepath.Dir(path)))
 				return fs.SkipDir
 			}
 		}

tools/common/schema/updatetask.go

@@ -30,15 +30,13 @@ import (
 	// should not be used for anything more important (password hashes etc.). Marking it as #nosec because of how it's
 	// being used.
 	"crypto/md5" // #nosec
-	"embed"
 	"encoding/hex"
 	"encoding/json"
 	"fmt"
 	"io"
 	"io/fs"
 	"os"
 	"path"
-	"path/filepath"
 	"regexp"
 	"sort"
 	"strings"
@@ -216,12 +214,7 @@ func (task *UpdateTask) buildChangeSet(currVer string) ([]changeSet, error) {
 	var result []changeSet
 
 	for _, vd := range verDirs {
-		var dirPath string
-		if _, ok := fsys.(embed.FS); ok {
-			dirPath = path.Join(dir, vd)
-		} else {
-			dirPath = filepath.Join(dir, vd)
-		}
+		dirPath := path.Join(dir, vd)
 
 		m, e := readManifest(fsys, dirPath)
 		if e != nil {
@@ -259,12 +252,7 @@ func (task *UpdateTask) parseSQLStmts(fsys fs.FS, dir string, manifest *manifest
 	result := make([]string, 0, 4)
 
 	for _, file := range manifest.SchemaUpdateCqlFiles {
-		var schemaPath string
-		if _, ok := fsys.(embed.FS); ok {
-			schemaPath = path.Join(dir, file)
-		} else {
-			schemaPath = filepath.Join(dir, file)
-		}
+		schemaPath := path.Join(dir, file)
 		task.logger.Info("Processing schema file: " + schemaPath)
 		schemaBuf, err := fs.ReadFile(fsys, schemaPath)
 		if err != nil {
@@ -302,12 +290,8 @@ func validateCQLStmts(stmts []string) error {
 
 // readManifest reads the json manifest at dirPath into a manifest struct.
 func readManifest(fsys fs.FS, dirPath string) (*manifest, error) {
-	var manifestPath string
-	if _, ok := fsys.(embed.FS); ok {
-		manifestPath = path.Join(dirPath, manifestFileName)
-	} else {
-		manifestPath = filepath.Join(dirPath, manifestFileName)
-	}
+	manifestPath := path.Join(dirPath, manifestFileName)
+
 	jsonBlob, err := fs.ReadFile(fsys, manifestPath)
 	if err != nil {
 		return nil, err

tools/sql/README.md

@@ -17,7 +17,8 @@ SQL_USER=$USERNAME SQL_PASSWORD=$PASSWD make install-schema-mysql
 - For other SQL database, you can add it easily as we do for MySQL/Postgres following our code in sql-extensions  
 
 ### Do one time database creation and schema setup for a new cluster
-- All command below are taking MySQL as example. For postgres, simply use with "--plugin postgres12"
+
+- All command below are taking MySQL as example. For postgres, simply use with "--plugin postgres12" and "--schema-name postgresql/v12/temporal" & "--schema-name postgresql/v12/visibility"
 
 ```
 ./temporal-sql-tool --ep $SQL_HOST -p $port --db temporal --plugin mysql8 create
@@ -26,10 +27,12 @@ SQL_USER=$USERNAME SQL_PASSWORD=$PASSWD make install-schema-mysql
 
 ```
 ./temporal-sql-tool --ep $SQL_HOST -p $port --plugin mysql8 --db temporal setup-schema -v 0.0 -- this sets up just the schema version tables with initial version of 0.0
-./temporal-sql-tool --ep $SQL_HOST -p $port --plugin mysql8 --db temporal update-schema -d ./schema/mysql/v8/temporal/versioned -- upgrades your schema to the latest version
+./temporal-sql-tool --ep $SQL_HOST -p $port --plugin mysql8 --db temporal update-schema --schema-name mysql/v8/temporal -- upgrades your schema with the embedded schema
+./temporal-sql-tool --ep $SQL_HOST -p $port --plugin mysql8 --db temporal update-schema -d ./schema/mysql/v8/temporal/versioned -- Or upgrades your schema by providing your schema
 
 ./temporal-sql-tool --ep $SQL_HOST -p $port --plugin mysql8 --db temporal_visibility setup-schema -v 0.0 -- this sets up just the schema version tables with initial version of 0.0 for visibility
-./temporal-sql-tool --ep $SQL_HOST -p $port --plugin mysql8 --db temporal_visibility update-schema -d ./schema/mysql/v8/visibility/versioned  -- upgrades your schema to the latest version for visibility
+./temporal-sql-tool --ep $SQL_HOST -p $port --plugin mysql8 --db temporal update-schema --schema-name mysql/v8/visibility -- upgrades your schema with the embedded schema for visibility
+./temporal-sql-tool --ep $SQL_HOST -p $port --plugin mysql8 --db temporal_visibility update-schema -d ./schema/mysql/v8/visibility/versioned  -- Or upgrades your schema by providing your schema for visibility
 ```
 
 ### Update schema as part of a release