Skip to content

Commit 285606a

Browse files
authored
Removes eager creation of Outcome from SANO (#10153)
## What changed? Removes eager creation of the outcome for standalone nexus operations. ## Why? The eager creation leaves an Outcome around without a variant. This means if the SANO fails, in some circumstances, we'll look up the empty outcome for our result. This does correctly return LastAttemptFailure, but it also trips a softassert. ## How did you test it? - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
1 parent c2df331 commit 285606a

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

chasm/lib/nexusoperation/operation.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ func newStandaloneOperation(
127127
UserMetadata: frontendReq.GetUserMetadata(),
128128
Identity: frontendReq.GetIdentity(),
129129
})
130-
op.Outcome = chasm.NewDataField(ctx, &nexusoperationpb.OperationOutcome{})
131130
op.Visibility = chasm.NewComponentField(ctx, chasm.NewVisibilityWithData(
132131
ctx,
133132
frontendReq.GetSearchAttributes().GetIndexedFields(),

0 commit comments

Comments
 (0)