Skip to content

Commit 2acccd3

Browse files
authored
chore: enable scheduler sentinel creation and chasm scheduler routing (#10185)
## Summary - Sets `EnableCHASMSchedulerRouting` default to `true` — schedule RPCs are now routed to the CHASM (V2) implementation first (with fallback to V1), excluding CreateSchedule. - Sets `EnableCHASMSchedulerSentinels` default to `true` — enables ID-space collision sentinels ahead of enabling CHASM scheduler creation. ## Why Both of these flags need to be enabled if there are any chasm schedules on the cluster.
1 parent 3654a89 commit 2acccd3

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

common/dynamicconfig/constants.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2905,7 +2905,7 @@ instead of the existing (V1) implementation.`,
29052905

29062906
EnableCHASMSchedulerRouting = NewNamespaceBoolSetting(
29072907
"history.enableCHASMSchedulerRouting",
2908-
false,
2908+
true,
29092909
`EnableCHASMSchedulerRouting controls whether schedule RPCs are routed to the CHASM (V2) implementation
29102910
first (with fallback to V1), excluding CreateSchedule.`,
29112911
)
@@ -2919,7 +2919,7 @@ to the CHASM (V2) implementation on active scheduler workflows.`,
29192919

29202920
EnableCHASMSchedulerSentinels = NewNamespaceBoolSetting(
29212921
"history.enableCHASMSchedulerSentinels",
2922-
false,
2922+
true,
29232923
`EnableCHASMSchedulerSentinels enables ID-space collision sentinels, and must be enabled and propagated in advance of EnableCHASMSchedulerCreation.`,
29242924
)
29252925

service/frontend/workflow_handler_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4429,6 +4429,7 @@ func (s *WorkflowHandlerSuite) TestShutdownWorkerWithPartialCancellationFailure(
44294429
func (s *WorkflowHandlerSuite) TestPatchSchedule_TriggerImmediatelyScheduledTime() {
44304430
config := s.newConfig()
44314431
config.EnableSchedules = dc.GetBoolPropertyFnFilteredByNamespace(true)
4432+
config.EnableCHASMSchedulerRouting = dc.GetBoolPropertyFnFilteredByNamespace(false)
44324433
wh := s.getWorkflowHandler(config)
44334434
ctx := context.Background()
44344435

0 commit comments

Comments
 (0)