Validator generator

Author: stephanos

chasm/lib/nexusoperation/frontend.go

@@ -10,10 +10,9 @@ import (
 	"go.temporal.io/api/workflowservice/v1"
 	"go.temporal.io/server/chasm"
 	nexusoperationpb "go.temporal.io/server/chasm/lib/nexusoperation/gen/nexusoperationpb/v1"
-	"go.temporal.io/server/common/log"
 	"go.temporal.io/server/common/namespace"
 	commonnexus "go.temporal.io/server/common/nexus"
-	"go.temporal.io/server/common/searchattribute"
+	"go.temporal.io/server/common/validation"
 	"google.golang.org/protobuf/types/known/durationpb"
 	"google.golang.org/protobuf/types/known/emptypb"
 	"google.golang.org/protobuf/types/known/timestamppb"
@@ -36,30 +35,24 @@ var ErrStandaloneNexusOperationDisabled = serviceerror.NewUnimplemented("Standal
 type frontendHandler struct {
 	client            nexusoperationpb.NexusOperationServiceClient
 	config            *Config
-	logger            log.Logger
 	namespaceRegistry namespace.Registry
 	endpointRegistry  commonnexus.EndpointRegistry
-	saMapperProvider  searchattribute.MapperProvider
-	saValidator       *searchattribute.Validator
+	validatorRegistry *validation.ValidatorRegistry
 }
 
 func NewFrontendHandler(
 	client nexusoperationpb.NexusOperationServiceClient,
 	config *Config,
-	logger log.Logger,
 	namespaceRegistry namespace.Registry,
 	endpointRegistry commonnexus.EndpointRegistry,
-	saMapperProvider searchattribute.MapperProvider,
-	saValidator *searchattribute.Validator,
+	validatorRegistry *validation.ValidatorRegistry,
 ) FrontendHandler {
 	return &frontendHandler{
 		client:            client,
 		config:            config,
-		logger:            logger,
 		namespaceRegistry: namespaceRegistry,
 		endpointRegistry:  endpointRegistry,
-		saMapperProvider:  saMapperProvider,
-		saValidator:       saValidator,
+		validatorRegistry: validatorRegistry,
 	}
 }
 
@@ -76,7 +69,11 @@ func (h *frontendHandler) StartNexusOperationExecution(
 		return nil, err
 	}
 
-	if err := validateAndNormalizeStartRequest(req, h.config, h.logger, h.saMapperProvider, h.saValidator); err != nil {
+	validator, ok := validation.ValidatorFor[workflowservice.StartNexusOperationExecutionRequest](h.validatorRegistry)
+	if !ok {
+		return nil, serviceerror.NewInternal("validator is not registered for StartNexusOperationExecutionRequest")
+	}
+	if err := validator.ValidateAndNormalize(req); err != nil {
 		return nil, err
 	}
 

chasm/lib/nexusoperation/fx.go

@@ -48,6 +48,7 @@ var Module = fx.Module(
 var FrontendModule = fx.Module(
 	"chasm.lib.nexusoperation.frontend",
 	fx.Provide(configProvider),
+	validatorModule,
 	fx.Provide(nexusoperationpb.NewNexusOperationServiceLayeredClient),
 	fx.Provide(NewFrontendHandler),
 	fx.Provide(newComponentOnlyLibrary),

chasm/lib/nexusoperation/validator.go

@@ -0,0 +1,6 @@
+go.temporal.io/api/workflowservice/v1.StartNexusOperationExecutionRequest
+go.temporal.io/api/workflowservice/v1.DescribeNexusOperationExecutionRequest
+go.temporal.io/api/workflowservice/v1.PollNexusOperationExecutionRequest
+go.temporal.io/api/workflowservice/v1.RequestCancelNexusOperationExecutionRequest
+go.temporal.io/api/workflowservice/v1.TerminateNexusOperationExecutionRequest
+go.temporal.io/api/workflowservice/v1.DeleteNexusOperationExecutionRequest