Validator generator

Author: stephanos

chasm/lib/nexusoperation/frontend.go

@@ -10,10 +10,9 @@ import (
 	"go.temporal.io/api/workflowservice/v1"
 	"go.temporal.io/server/chasm"
 	nexusoperationpb "go.temporal.io/server/chasm/lib/nexusoperation/gen/nexusoperationpb/v1"
-	"go.temporal.io/server/common/log"
 	"go.temporal.io/server/common/namespace"
 	commonnexus "go.temporal.io/server/common/nexus"
-	"go.temporal.io/server/common/searchattribute"
+	"go.temporal.io/server/common/validation"
 	"google.golang.org/protobuf/types/known/durationpb"
 	"google.golang.org/protobuf/types/known/emptypb"
 	"google.golang.org/protobuf/types/known/timestamppb"
@@ -36,30 +35,24 @@ var ErrStandaloneNexusOperationDisabled = serviceerror.NewUnimplemented("Standal
 type frontendHandler struct {
 	client            nexusoperationpb.NexusOperationServiceClient
 	config            *Config
-	logger            log.Logger
 	namespaceRegistry namespace.Registry
 	endpointRegistry  commonnexus.EndpointRegistry
-	saMapperProvider  searchattribute.MapperProvider
-	saValidator       *searchattribute.Validator
+	validatorRegistry *validation.ValidatorRegistry
 }
 
 func NewFrontendHandler(
 	client nexusoperationpb.NexusOperationServiceClient,
 	config *Config,
-	logger log.Logger,
 	namespaceRegistry namespace.Registry,
 	endpointRegistry commonnexus.EndpointRegistry,
-	saMapperProvider searchattribute.MapperProvider,
-	saValidator *searchattribute.Validator,
+	validatorRegistry *validation.ValidatorRegistry,
 ) FrontendHandler {
 	return &frontendHandler{
 		client:            client,
 		config:            config,
-		logger:            logger,
 		namespaceRegistry: namespaceRegistry,
 		endpointRegistry:  endpointRegistry,
-		saMapperProvider:  saMapperProvider,
-		saValidator:       saValidator,
+		validatorRegistry: validatorRegistry,
 	}
 }
 
@@ -76,7 +69,7 @@ func (h *frontendHandler) StartNexusOperationExecution(
 		return nil, err
 	}
 
-	if err := validateAndNormalizeStartRequest(req, h.config, h.logger, h.saMapperProvider, h.saValidator); err != nil {
+	if err := validation.ValidateAndNormalize(h.validatorRegistry, req); err != nil {
 		return nil, err
 	}
 
@@ -107,7 +100,7 @@ func (h *frontendHandler) DescribeNexusOperationExecution(
 		return nil, err
 	}
 
-	if err := validateAndNormalizeDescribeRequest(req, namespaceID.String(), h.config); err != nil {
+	if err := newDescribeNexusOperationExecutionRequestValidator(h.config, namespaceID.String()).ValidateAndNormalize(req); err != nil {
 		return nil, err
 	}
 
@@ -127,7 +120,7 @@ func (h *frontendHandler) PollNexusOperationExecution(
 		return nil, ErrStandaloneNexusOperationDisabled
 	}
 
-	if err := validateAndNormalizePollRequest(req, h.config); err != nil {
+	if err := validation.ValidateAndNormalize(h.validatorRegistry, req); err != nil {
 		return nil, err
 	}
 
@@ -248,7 +241,7 @@ func (h *frontendHandler) RequestCancelNexusOperationExecution(
 		return nil, err
 	}
 
-	if err := validateAndNormalizeCancelRequest(req, h.config); err != nil {
+	if err := validation.ValidateAndNormalize(h.validatorRegistry, req); err != nil {
 		return nil, err
 	}
 
@@ -276,7 +269,7 @@ func (h *frontendHandler) TerminateNexusOperationExecution(
 		return nil, err
 	}
 
-	if err := validateAndNormalizeTerminateRequest(req, h.config); err != nil {
+	if err := validation.ValidateAndNormalize(h.validatorRegistry, req); err != nil {
 		return nil, err
 	}
 
@@ -304,7 +297,7 @@ func (h *frontendHandler) DeleteNexusOperationExecution(
 		return nil, err
 	}
 
-	if err := validateAndNormalizeDeleteRequest(req, h.config); err != nil {
+	if err := validation.ValidateAndNormalize(h.validatorRegistry, req); err != nil {
 		return nil, err
 	}
 

chasm/lib/nexusoperation/fx.go

@@ -8,7 +8,6 @@ import (
 	"go.temporal.io/api/serviceerror"
 	persistencespb "go.temporal.io/server/api/persistence/v1"
 	"go.temporal.io/server/chasm"
-	nexusoperationpb "go.temporal.io/server/chasm/lib/nexusoperation/gen/nexusoperationpb/v1"
 	"go.temporal.io/server/common"
 	"go.temporal.io/server/common/cluster"
 	"go.temporal.io/server/common/collection"
@@ -47,15 +46,7 @@ var Module = fx.Module(
 
 var FrontendModule = fx.Module(
 	"chasm.lib.nexusoperation.frontend",
-	fx.Provide(configProvider),
-	fx.Provide(nexusoperationpb.NewNexusOperationServiceLayeredClient),
-	fx.Provide(NewFrontendHandler),
-	fx.Provide(newComponentOnlyLibrary),
-	fx.Invoke(func(l *componentOnlyLibrary, registry *chasm.Registry) error {
-		// Frontend needs to register the component in order to serialize ComponentRefs, but doesn't
-		// need task handlers.
-		return registry.Register(l)
-	}),
+	ValidatorModule,
 )
 
 func register(