Skip to content

Commit fc5178e

Browse files
authored
Avoid making Temporal API calls if unauthenticated (#105)
1 parent 9804b43 commit fc5178e

2 files changed

Lines changed: 30 additions & 0 deletions

File tree

server/routes/api.go

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ func SetAPIRoutes(e *echo.Echo, cfgProvider *config.ConfigProviderWithRefresh) e
5050

5151
func temporalAPIHandler(cfgProvider *config.ConfigProviderWithRefresh) echo.HandlerFunc {
5252
return func(c echo.Context) error {
53+
err := validateAuth(c, cfgProvider)
54+
if err != nil {
55+
return err
56+
}
57+
5358
cfg, err := cfgProvider.GetConfig()
5459
if err != nil {
5560
return c.JSON(http.StatusInternalServerError, err)
@@ -165,3 +170,27 @@ func withAuth(c echo.Context) runtime.ServeMuxOption {
165170
},
166171
)
167172
}
173+
174+
func validateAuth(c echo.Context, cfgProvider *config.ConfigProviderWithRefresh) error {
175+
cfg, err := cfgProvider.GetConfig()
176+
if err != nil {
177+
return err
178+
}
179+
180+
isEnabled := cfg.Auth.Enabled
181+
if !isEnabled {
182+
return nil
183+
}
184+
185+
sess, _ := session.Get("auth", c)
186+
if sess == nil {
187+
return echo.NewHTTPError(http.StatusUnauthorized, "unauthorized")
188+
}
189+
190+
token := sess.Values["access-token"]
191+
if token == nil {
192+
return echo.NewHTTPError(http.StatusUnauthorized, "unauthorized")
193+
}
194+
195+
return nil
196+
}

server/server.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ var uiHTML []byte
4545
// https://github.com/sveltejs/kit/pull/1370#issuecomment-853306453
4646
//go:embed generated/ui/*
4747
//go:embed generated/ui/_app/assets/pages/*
48+
//go:embed generated/ui/_app/assets/_*
4849
//go:embed generated/ui/_app/chunks/*
4950
//go:embed generated/ui/_app/pages/*
5051
//go:embed generated/ui/_app/assets/pages/namespaces/\[namespace\]/workflows/\[workflow\]/\[run\]/history/compact/activity-\[eventId\]/*

0 commit comments

Comments
 (0)