Skip to content

Commit 06d9092

Browse files
authored
Only decode on onMount to prevent overfetching payloads (#2750)
1 parent afa0e8e commit 06d9092

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

src/lib/components/event/payload-decoder.svelte

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
<script lang="ts">
2+
import { onMount } from 'svelte';
3+
24
import { page } from '$app/stores';
35
46
import { authUser } from '$lib/stores/auth-user';
@@ -27,22 +29,22 @@
2729
let keyedValue = key && value?.[key] ? value[key] : value;
2830
let decodedValue = stringifyWithBigInt(keyedValue);
2931
30-
$: endpoint = getCodecEndpoint($page.data.settings);
31-
$: passAccessToken = getCodecPassAccessToken($page.data.settings);
32-
$: includeCredentials = getCodecIncludeCredentials($page.data.settings);
33-
$: settings = {
34-
...$page.data.settings,
35-
codec: {
36-
...$page.data.settings?.codec,
37-
endpoint,
38-
passAccessToken,
39-
includeCredentials,
40-
},
41-
};
32+
onMount(() => {
33+
decodePayloads(value);
34+
});
4235
4336
const decodePayloads = async (
4437
_value: PotentiallyDecodable | EventAttribute | WorkflowEvent | Memo,
4538
) => {
39+
const settings = {
40+
...$page.data.settings,
41+
codec: {
42+
...$page.data.settings?.codec,
43+
endpoint: getCodecEndpoint($page.data.settings),
44+
passAccessToken: getCodecPassAccessToken($page.data.settings),
45+
includeCredentials: getCodecIncludeCredentials($page.data.settings),
46+
},
47+
};
4648
try {
4749
const convertedAttributes = await cloneAllPotentialPayloadsWithCodec(
4850
_value,
@@ -66,8 +68,6 @@
6668
console.error('Could not decode payloads');
6769
}
6870
};
69-
70-
$: decodePayloads(value);
7171
</script>
7272

7373
<slot {decodedValue} />

0 commit comments

Comments
 (0)