fix standalone activity routes and prep for release (#3168)

rossedfort · web-flow · commit 1ee50fcb1630 · 2026-02-19T12:34:07.000-07:00
* fix standalone activity routes and prep for release

* add version check to guard

* fix import

* fix import
diff --git a/server/go.mod b/server/go.mod
@@ -11,7 +11,7 @@ require (
 	github.com/labstack/echo/v4 v4.13.4
 	github.com/stretchr/testify v1.10.0
 	github.com/urfave/cli/v2 v2.3.0
-	go.temporal.io/api v1.60.2
+	go.temporal.io/api v1.61.0
 	golang.org/x/net v0.47.0
 	golang.org/x/oauth2 v0.30.0
 	google.golang.org/grpc v1.66.1
diff --git a/server/go.sum b/server/go.sum
@@ -68,8 +68,8 @@ github.com/valyala/bytebufferpool v1.0.0 h1:GqA5TC/0021Y/b9FG4Oi9Mr3q7XYx6Kllzaw
 github.com/valyala/bytebufferpool v1.0.0/go.mod h1:6bBcMArwyJ5K/AmCkWv1jt77kVWyCJ6HpOuEn7z0Csc=
 github.com/valyala/fasttemplate v1.2.2 h1:lxLXG0uE3Qnshl9QyaK6XJxMXlQZELvChBOCmQD0Loo=
 github.com/valyala/fasttemplate v1.2.2/go.mod h1:KHLXt3tVN2HBp8eijSv/kGJopbvo7S+qRAEEKiv+SiQ=
-go.temporal.io/api v1.60.2 h1:xqUqdPeOu8/HNWVPu51P6tVoBJ5kRh8nBI62xXi+IWg=
-go.temporal.io/api v1.60.2/go.mod h1:iaxoP/9OXMJcQkETTECfwYq4cw/bj4nwov8b3ZLVnXM=
+go.temporal.io/api v1.61.0 h1:gGIvUu1pRE9yVKqlirYd5FGDT5N/hvcZ0tlB4mRvVM4=
+go.temporal.io/api v1.61.0/go.mod h1:iaxoP/9OXMJcQkETTECfwYq4cw/bj4nwov8b3ZLVnXM=
 golang.org/x/crypto v0.45.0 h1:jMBrvKuj23MTlT0bQEOBcAE0mjg8mK9RXFhRH6nyF3Q=
 golang.org/x/crypto v0.45.0/go.mod h1:XTGrrkGJve7CYK7J8PEww4aY7gM3qMCElcJQ8n8JdX4=
 golang.org/x/net v0.47.0 h1:Mx+4dIFzqraBXUugkia1OOvlD6LemFo1ALMHjrXDOhY=
diff --git a/src/lib/components/standalone-activities/activities-summary-configurable-table/table-body-cell.svelte b/src/lib/components/standalone-activities/activities-summary-configurable-table/table-body-cell.svelte
@@ -55,6 +55,7 @@
         href={routeForStandaloneActivityDetails({
           namespace,
           activityId: activity.activityId,
+          runId: activity.runId,
         })}
       />
     {:else if label === 'Activity Type'}
diff --git a/src/lib/components/standalone-activities/activity-input-and-outcome.svelte b/src/lib/components/standalone-activities/activity-input-and-outcome.svelte
@@ -24,7 +24,7 @@
     </PayloadDecoder>
   </div>
   <div class="flex flex-col gap-2">
-    <h5>Outcome</h5>
+    <h5>Result</h5>
     {#if has(outcome, 'failure')}
       <CodeBlock content={JSON.stringify(outcome.failure, null, 2)} />
     {:else if has(outcome, 'result')}
diff --git a/src/lib/components/standalone-activities/standalone-activities-disabled.svelte b/src/lib/components/standalone-activities/standalone-activities-disabled.svelte
@@ -3,11 +3,14 @@
   import CodeBlock from '$lib/holocene/code-block.svelte';
   import { translate } from '$lib/i18n/translate';
 
+  import PageTitle from '../page-title.svelte';
+
   interface Props {
     namespace: string;
+    href: string;
   }
 
-  let { namespace }: Props = $props();
+  let { namespace, href }: Props = $props();
 
   const configValues = `history.enableTransitionHistory:
   - value: true
@@ -22,6 +25,13 @@ activity.enableStandalone:
       namespace: ${namespace}`);
 </script>
 
+<PageTitle
+  title="{translate(
+    'standalone-activities.standalone-activities',
+  )} | {namespace}"
+  url={href}
+/>
+
 <h1>Standalone Activities</h1>
 <Alert
   title={translate('standalone-activities.standalone-activities-disabled')}
diff --git a/src/lib/components/standalone-activities/standalone-activities-guard.svelte b/src/lib/components/standalone-activities/standalone-activities-guard.svelte
@@ -1,7 +1,9 @@
 <script lang="ts">
   import type { Snippet } from 'svelte';
 
+  import { temporalVersion } from '$lib/stores/versions';
   import type { DescribeNamespaceResponse } from '$lib/types';
+  import { minimumVersionRequired } from '$lib/utilities/version-check';
 
   interface Props {
     namespace: DescribeNamespaceResponse;
@@ -12,7 +14,7 @@
   let { namespace, children, fallback }: Props = $props();
 </script>
 
-{#if namespace.namespaceInfo?.capabilities?.standaloneActivities}
+{#if namespace.namespaceInfo?.capabilities?.standaloneActivities && minimumVersionRequired('1.30.0', $temporalVersion)}
   {@render children()}
 {:else if fallback}
   {@render fallback()}
diff --git a/src/lib/components/standalone-activities/start-standalone-activity-form/form.svelte b/src/lib/components/standalone-activities/start-standalone-activity-form/form.svelte
@@ -140,7 +140,7 @@
         if (!form.valid) return;
 
         try {
-          startStandaloneActivity({
+          const { runId } = await startStandaloneActivity({
             ...form.data,
             searchAttributes,
           });
@@ -151,6 +151,7 @@
             link: routeForStandaloneActivityDetails({
               namespace,
               activityId: form.data.activityId,
+              runId,
             }),
           });
           return { type: 'success' };
diff --git a/src/lib/layouts/standalone-activity-layout.svelte b/src/lib/layouts/standalone-activity-layout.svelte
@@ -27,14 +27,21 @@
     activityExecution: ActivityExecution;
     namespace: string;
     activityId: string;
+    runId: string;
     children: Snippet;
     poller: StandaloneActivityPoller;
   }
 
-  let { activityExecution, children, namespace, activityId, poller }: Props =
-    $props();
+  let {
+    activityExecution,
+    children,
+    namespace,
+    activityId,
+    runId,
+    poller,
+  }: Props = $props();
 
-  const routeParameters = $derived({ namespace, activityId });
+  const routeParameters = $derived({ namespace, activityId, runId });
 
   const detailsRoute = $derived(
     routeForStandaloneActivityDetails(routeParameters),
diff --git a/src/lib/services/standalone-activities.ts b/src/lib/services/standalone-activities.ts
@@ -22,6 +22,11 @@ export type ListActivitiesResponse = {
   nextPageToken: string;
 };
 
+export interface StartStandaloneActivityResponse {
+  runId: string;
+  started: boolean;
+}
+
 export type PaginatedActivitiesPromise = (
   pageSize?: number,
   token?: string,
@@ -163,7 +168,7 @@ const toStartActivityExecutionRequest = async (
 
 export const startStandaloneActivity = async (
   activity: StandaloneActivityFormData,
-) => {
+): Promise<StartStandaloneActivityResponse> => {
   const { activityId, namespace } = activity;
 
   const route = routeForApi('standalone-activity', {
@@ -191,6 +196,7 @@ export const getActivityExecutions = (namespace: string) => {
 export const getActivityExecution = (
   namespace: string,
   activityId: string,
+  runId: string,
 ): Promise<ActivityExecution> => {
   const route = routeForApi('standalone-activity', {
     namespace,
@@ -200,6 +206,7 @@ export const getActivityExecution = (
   const params = new URLSearchParams({
     includeInput: 'true',
     includeOutcome: 'true',
+    runId,
   });
 
   return requestFromAPI(route, {
diff --git a/src/lib/utilities/route-for.ts b/src/lib/utilities/route-for.ts
@@ -135,33 +135,37 @@ export const routeForStartStandaloneActivity = (
 };
 
 const routeForStandaloneActivityBase = (
-  parameters: NamespaceParameter & { activityId: string },
+  parameters: NamespaceParameter & { activityId: string; runId: string },
 ) => {
-  return resolve(`${routeForStandaloneActivities(parameters)}/[activityId]`, {
-    activityId: parameters.activityId,
-  });
+  return resolve(
+    `${routeForStandaloneActivities(parameters)}/[activityId]/[runId]`,
+    {
+      activityId: parameters.activityId,
+      runId: parameters.runId,
+    },
+  );
 };
 
 export const routeForStandaloneActivityDetails = (
-  parameters: NamespaceParameter & { activityId: string },
+  parameters: NamespaceParameter & { activityId: string; runId: string },
 ) => {
   return `${routeForStandaloneActivityBase(parameters)}/details`;
 };
 
 export const routeForStandaloneActivityWorkers = (
-  parameters: NamespaceParameter & { activityId: string },
+  parameters: NamespaceParameter & { activityId: string; runId: string },
 ) => {
   return `${routeForStandaloneActivityBase(parameters)}/workers`;
 };
 
 export const routeForStandaloneActivitySearchAttributes = (
-  parameters: NamespaceParameter & { activityId: string },
+  parameters: NamespaceParameter & { activityId: string; runId: string },
 ) => {
   return `${routeForStandaloneActivityBase(parameters)}/search-attributes`;
 };
 
 export const routeForStandaloneActivityMetadata = (
-  parameters: NamespaceParameter & { activityId: string },
+  parameters: NamespaceParameter & { activityId: string; runId: string },
 ) => {
   return `${routeForStandaloneActivityBase(parameters)}/metadata`;
 };
diff --git a/src/lib/utilities/standalone-activity-poller.svelte.ts b/src/lib/utilities/standalone-activity-poller.svelte.ts
@@ -23,12 +23,14 @@ export class StandaloneActivityPoller {
   constructor(
     namespace: string,
     activityId: string,
+    runId: string,
     abortController: AbortController,
     onUpdate: (activityExecution: ActivityExecution) => void,
     onError: (error: Error) => void,
   ) {
     this.namespace = namespace;
     this.activityId = activityId;
+    this.runId = runId;
     this.abortController = abortController;
     this.onUpdate = onUpdate;
     this.onError = onError;
@@ -40,6 +42,7 @@ export class StandaloneActivityPoller {
       activityExecution = await getActivityExecution(
         this.namespace,
         this.activityId,
+        this.runId,
       );
     } catch (error) {
       this.onError(error);
@@ -48,7 +51,6 @@ export class StandaloneActivityPoller {
     this.onUpdate(activityExecution);
 
     if (activityExecution.info.status === 'ACTIVITY_EXECUTION_STATUS_RUNNING') {
-      this.runId = activityExecution.runId;
       this.token = activityExecution.longPollToken;
 
       while (!this.abortController.signal.aborted) {
@@ -84,6 +86,7 @@ export class StandaloneActivityPoller {
     const activityExecution = await getActivityExecution(
       this.namespace,
       this.activityId,
+      this.runId,
     );
     this.onUpdate(activityExecution);
   }
diff --git a/src/routes/(app)/+layout.svelte b/src/routes/(app)/+layout.svelte
@@ -21,6 +21,7 @@
   import { inProgressBatchOperation } from '$lib/stores/batch-operations';
   import { lastUsedNamespace, namespaces } from '$lib/stores/namespaces';
   import { toaster } from '$lib/stores/toaster';
+  import { temporalVersion } from '$lib/stores/versions';
   import type { NamespaceListItem, NavLinkListItem } from '$lib/types/global';
   import { setCoreContext } from '$lib/utilities/core-context';
   import DarkMode from '$lib/utilities/dark-mode';
@@ -36,6 +37,7 @@
     routeForWorkerDeployments,
     routeForWorkflows,
   } from '$lib/utilities/route-for';
+  import { minimumVersionRequired } from '$lib/utilities/version-check';
 
   import type { DescribeNamespaceResponse as Namespace } from '$types';
 
@@ -128,13 +130,13 @@
         label: translate('common.workflows'),
         isActive: (path) => path.includes(workflowsRoute),
       },
-      // Uncomment this when Standalone Activities is ready to release
-      // {
-      //   href: standaloneActivitiesRoute,
-      //   icon: 'activity',
-      //   label: translate('standalone-activities.standalone-activities'),
-      //   isActive: (path) => path.includes(standaloneActivitiesRoute),
-      // },
+      {
+        href: standaloneActivitiesRoute,
+        icon: 'activity',
+        label: translate('standalone-activities.standalone-activities'),
+        isActive: (path) => path.includes(standaloneActivitiesRoute),
+        hidden: !minimumVersionRequired('1.30.0', $temporalVersion),
+      },
       {
         href: schedulesRoute,
         icon: 'schedules',
diff --git a/src/routes/(app)/namespaces/[namespace]/activities/+layout.svelte b/src/routes/(app)/namespaces/[namespace]/activities/+layout.svelte
@@ -1,21 +1,20 @@
 <script lang="ts">
-  import type { Snippet } from 'svelte';
-
   import { page } from '$app/state';
 
+  import type { LayoutProps } from './$types';
+
   import StandaloneActivitiesDisabled from '$lib/components/standalone-activities/standalone-activities-disabled.svelte';
   import StandaloneActivitiesGuard from '$lib/components/standalone-activities/standalone-activities-guard.svelte';
 
-  interface Props {
-    children: Snippet;
-  }
-
-  let { children }: Props = $props();
+  let { children }: LayoutProps = $props();
 </script>
 
 <StandaloneActivitiesGuard namespace={page.data.namespace}>
   {@render children()}
   {#snippet fallback()}
-    <StandaloneActivitiesDisabled namespace={page.params.namespace} />
+    <StandaloneActivitiesDisabled
+      href={page.url.href}
+      namespace={page.params.namespace}
+    />
   {/snippet}
 </StandaloneActivitiesGuard>
diff --git a/src/routes/(app)/namespaces/[namespace]/activities/+layout.ts b/src/routes/(app)/namespaces/[namespace]/activities/+layout.ts
diff --git a/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/+layout.svelte b/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/+layout.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
   import { onDestroy, onMount } from 'svelte';
 
-  import { page } from '$app/state';
+  import type { LayoutProps } from './$types';
 
   import ErrorComponent from '$lib/holocene/error.svelte';
   import StandaloneActivityLayout from '$lib/layouts/standalone-activity-layout.svelte';
@@ -10,15 +10,20 @@
     StandaloneActivityPoller,
   } from '$lib/utilities/standalone-activity-poller.svelte';
 
-  const namespace = $derived(page.params.namespace);
-  const activityId = $derived(page.params.activityId);
+  let { params, children }: LayoutProps = $props();
+
+  const namespace = $derived(params.namespace);
+  const activityId = $derived(params.activityId);
+  const runId = $derived(params.runId);
+
   let error = $state<Error | undefined>();
 
   const activityPollerAbortController = new AbortController();
   const poller = $derived(
     new StandaloneActivityPoller(
       namespace,
       activityId,
+      runId,
       activityPollerAbortController,
       (execution) => {
         $activityExecution = execution;
@@ -36,8 +41,6 @@
   onDestroy(() => {
     poller.abort();
   });
-
-  let { children } = $props();
 </script>
 
 {#if error}
@@ -48,6 +51,7 @@
     activityExecution={$activityExecution}
     {namespace}
     {activityId}
+    {runId}
   >
     {@render children()}
   </StandaloneActivityLayout>
diff --git a/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/+page.ts b/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/+page.ts
diff --git a/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/details/+page.svelte b/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/details/+page.svelte
diff --git a/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/metadata/+page.svelte b/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/metadata/+page.svelte
diff --git a/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/search-attributes/+page.svelte b/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/search-attributes/+page.svelte
diff --git a/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/workers/+page.svelte b/src/routes/(app)/namespaces/[namespace]/activities/[activityId]/[runId]/workers/+page.svelte
