refactor(decode-payload): clean up decode-payload.ts API surface (#3302)

* docs: add decode-payload usage report and refactoring recommendations

* refactor(decode-payload): remove convertPayloadToJsonWithCodec and decodeAllPotentialPayloadsWithCodec

Replace all call sites with cloneAllPotentialPayloadsWithCodec directly,
eliminating the duplicate recursive walker and its named-param wrapper.

* refactor(decode-payload): rename functions for clarity

decodePayload → decodeRawPayload
decodePayloads → applyCodecToPayloads
decodeReadablePayloads → decodePayloadsWithCodec
decodeSingleReadablePayloadWithCodec → decodeUserMetadataPayload
cloneAllPotentialPayloadsWithCodec → decodeEventAttributes
isSinglePayload → isRawPayload

* refactor(decode-payload): remove namespace param from decodeEventAttributes

The namespace argument was unused inside the function body. Removing it
simplifies all call sites and makes the signature match actual behavior.

* refactor(decode-payload): isolate returnDataOnly=false into decodeEventAttributesForExport

Remove the returnDataOnly parameter from the public decodeEventAttributes
API. Extract a dedicated decodeEventAttributesForExport function for the
two callers (export-history, workflow-service) that need to preserve the
full payload structure with metadata.

* refactor(decode-payload): unify searchAttributes decode branches

Collapse the two separate branches in decodePayloadAttributes — one for
indexedFields and one for flat searchAttributes — into a single branch
that selects the correct target object via ternary.

Fix stale test mocks in get-event-attributes and to-event-history that
still referenced the removed convertPayloadToJsonWithCodec export.

* refactor(decode-payload): remove settings from decode-payload/data-encoder cascade

data-encoder.ts now reads settings and namespace directly from page state
instead of accepting them as parameters. This removes the need to thread
settings through every call site in the chain: components → services →
decode-payload → data-encoder.

- codeServerRequest/decodePayloadsWithCodec/encodePayloadsWithCodec drop settings+namespace params
- decodeEventAttributes/decodeEventAttributesForExport drop settings param
- getEventAttributes takes HistoryEvent directly instead of EventWithMetadata
- EventRequestMetadata.settings field removed
- pending-activities model deleted (settings removal collapsed it to a no-op wrapper)
- All tests updated to set codecEndpoint/passAccessToken/includeCredentials stores directly

* add call site map

* add phases

* rename

* fix tests

* fix workflow query and metadata call sites

* remove AI generated docs

* Add inline comments to decode-payload utils

Author: rossedfort

src/lib/components/event/event-summary-row.svelte

@@ -187,18 +187,12 @@
 
   onMount(async () => {
     if (isLocalActivityMarkerEvent(event)) {
-      primaryLocalAttribute = await decodeLocalActivity(event, {
-        namespace: page.params.namespace,
-        settings: page.data.settings,
-      });
+      primaryLocalAttribute = await decodeLocalActivity(event);
     } else if (
       isEventGroup(event) &&
       isLocalActivityMarkerEvent(event.initialEvent)
     ) {
-      primaryLocalAttribute = await decodeLocalActivity(event.initialEvent, {
-        namespace: page.params.namespace,
-        settings: page.data.settings,
-      });
+      primaryLocalAttribute = await decodeLocalActivity(event.initialEvent);
     }
   });
 </script>

src/lib/components/event/metadata-decoder.svelte

@@ -1,13 +1,6 @@
 <script lang="ts">
-  import { page } from '$app/stores';
-
   import type { Payload } from '$lib/types';
-  import { decodeSingleReadablePayloadWithCodec } from '$lib/utilities/decode-payload';
-  import {
-    getCodecEndpoint,
-    getCodecIncludeCredentials,
-    getCodecPassAccessToken,
-  } from '$lib/utilities/get-codec';
+  import { decodeUserMetadata } from '$lib/utilities/decode-payload';
 
   export let value: Payload | undefined = undefined;
   export let fallback: string = '';
@@ -18,19 +11,6 @@
 
   let decodedValue = '';
 
-  $: endpoint = getCodecEndpoint($page.data.settings);
-  $: passAccessToken = getCodecPassAccessToken($page.data.settings);
-  $: includeCredentials = getCodecIncludeCredentials($page.data.settings);
-  $: settings = {
-    ...$page.data.settings,
-    codec: {
-      ...$page.data.settings?.codec,
-      endpoint,
-      passAccessToken,
-      includeCredentials,
-    },
-  };
-
   const setPrefix = (metadata: string) => {
     if (prefix) {
       metadata = `${prefix} • ${metadata}`;
@@ -44,10 +24,7 @@
     if (!_value) return fallback;
     if (decodedValue) return decodedValue;
 
-    const metadata = await decodeSingleReadablePayloadWithCodec(
-      _value,
-      settings,
-    );
+    const metadata = await decodeUserMetadata(_value);
 
     if (typeof metadata === 'string') {
       decodedValue = setPrefix(metadata);

src/lib/components/event/payload-decoder.svelte

@@ -1,20 +1,13 @@
 <script lang="ts">
   import { onMount, type Snippet } from 'svelte';
 
-  import { page } from '$app/stores';
-
   import type { Memo } from '$lib/types';
   import type { EventAttribute, WorkflowEvent } from '$lib/types/events';
   import {
-    cloneAllPotentialPayloadsWithCodec,
-    decodePayloadAttributes,
+    decodeEventAttributes,
+    parsePayloadAttributes,
     type PotentiallyDecodable,
   } from '$lib/utilities/decode-payload';
-  import {
-    getCodecEndpoint,
-    getCodecIncludeCredentials,
-    getCodecPassAccessToken,
-  } from '$lib/utilities/get-codec';
   import { stringifyWithBigInt } from '$lib/utilities/parse-with-big-int';
 
   interface Props {
@@ -36,22 +29,9 @@
   const decodePayloads = async (
     _value: PotentiallyDecodable | EventAttribute | WorkflowEvent | Memo,
   ) => {
-    const settings = {
-      ...$page.data.settings,
-      codec: {
-        ...$page.data.settings?.codec,
-        endpoint: getCodecEndpoint($page.data.settings),
-        passAccessToken: getCodecPassAccessToken($page.data.settings),
-        includeCredentials: getCodecIncludeCredentials($page.data.settings),
-      },
-    };
     try {
-      const convertedAttributes = await cloneAllPotentialPayloadsWithCodec(
-        _value,
-        $page.params.namespace,
-        settings,
-      );
-      const decodedAttributes = decodePayloadAttributes(
+      const convertedAttributes = await decodeEventAttributes(_value);
+      const decodedAttributes = parsePayloadAttributes(
         convertedAttributes,
       ) as object;
       const keyExists = key && decodedAttributes?.[key];

src/lib/components/lines-and-dots/svg/timeline-graph-row.svelte

@@ -64,10 +64,7 @@
     const localActivityEvent = getLocalActivityMarkerEvent(group);
     if (localActivityEvent) {
       try {
-        decodedLocalActivity = await decodeLocalActivity(localActivityEvent, {
-          namespace: page.params.namespace,
-          settings: page.data.settings,
-        });
+        decodedLocalActivity = await decodeLocalActivity(localActivityEvent);
 
         if (decodedLocalActivity) {
           group.decodedLocalActivity = decodedLocalActivity;

src/lib/components/schedule/schedule-form/schema.ts

@@ -3,7 +3,7 @@ import { z } from 'zod/v3';
 import { searchAttributesSchema } from '$lib/stores/search-attributes';
 import type { FullSchedule } from '$lib/types/schedule';
 import type { SearchAttributes } from '$lib/types/workflows';
-import { decodePayloadAttributes } from '$lib/utilities/decode-payload';
+import { parsePayloadAttributes } from '$lib/utilities/decode-payload';
 
 import type { SearchAttribute } from '$types';
 
@@ -61,8 +61,8 @@ export const getDefaultValues = (params: {
     scheduleId,
   } = params;
 
-  const decodedSearchAttributes = decodePayloadAttributes({ searchAttributes });
-  const decodedWorkflowSearchAttributes = decodePayloadAttributes({
+  const decodedSearchAttributes = parsePayloadAttributes({ searchAttributes });
+  const decodedWorkflowSearchAttributes = parsePayloadAttributes({
     searchAttributes: schedule?.action?.startWorkflow?.searchAttributes ?? {},
   });
 

src/lib/components/schedule/schedule-search-attributes.svelte

@@ -2,13 +2,13 @@
   import Accordion from '$lib/holocene/accordion/accordion.svelte';
   import { translate } from '$lib/i18n/translate';
   import type { SearchAttribute } from '$lib/types';
-  import { decodePayloadAttributes } from '$lib/utilities/decode-payload';
+  import { parsePayloadAttributes } from '$lib/utilities/decode-payload';
   import { payloadToString } from '$lib/utilities/payload-to-string';
   import { pluralize } from '$lib/utilities/pluralize';
 
   export let searchAttributes: SearchAttribute;
 
-  $: decodedSearchAttributes = decodePayloadAttributes({ searchAttributes });
+  $: decodedSearchAttributes = parsePayloadAttributes({ searchAttributes });
   $: indexedFields =
     decodedSearchAttributes?.searchAttributes.indexedFields ?? {};
   $: searchAttributeCount = Object.keys(indexedFields).length;

src/lib/components/schedule/schedules-table-row.svelte

@@ -6,7 +6,7 @@
   import Link from '$lib/holocene/link.svelte';
   import { translate } from '$lib/i18n/translate';
   import type { ConfigurableTableHeader } from '$lib/stores/configurable-table-columns';
-  import { decodePayloadAttributes } from '$lib/utilities/decode-payload';
+  import { parsePayloadAttributes } from '$lib/utilities/decode-payload';
   import { routeForSchedule, routeForWorkflow } from '$lib/utilities/route-for';
 
   import ScheduleFrequency from './schedule-frequency.svelte';
@@ -25,7 +25,7 @@
   const spec = $derived(schedule?.info?.spec);
   const searchAttributes = $derived(schedule?.searchAttributes ?? {});
   const decodedAttributes = $derived(
-    decodePayloadAttributes({ searchAttributes }),
+    parsePayloadAttributes({ searchAttributes }),
   );
 
   const sortRecentActions = (recentActions: ScheduleActionResult[]) => {

src/lib/components/workflow/download-event-history-modal.svelte

@@ -1,6 +1,4 @@
 <script lang="ts">
-  import { page } from '$app/stores';
-
   import Modal from '$lib/holocene/modal.svelte';
   import RadioGroup from '$lib/holocene/radio-input/radio-group.svelte';
   import RadioInput from '$lib/holocene/radio-input/radio-input.svelte';
@@ -21,7 +19,6 @@
       namespace,
       workflowId,
       runId,
-      settings: $page.data.settings,
       decodeSetting: $downloadEventHistorySetting,
     });
   };

src/lib/components/workflow/metadata/workflow-current-details.svelte

@@ -23,17 +23,13 @@
     if (!workflow || loading) return;
     loading = true;
     try {
-      const { settings } = page.data;
-      const metadata = await getWorkflowMetadata(
-        {
-          namespace,
-          workflow: {
-            id: workflow.id,
-            runId: workflow.runId,
-          },
+      const metadata = await getWorkflowMetadata({
+        namespace,
+        workflow: {
+          id: workflow.id,
+          runId: workflow.runId,
         },
-        settings,
-      );
+      });
       $workflowRun.metadata = metadata;
       lastFetched = new Date();
     } catch (error) {

src/lib/layouts/workflow-run-layout.svelte

@@ -32,7 +32,7 @@
   import type { NetworkError } from '$lib/types/global';
   import type { WorkflowExecution } from '$lib/types/workflows';
   import { copyToClipboard } from '$lib/utilities/copy-to-clipboard';
-  import { decodeSingleReadablePayloadWithCodec } from '$lib/utilities/decode-payload';
+  import { decodeUserMetadata } from '$lib/utilities/decode-payload';
   import { stringifyWithBigInt } from '$lib/utilities/parse-with-big-int';
 
   $: ({ namespace, workflow: workflowId, run: runId } = $page.params);
@@ -49,21 +49,17 @@
     copy(e, stringifyWithBigInt(fullJson));
   };
 
-  const decodeUserMetadata = async (workflow: WorkflowExecution) => {
+  const decodeWorkflowUserMetadata = async (workflow: WorkflowExecution) => {
     const userMetadata = { summary: '', details: '' };
     try {
       if (workflow?.summary) {
-        const decodedSummary = await decodeSingleReadablePayloadWithCodec(
-          workflow.summary,
-        );
+        const decodedSummary = await decodeUserMetadata(workflow.summary);
         if (typeof decodedSummary === 'string') {
           userMetadata.summary = decodedSummary;
         }
       }
       if (workflow?.details) {
-        const decodedDetails = await decodeSingleReadablePayloadWithCodec(
-          workflow.details,
-        );
+        const decodedDetails = await decodeUserMetadata(workflow.details);
         if (typeof decodedDetails === 'string') {
           userMetadata.details = decodedDetails;
         }
@@ -96,7 +92,7 @@
       return;
     }
 
-    await decodeUserMetadata(workflow);
+    await decodeWorkflowUserMetadata(workflow);
 
     const { taskQueue } = workflow;
     const workers = await getPollers({ queue: taskQueue, namespace });
@@ -114,7 +110,6 @@
             runId,
           },
         },
-        settings,
         workflowRunController.signal,
       ).then((metadata) => {
         $workflowRun.metadata = metadata;