More checks on the namespace workflow columns (#1474)

* More checks on the namespace

* Add checks in the workflowTableColumns store

* Remove unnecessary ?. check

Author: Alex-Tideman

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/ui",
-  "version": "2.16.8",
+  "version": "2.16.9",
   "engines": {
     "pnpm": ">=8.6.0",
     "node": ">=18.15.0"

src/lib/components/workflow/workflows-summary-configurable-table/orderable-list.svelte

@@ -14,7 +14,7 @@
 
   export let namespace: string;
 
-  $: columnsInUse = $workflowTableColumns[namespace];
+  $: columnsInUse = $workflowTableColumns?.[namespace] ?? [];
   $: availableSystemColumns = availableSystemSearchAttributeColumns(namespace);
   $: availableCustomColumns = availableCustomSearchAttributeColumns(namespace);
 </script>

src/lib/stores/workflow-table-columns.ts

@@ -5,7 +5,6 @@ import { persistStore } from './persist-store';
 import { customSearchAttributes } from './search-attributes';
 
 export const MAX_PINNED_COLUMNS = 2;
-
 export const WorkflowHeaderLabels = [
   'Status',
   'Workflow ID',
@@ -107,14 +106,17 @@ export const workflowTableColumns: Readable<State> = derived(
   [namespaces, persistedWorkflowTableColumns],
   ([$namespaces, $persistedWorkflowTableColumns]) => {
     const state: State = {};
-    return $namespaces.reduce(
-      (namespaceToColumnsMap, { namespaceInfo: { name } }) => {
-        return {
-          ...namespaceToColumnsMap,
-          [name]: $persistedWorkflowTableColumns[name] ?? getDefaultColumns(),
-        };
-      },
-      state,
+    return (
+      $namespaces?.reduce(
+        (namespaceToColumnsMap, { namespaceInfo: { name } }) => {
+          return {
+            ...namespaceToColumnsMap,
+            [name]:
+              $persistedWorkflowTableColumns?.[name] ?? getDefaultColumns(),
+          };
+        },
+        state,
+      ) ?? {}
     );
   },
 );
@@ -129,7 +131,7 @@ export const availableSystemSearchAttributeColumns: (
   derived(workflowTableColumns, ($workflowTableColumns) =>
     [...DEFAULT_COLUMNS, ...DEFAULT_AVAILABLE_COLUMNS].filter(
       (header) =>
-        !$workflowTableColumns[namespace].some(
+        !$workflowTableColumns[namespace]?.some(
           (column) => column.label === header.label,
         ),
     ),
@@ -144,7 +146,7 @@ export const availableCustomSearchAttributeColumns: (
       Object.keys($customSearchAttributes)
         .filter(
           (searchAttribute) =>
-            !$workflowTableColumns[namespace].some(
+            !$workflowTableColumns[namespace]?.some(
               (column) => column.label === searchAttribute,
             ),
         )
@@ -158,7 +160,7 @@ const reducer = (action: Action, state: State): State => {
   switch (action.type) {
     case 'WORKFLOW_COLUMN.ADD': {
       const { label, namespace } = action.payload;
-      const columns = state[namespace] ?? DEFAULT_COLUMNS;
+      const columns = state?.[namespace] ?? DEFAULT_COLUMNS;
 
       return {
         ...state,
@@ -167,7 +169,7 @@ const reducer = (action: Action, state: State): State => {
     }
     case 'WORKFLOW_COLUMN.REMOVE': {
       const { label: labelToRemove, namespace } = action.payload;
-      const columns = state[namespace] ?? DEFAULT_COLUMNS;
+      const columns = state?.[namespace] ?? DEFAULT_COLUMNS;
 
       return {
         ...state,
@@ -176,7 +178,7 @@ const reducer = (action: Action, state: State): State => {
     }
     case 'WORKFLOW_COLUMN.PIN': {
       const { label: labelToPin, namespace } = action.payload;
-      const columns = state[namespace] ?? DEFAULT_COLUMNS;
+      const columns = state?.[namespace] ?? DEFAULT_COLUMNS;
       const index = columns.findIndex(({ label }) => label === labelToPin);
 
       const isPinned = columns[index].pinned;
@@ -205,7 +207,7 @@ const reducer = (action: Action, state: State): State => {
     }
     case 'WORKFLOW_COLUMN.MOVE': {
       const { from, to, namespace } = action.payload;
-      const columns = state[namespace] ?? DEFAULT_COLUMNS;
+      const columns = state?.[namespace] ?? DEFAULT_COLUMNS;
       const isPinned = columns[from].pinned;
 
       let lastPinned = 0;