Skip to content

Commit 5076d5f

Browse files
authored
Remove events/type route and use first event (#2633)
1 parent f85d0b8 commit 5076d5f

File tree

3 files changed

+14
-53
lines changed

3 files changed

+14
-53
lines changed

src/lib/components/event/event-link.svelte

+14-4
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import { translate } from '$lib/i18n/translate';
44
import type { EventLink } from '$lib/types/events';
55
import {
6+
routeForEventHistory,
67
routeForEventHistoryEvent,
7-
routeForEventHistoryEventType,
88
} from '$lib/utilities/route-for';
99
1010
export let link: EventLink;
@@ -21,14 +21,24 @@
2121
eventId: link.workflowEvent.eventRef.eventId,
2222
});
2323
value = `${link.workflowEvent.workflowId}/history/events/${link.workflowEvent.eventRef.eventId}`;
24+
} else if (
25+
link.workflowEvent?.eventRef?.eventType ===
26+
'EVENT_TYPE_WORKFLOW_EXECUTION_STARTED'
27+
) {
28+
href = routeForEventHistoryEvent({
29+
namespace: link.workflowEvent.namespace,
30+
workflow: link.workflowEvent.workflowId,
31+
run: link.workflowEvent.runId,
32+
eventId: '1',
33+
});
34+
value = `${link.workflowEvent.workflowId}/history/events/1`;
2435
} else {
25-
href = routeForEventHistoryEventType({
36+
href = routeForEventHistory({
2637
namespace: link.workflowEvent.namespace,
2738
workflow: link.workflowEvent.workflowId,
2839
run: link.workflowEvent.runId,
29-
eventType: link.workflowEvent.eventRef.eventType,
3040
});
31-
value = `${link.workflowEvent.workflowId}/history/events/type/${link.workflowEvent.eventRef.eventType}`;
41+
value = `${link.workflowEvent.workflowId}/history`;
3242
}
3343
}
3444
</script>

src/lib/utilities/route-for.ts

-7
Original file line numberDiff line numberDiff line change
@@ -183,13 +183,6 @@ export const routeForEventHistoryEvent = ({
183183
return `${routeForWorkflow(parameters)}/history/events/${eventId}`;
184184
};
185185

186-
export const routeForEventHistoryEventType = ({
187-
eventType,
188-
...parameters
189-
}: EventParameters): string => {
190-
return `${routeForWorkflow(parameters)}/history/events/type/${eventType}`;
191-
};
192-
193186
export const routeForWorkers = (parameters: WorkflowParameters): string => {
194187
return `${routeForWorkflow(parameters)}/workers`;
195188
};

src/routes/(app)/namespaces/[namespace]/workflows/[workflow]/[run]/history/events/type/[type]/+page.ts

-42
This file was deleted.

0 commit comments

Comments
 (0)