Skip to content

Commit 8c79931

Browse files
authored
feat(DT-3887): remove Dispatch Rate Epsilon from compute scaling UI (#3334)
Removes the scaleUpDispatchRateEpsilon input field from the serverless worker compute scaling configuration UI per feedback from Muneeb Ahmad. This is a UI-only removal. The service layer API mapping remains intact so the backend contract is unchanged and existing deployments are not affected. Files changed: - compute-fields.svelte: remove Input block + Props entries + destructure - shared.ts: remove field from Zod scalingFields schema - serverless-worker-create-form.svelte: remove initial data + bind prop - create-version-form.svelte: remove initial data + bind prop - edit-version-form.svelte: remove Props interface + initial data + bind - serverless-worker-create.svelte: remove from buildLambdaComputeConfig - worker-deployment-version-create.svelte: same - worker-deployment-version-edit.svelte: same (2 references) - version-compute-details.svelte: remove read-only display row - en/workers.ts: remove label and hint i18n keys - en/deployments.ts: remove dispatch-rate-epsilon i18n key
1 parent 0726c65 commit 8c79931

11 files changed

Lines changed: 0 additions & 46 deletions

src/lib/components/deployments/version-compute-details.svelte

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
scalerParams.scaleUpCooloffMs !== undefined ||
1818
scalerParams.scaleUpBacklogThreshold !== undefined ||
1919
scalerParams.maxWorkerLifetimeMs !== undefined ||
20-
scalerParams.scaleUpDispatchRateEpsilon !== undefined ||
2120
scalerParams.metricsPollIntervalMs !== undefined,
2221
);
2322
</script>
@@ -90,16 +89,6 @@
9089
>
9190
</div>
9291
{/if}
93-
{#if scalerParams.scaleUpDispatchRateEpsilon !== undefined}
94-
<div class="flex gap-1">
95-
<span class="font-medium text-secondary"
96-
>{translate('deployments.dispatch-rate-epsilon')}</span
97-
>
98-
<span class="text-primary"
99-
>{scalerParams.scaleUpDispatchRateEpsilon}</span
100-
>
101-
</div>
102-
{/if}
10392
{#if scalerParams.metricsPollIntervalMs !== undefined}
10493
<div class="flex gap-1">
10594
<span class="font-medium text-secondary"

src/lib/components/workers/serverless-worker-form/compute-fields.svelte

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
scaleUpCooloffMs?: number;
1111
scaleUpBacklogThreshold?: number;
1212
maxWorkerLifetimeMs?: number;
13-
scaleUpDispatchRateEpsilon?: number;
1413
metricsPollIntervalMs?: number;
1514
errors?: {
1615
lambdaArn?: string[];
@@ -19,7 +18,6 @@
1918
scaleUpCooloffMs?: string[];
2019
scaleUpBacklogThreshold?: string[];
2120
maxWorkerLifetimeMs?: string[];
22-
scaleUpDispatchRateEpsilon?: string[];
2321
metricsPollIntervalMs?: string[];
2422
};
2523
}
@@ -31,7 +29,6 @@
3129
scaleUpCooloffMs = $bindable(),
3230
scaleUpBacklogThreshold = $bindable(),
3331
maxWorkerLifetimeMs = $bindable(),
34-
scaleUpDispatchRateEpsilon = $bindable(),
3532
metricsPollIntervalMs = $bindable(),
3633
errors = {},
3734
}: Props = $props();
@@ -135,22 +132,6 @@
135132
error={!!errors.maxWorkerLifetimeMs?.[0]}
136133
placeholder="600000"
137134
/>
138-
<Input
139-
value={scaleUpDispatchRateEpsilon !== undefined
140-
? String(scaleUpDispatchRateEpsilon)
141-
: ''}
142-
onchange={(e) => {
143-
const val = (e.target as HTMLInputElement).value;
144-
scaleUpDispatchRateEpsilon = val === '' ? undefined : Number(val);
145-
}}
146-
id="scaleUpDispatchRateEpsilon"
147-
name="scaleUpDispatchRateEpsilon"
148-
label={translate('workers.scale-up-dispatch-rate-epsilon-label')}
149-
hintText={errors.scaleUpDispatchRateEpsilon?.[0] ||
150-
translate('workers.scale-up-dispatch-rate-epsilon-hint')}
151-
error={!!errors.scaleUpDispatchRateEpsilon?.[0]}
152-
placeholder="0"
153-
/>
154135
<Input
155136
value={metricsPollIntervalMs !== undefined
156137
? String(metricsPollIntervalMs)

src/lib/components/workers/serverless-worker-form/create-version-form.svelte

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
scaleUpCooloffMs: undefined as number | undefined,
3333
scaleUpBacklogThreshold: undefined as number | undefined,
3434
maxWorkerLifetimeMs: undefined as number | undefined,
35-
scaleUpDispatchRateEpsilon: undefined as number | undefined,
3635
metricsPollIntervalMs: undefined as number | undefined,
3736
},
3837
{
@@ -92,7 +91,6 @@
9291
bind:scaleUpCooloffMs={$form.scaleUpCooloffMs}
9392
bind:scaleUpBacklogThreshold={$form.scaleUpBacklogThreshold}
9493
bind:maxWorkerLifetimeMs={$form.maxWorkerLifetimeMs}
95-
bind:scaleUpDispatchRateEpsilon={$form.scaleUpDispatchRateEpsilon}
9694
bind:metricsPollIntervalMs={$form.metricsPollIntervalMs}
9795
errors={$errors}
9896
/>

src/lib/components/workers/serverless-worker-form/edit-version-form.svelte

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
scaleUpCooloffMs?: number;
2121
scaleUpBacklogThreshold?: number;
2222
maxWorkerLifetimeMs?: number;
23-
scaleUpDispatchRateEpsilon?: number;
2423
metricsPollIntervalMs?: number;
2524
};
2625
onSubmit: (data: EditVersionFormData) => Promise<void>;
@@ -41,7 +40,6 @@
4140
scaleUpCooloffMs: initialData.scaleUpCooloffMs,
4241
scaleUpBacklogThreshold: initialData.scaleUpBacklogThreshold,
4342
maxWorkerLifetimeMs: initialData.maxWorkerLifetimeMs,
44-
scaleUpDispatchRateEpsilon: initialData.scaleUpDispatchRateEpsilon,
4543
metricsPollIntervalMs: initialData.metricsPollIntervalMs,
4644
},
4745
{
@@ -81,7 +79,6 @@
8179
bind:scaleUpCooloffMs={$form.scaleUpCooloffMs}
8280
bind:scaleUpBacklogThreshold={$form.scaleUpBacklogThreshold}
8381
bind:maxWorkerLifetimeMs={$form.maxWorkerLifetimeMs}
84-
bind:scaleUpDispatchRateEpsilon={$form.scaleUpDispatchRateEpsilon}
8582
bind:metricsPollIntervalMs={$form.metricsPollIntervalMs}
8683
errors={$errors}
8784
/>

src/lib/components/workers/serverless-worker-form/serverless-worker-create-form.svelte

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
scaleUpCooloffMs: undefined as number | undefined,
5252
scaleUpBacklogThreshold: undefined as number | undefined,
5353
maxWorkerLifetimeMs: undefined as number | undefined,
54-
scaleUpDispatchRateEpsilon: undefined as number | undefined,
5554
metricsPollIntervalMs: undefined as number | undefined,
5655
};
5756
@@ -134,7 +133,6 @@
134133
bind:scaleUpCooloffMs={$form.scaleUpCooloffMs}
135134
bind:scaleUpBacklogThreshold={$form.scaleUpBacklogThreshold}
136135
bind:maxWorkerLifetimeMs={$form.maxWorkerLifetimeMs}
137-
bind:scaleUpDispatchRateEpsilon={$form.scaleUpDispatchRateEpsilon}
138136
bind:metricsPollIntervalMs={$form.metricsPollIntervalMs}
139137
errors={$errors}
140138
/>

src/lib/components/workers/serverless-worker-form/shared.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ const scalingFields = {
1919
scaleUpCooloffMs: z.number().int().min(0).optional(),
2020
scaleUpBacklogThreshold: z.number().int().min(0).optional(),
2121
maxWorkerLifetimeMs: z.number().int().min(0).optional(),
22-
scaleUpDispatchRateEpsilon: z.number().min(0).optional(),
2322
metricsPollIntervalMs: z.number().int().min(10000).optional(),
2423
};
2524

src/lib/i18n/locales/en/deployments.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ export const Strings = {
7171
'scale-up-cooloff': 'Scale-up Cooloff',
7272
'backlog-threshold': 'Backlog Threshold',
7373
'max-worker-lifetime': 'Max Worker Lifetime',
74-
'dispatch-rate-epsilon': 'Dispatch Rate Epsilon',
7574
'metrics-poll-interval': 'Metrics Poll Interval',
7675
'filter-deployments': 'Filter deployments',
7776
'drainage-status': 'Drainage Status',

src/lib/i18n/locales/en/workers.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -281,9 +281,6 @@ export const Strings = {
281281
'max-worker-lifetime-ms-label': 'Max Worker Lifetime (ms)',
282282
'max-worker-lifetime-ms-hint':
283283
'Refresh a worker after this many ms when there is backlog. 0 = disabled. Default: 600000.',
284-
'scale-up-dispatch-rate-epsilon-label': 'Dispatch Rate Epsilon',
285-
'scale-up-dispatch-rate-epsilon-hint':
286-
'Suppress scale-up when processing rate change is within this value. 0 = disabled.',
287284
'metrics-poll-interval-ms-label': 'Metrics Poll Interval (ms)',
288285
'metrics-poll-interval-ms-hint':
289286
'Interval between metrics polls. Min: 10000. Default: 60000.',

src/lib/pages/serverless-worker-create.svelte

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@
8080
scaleUpCooloffMs: data.scaleUpCooloffMs,
8181
scaleUpBacklogThreshold: data.scaleUpBacklogThreshold,
8282
maxWorkerLifetimeMs: data.maxWorkerLifetimeMs,
83-
scaleUpDispatchRateEpsilon: data.scaleUpDispatchRateEpsilon,
8483
metricsPollIntervalMs: data.metricsPollIntervalMs,
8584
},
8685
);

src/lib/pages/worker-deployment-version-create.svelte

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
scaleUpCooloffMs: data.scaleUpCooloffMs,
4646
scaleUpBacklogThreshold: data.scaleUpBacklogThreshold,
4747
maxWorkerLifetimeMs: data.maxWorkerLifetimeMs,
48-
scaleUpDispatchRateEpsilon: data.scaleUpDispatchRateEpsilon,
4948
metricsPollIntervalMs: data.metricsPollIntervalMs,
5049
},
5150
);

0 commit comments

Comments
 (0)