Re-wire auth to use a provider pattern. Lots of tests remove cloud references (#3230)

* Allow accessToken to throw to allow it to stop execution and prevent weirdness in control flow.

* Potential fix for cookie weirdness consolidate to a provider so we have single points of access

* Lets test some auth paths

* Add jwtPass and credentials tests

* Update to use a provider pattern instead of checking for globalThis. Re-wire with-access-token to use pre/post hooks so code paths can be determined by the caller. Lots of tests

* Give retryContext better types other than Record<string,string>

* move to initCore stuff and namespaceSearch and dataEncoderEndpoint options as well as a few others

Author: GiantRobots

src/hooks.client.ts

@@ -1,3 +1,12 @@
+import { getAuthUser } from '$lib/stores/auth-user';
+import { consumeAuthCookies } from '$lib/utilities/auth-user-cookie';
+import { initCoreProvider } from '$lib/utilities/core-provider';
+import {
+  ossGetDataEncoderEndpoint,
+  ossPostResponse,
+  ossPreRequest,
+} from '$lib/utilities/oss-provider.svelte';
+
 if (typeof crypto !== 'undefined' && !crypto.randomUUID) {
   crypto.randomUUID = function randomUUID() {
     return '10000000-1000-4000-8000-100000000000'.replace(/[018]/g, (c) => {
@@ -9,3 +18,15 @@ if (typeof crypto !== 'undefined' && !crypto.randomUUID) {
     }) as `${string}-${string}-${string}-${string}-${string}`;
   };
 }
+
+consumeAuthCookies();
+
+initCoreProvider({
+  getAccessToken: async () => getAuthUser().accessToken ?? '',
+  getIdToken: async () => getAuthUser().idToken,
+  api: {
+    preRequest: ossPreRequest,
+    postResponse: ossPostResponse,
+  },
+  getDataEncoderEndpoint: ossGetDataEncoderEndpoint,
+});

src/lib/components/event/event-summary-row.svelte

@@ -19,7 +19,6 @@
     eventOrGroupIsTerminated,
   } from '$lib/models/event-groups/get-event-in-group';
   import { isCloud } from '$lib/stores/advanced-visibility';
-  import { authUser } from '$lib/stores/auth-user';
   import type { IterableEvent, WorkflowEvent } from '$lib/types/events';
   import { decodeLocalActivity } from '$lib/utilities/decode-local-activity';
   import { spaceBetweenCapitalLetters } from '$lib/utilities/format-camel-case';
@@ -187,7 +186,6 @@
       primaryLocalAttribute = await decodeLocalActivity(event, {
         namespace: page.params.namespace,
         settings: page.data.settings,
-        accessToken: $authUser.accessToken,
       });
     } else if (
       isEventGroup(event) &&
@@ -196,7 +194,6 @@
       primaryLocalAttribute = await decodeLocalActivity(event.initialEvent, {
         namespace: page.params.namespace,
         settings: page.data.settings,
-        accessToken: $authUser.accessToken,
       });
     }
   });

src/lib/components/event/payload-decoder.svelte

@@ -3,7 +3,6 @@
 
   import { page } from '$app/stores';
 
-  import { authUser } from '$lib/stores/auth-user';
   import type { Memo } from '$lib/types';
   import type { EventAttribute, WorkflowEvent } from '$lib/types/events';
   import {
@@ -51,7 +50,6 @@
         _value,
         $page.params.namespace,
         settings,
-        $authUser.accessToken,
       );
       const decodedAttributes = decodePayloadAttributes(
         convertedAttributes,

src/lib/components/lines-and-dots/svg/timeline-graph-row.svelte

@@ -9,7 +9,6 @@
   import { translate } from '$lib/i18n/translate';
   import type { EventGroup } from '$lib/models/event-groups/event-groups';
   import { setActiveGroup } from '$lib/stores/active-events';
-  import { authUser } from '$lib/stores/auth-user';
   import {
     decodeLocalActivity,
     getLocalActivityMarkerEvent,
@@ -68,7 +67,6 @@
         decodedLocalActivity = await decodeLocalActivity(localActivityEvent, {
           namespace: page.params.namespace,
           settings: page.data.settings,
-          accessToken: $authUser.accessToken,
         });
 
         if (decodedLocalActivity) {

src/lib/components/workflow/metadata/workflow-current-details.svelte

@@ -9,7 +9,6 @@
   import Markdown from '$lib/holocene/markdown-editor/preview.svelte';
   import { translate } from '$lib/i18n/translate';
   import { getWorkflowMetadata } from '$lib/services/query-service';
-  import { authUser } from '$lib/stores/auth-user';
   import { workflowRun } from '$lib/stores/workflow-run';
 
   const { namespace } = $derived(page.params);
@@ -34,7 +33,6 @@
           },
         },
         settings,
-        $authUser?.accessToken ?? '',
       );
       $workflowRun.metadata = metadata;
       lastFetched = new Date();

src/lib/layouts/workflow-run-layout.svelte

@@ -16,7 +16,6 @@
   import { getPollers } from '$lib/services/pollers-service';
   import { getWorkflowMetadata } from '$lib/services/query-service';
   import { fetchWorkflow } from '$lib/services/workflow-service';
-  import { authUser } from '$lib/stores/auth-user';
   import { resetLastDataEncoderSuccess } from '$lib/stores/data-encoder-config';
   import { eventFilterSort, type EventSortOrder } from '$lib/stores/event-view';
   import {
@@ -117,7 +116,6 @@
           },
         },
         settings,
-        $authUser?.accessToken,
         workflowRunController.signal,
       ).then((metadata) => {
         $workflowRun.metadata = metadata;

src/lib/models/event-history/get-event-attributes.test.ts

@@ -83,7 +83,6 @@ const historyEvent = {
 
 const namespace = 'unit-tests';
 const settings = settingsFixture as unknown as Settings;
-const accessToken = 'xxx.yyy.zzz';
 
 describe('getEventAttributes', () => {
   beforeEach(() => {
@@ -110,7 +109,6 @@ describe('getEventAttributes', () => {
       historyEvent,
       namespace,
       settings,
-      accessToken,
     });
     expect(event.type).toBe(eventType);
   });
@@ -123,7 +121,6 @@ describe('getEventAttributes', () => {
         historyEvent,
         namespace,
         settings,
-        accessToken,
       },
       {
         convertWithCodec,
@@ -141,7 +138,6 @@ describe('getEventAttributes', () => {
         historyEvent,
         namespace,
         settings: { ...settings, codec: { endpoint: 'https://localhost' } },
-        accessToken,
       },
       {
         convertWithCodec,
@@ -159,7 +155,6 @@ describe('getEventAttributes', () => {
         historyEvent,
         namespace,
         settings,
-        accessToken,
       },
       {
         convertWithCodec,

src/lib/models/event-history/index.ts

@@ -27,7 +27,7 @@ import { getEventClassification } from './get-event-classification';
 import { simplifyAttributes } from './simplify-attributes';
 
 export async function getEventAttributes(
-  { historyEvent, namespace, settings, accessToken }: EventWithMetadata,
+  { historyEvent, namespace, settings }: EventWithMetadata,
   {
     convertWithCodec = convertPayloadToJsonWithCodec,
     decodeAttributes = decodePayloadAttributes,
@@ -38,7 +38,6 @@ export async function getEventAttributes(
     attributes,
     namespace,
     settings,
-    accessToken,
   });
 
   const decodedAttributes = decodeAttributes(convertedAttributes) as object;

src/lib/models/event-history/to-event-history.test.ts

@@ -83,7 +83,6 @@ const historyEvent = {
 
 const namespace = 'unit-tests';
 const settings = settingsFixture as unknown as Settings;
-const accessToken = 'token-test';
 
 describe('getEventAttributes', () => {
   beforeEach(() => {
@@ -110,7 +109,6 @@ describe('getEventAttributes', () => {
       historyEvent,
       namespace,
       settings,
-      accessToken,
     });
     expect(event.type).toBe(eventType);
   });
@@ -123,7 +121,6 @@ describe('getEventAttributes', () => {
         historyEvent,
         namespace,
         settings,
-        accessToken,
       },
       {
         convertWithCodec,
@@ -141,7 +138,6 @@ describe('getEventAttributes', () => {
         historyEvent,
         namespace,
         settings: { ...settings, codec: { endpoint: 'https://localhost' } },
-        accessToken,
       },
       {
         convertWithCodec,
@@ -159,7 +155,6 @@ describe('getEventAttributes', () => {
         historyEvent,
         namespace,
         settings,
-        accessToken,
       },
       {
         convertWithCodec,

src/lib/models/pending-activities/index.ts

@@ -2,7 +2,6 @@ import { get } from 'svelte/store';
 
 import { page } from '$app/stores';
 
-import { authUser } from '$lib/stores/auth-user';
 import type {
   PendingActivity,
   PendingActivityWithMetadata,
@@ -16,7 +15,7 @@ import {
 } from '$lib/utilities/decode-payload';
 
 export async function getActivityAttributes(
-  { activity, namespace, settings, accessToken }: PendingActivityWithMetadata,
+  { activity, namespace, settings }: PendingActivityWithMetadata,
   {
     convertWithCodec = convertPayloadToJsonWithCodec,
     decodeAttributes = decodePayloadAttributes,
@@ -26,7 +25,6 @@ export async function getActivityAttributes(
     attributes: activity,
     namespace,
     settings,
-    accessToken,
   });
 
   const decodedAttributes = decodeAttributes(
@@ -39,13 +37,11 @@ const decodePendingActivity = async ({
   activity,
   namespace,
   settings,
-  accessToken,
 }: PendingActivityWithMetadata): Promise<PendingActivity> => {
   const decodedActivity = await getActivityAttributes({
     activity,
     namespace,
     settings,
-    accessToken,
   });
   return decodedActivity;
 };
@@ -54,7 +50,6 @@ export const toDecodedPendingActivities = async (
   workflow: WorkflowExecution,
   namespace: string = get(page).params.namespace,
   settings: Settings = get(page).data.settings,
-  accessToken: string = get(authUser).accessToken,
 ) => {
   const pendingActivities = workflow?.pendingActivities ?? [];
   const decodedActivities: PendingActivity[] = [];
@@ -63,7 +58,6 @@ export const toDecodedPendingActivities = async (
       activity,
       namespace,
       settings,
-      accessToken,
     });
     decodedActivities.push(decodedActivity);
   }