Commit 93e4d9a
authored
DT-2971-change-codeblock-expand-to-maximize (#2771)
* add maximizable component
* add maximizable to code-block component
* add formatJSON utility
* convert code-block to svelte5 and refactor
* tweak code-block stories
* escape to close
* code tweaks from PR
* match existing types for copyable prop
* fix accessibility error: scroller must be focusable
* handle tabbing away from maximized code block
* increase z-index of maximized element
* update codeblock to use onChange callback instead of raising change event
* update payload-input to use codeblock onChange callback
* export prop types for storybook
* rename onChange to onchange and pass string instead of event
* make maximized bindable
* use svelte:window instead of addEventListener
* remove or extract ternaries
* clean up maximize button
* tune types for CodeBlock
* improve formatJson, fix bug rerturning undefined
* make reactive, allow controlled use
* apply to stories
* tidy1 parent 91f471f commit 93e4d9a
10 files changed
Lines changed: 459 additions & 262 deletions
File tree
- src/lib
- components
- holocene
- maximizable
- i18n/locales/en
- utilities
- vendor/codemirror
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | | - | |
| 31 | + | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
54 | | - | |
| 55 | + | |
55 | 56 | | |
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
62 | | - | |
63 | 63 | | |
64 | | - | |
65 | | - | |
66 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
67 | 67 | | |
68 | | - | |
69 | | - | |
70 | | - | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
71 | 73 | | |
72 | | - | |
73 | | - | |
| 74 | + | |
| 75 | + | |
74 | 76 | | |
75 | 77 | | |
76 | | - | |
77 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
78 | 84 | | |
79 | 85 | | |
80 | 86 | | |
| |||
86 | 92 | | |
87 | 93 | | |
88 | 94 | | |
| 95 | + | |
89 | 96 | | |
90 | 97 | | |
91 | | - | |
92 | 98 | | |
93 | 99 | | |
94 | 100 | | |
| |||
131 | 137 | | |
132 | 138 | | |
133 | 139 | | |
134 | | - | |
| 140 | + | |
135 | 141 | | |
136 | | - | |
137 | | - | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
138 | 151 | | |
139 | 152 | | |
140 | 153 | | |
141 | 154 | | |
142 | | - | |
| 155 | + | |
143 | 156 | | |
144 | | - | |
145 | | - | |
| 157 | + | |
| 158 | + | |
146 | 159 | | |
147 | 160 | | |
148 | 161 | | |
| |||
157 | 170 | | |
158 | 171 | | |
159 | 172 | | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
160 | 181 | | |
161 | 182 | | |
162 | 183 | | |
| |||
0 commit comments