Code-freeze 02.26.25 (#2590)

* Support messageType metadata on protobuf encoded Payloads (#2581)

* WIP: add messageType metadata field for json/protobuf payloads. Need to add messageType to schedules/signals

* Set existing messageType and encoding on start workflow if it exists, add to signal

* Add gap

* Url encode deployment name (#2585)

* Don't query metadata if no pollers available (#2586)

* Include Local Activity failure in filter for Pending and Failed Events (#2588)

* Add local activity failure to filter

* Add unit tests, refactor logic, standarized and clean up pending rows

---------

Co-authored-by: Alex Tideman <[email protected]>

Author: laurakwhit

Diff for: src/lib/components/event/event-summary-row.svelte

@@ -109,6 +109,11 @@
     isEventGroup(event) &&
     !event.isPending &&
     event.eventList.find(isActivityTaskStartedEvent)?.attributes?.attempt;
+  $: showSecondaryAttribute =
+    compact &&
+    secondaryAttribute?.key &&
+    secondaryAttribute?.key !== primaryAttribute?.key &&
+    !currentEvent?.userMetadata?.summary;
 </script>
 
 <tr
@@ -234,7 +239,7 @@
         {attributes}
       />
     {/if}
-    {#if compact && secondaryAttribute?.key && !currentEvent?.userMetadata?.summary}
+    {#if showSecondaryAttribute}
       <EventDetailsRow {...secondaryAttribute} {attributes} />
     {/if}
   </td>

Diff for: src/lib/components/event/pending-activity-summary-row.svelte

@@ -42,14 +42,13 @@
   data-testid="pending-activity-summary-row"
   on:click|stopPropagation={onLinkClick}
 >
-  <td>
+  <td class="font-mono">
     <Link data-testid="link" {href}>
       {event.activityId}
     </Link>
   </td>
   <td class="w-full overflow-hidden text-right font-normal xl:text-left">
     <div class="flex w-full items-center gap-2">
-      <!-- <Icon name="activity" /> -->
       <p class="event-name truncate font-semibold md:text-base">
         Pending Activity
       </p>
@@ -88,7 +87,7 @@
 
 <style lang="postcss">
   .row {
-    @apply flex select-none items-center gap-4 px-1 text-sm no-underline;
+    @apply flex select-none items-center gap-4 px-2 text-sm no-underline;
   }
 
   .expanded-cell {

Diff for: src/lib/components/event/pending-nexus-summary-row.svelte

@@ -41,7 +41,7 @@
   data-testid="pending-nexus-summary-row"
   on:click|stopPropagation={onLinkClick}
 >
-  <td class="w-12 text-left">
+  <td class="font-mono">
     <Link data-testid="link" {href}>
       {event.scheduledEventId || ''}
     </Link>
@@ -51,7 +51,6 @@
   >
     <div class="flex">
       <div class="flex w-full items-center gap-2">
-        <Icon name="nexus" />
         <p class="font-semibold md:text-base">Pending Nexus Operation</p>
         {#if event.attempt}
           <div
@@ -85,7 +84,7 @@
 
 <style lang="postcss">
   .row {
-    @apply flex select-none items-center gap-4 px-1 text-sm no-underline;
+    @apply flex select-none items-center gap-4 px-2 text-sm no-underline;
   }
 
   .expanded-cell {

Diff for: src/lib/components/payload-input-with-encoding.svelte

@@ -9,10 +9,10 @@
 <script lang="ts">
   import { type Writable } from 'svelte/store';
 
-  import { onDestroy } from 'svelte';
   import { v4 as uuid } from 'uuid';
 
   import Card from '$lib/holocene/card.svelte';
+  import Input from '$lib/holocene/input/input.svelte';
   import RadioGroup from '$lib/holocene/radio-input/radio-group.svelte';
   import RadioInput from '$lib/holocene/radio-input/radio-input.svelte';
   import { translate } from '$lib/i18n/translate';
@@ -22,36 +22,49 @@
   export let id = uuid();
   export let input: string;
   export let encoding: Writable<PayloadInputEncoding>;
+  export let messageType: string;
   export let error = false;
   export let loading = false;
   export let label = translate('workflows.input');
   export let editing = true;
 
-  const clearValues = () => {
-    $encoding = 'json/plain';
-  };
-
-  onDestroy(clearValues);
+  $: {
+    if ($encoding === 'json/plain' && messageType) {
+      messageType = '';
+    }
+  }
 </script>
 
 <div>
   <h5 class="pb-1 text-sm font-medium">{label}</h5>
   <Card class="flex flex-col gap-2">
     <PayloadInput bind:input bind:loading {error} {id} {editing} />
-    <div class="flex items-end {editing ? 'justify-between' : 'justify-end'}">
+    <div
+      class="flex items-end gap-2 {editing ? 'justify-between' : 'justify-end'}"
+    >
       {#if editing}
-        <RadioGroup
-          description={translate('workflows.encoding')}
-          bind:group={encoding}
-          name="encoding"
-        >
-          <RadioInput id="json/plain" value="json/plain" label="json/plain" />
-          <RadioInput
-            id="json/protobuf"
-            value="json/protobuf"
-            label="json/protobuf"
-          />
-        </RadioGroup>
+        <div class="flex w-full flex-col gap-2">
+          <RadioGroup
+            description={translate('workflows.encoding')}
+            bind:group={encoding}
+            name="encoding"
+          >
+            <RadioInput id="json/plain" value="json/plain" label="json/plain" />
+            <RadioInput
+              id="json/protobuf"
+              value="json/protobuf"
+              label="json/protobuf"
+            />
+          </RadioGroup>
+          {#if $encoding === 'json/protobuf'}
+            <Input
+              label={translate('workflows.message-type')}
+              bind:value={messageType}
+              {error}
+              id="messageType"
+            />
+          {/if}
+        </div>
       {/if}
       <slot name="action" />
     </div>

Diff for: src/lib/components/schedule/schedule-form-view.svelte

@@ -79,6 +79,7 @@
   let input = '';
   let editInput = !schedule;
   let encoding: Writable<PayloadInputEncoding> = writable('json/plain');
+  let messageType = '';
   let daysOfWeek: string[] = [];
   let daysOfMonth: number[] = [];
   let months: string[] = [];
@@ -104,6 +105,7 @@
       taskQueue,
       ...(editInput && { input }),
       encoding: $encoding,
+      messageType,
       hour,
       minute,
       second,
@@ -218,6 +220,7 @@
           bind:input
           bind:editInput
           bind:encoding
+          bind:messageType
           payloads={schedule?.action?.startWorkflow?.input}
           showEditActions={Boolean(schedule)}
         />

Diff for: src/lib/components/schedule/schedule-input-payload.svelte

@@ -16,11 +16,13 @@
   export let input: string;
   export let editInput: boolean;
   export let encoding: Writable<PayloadInputEncoding>;
+  export let messageType: string;
   export let payloads: Payloads;
   export let showEditActions: boolean = false;
 
   let initialInput = '';
   let initialEncoding: PayloadInputEncoding = 'json/plain';
+  let initialMessageType = '';
   let loading = true;
 
   const setInitialInput = (decodedValue: string): void => {
@@ -29,9 +31,17 @@
     const currentEncoding = atob(
       String(payloads?.payloads[0]?.metadata?.encoding ?? 'json/plain'),
     );
+    const currentMessageType = payloads?.payloads[0]?.metadata?.messageType
+      ? atob(String(payloads?.payloads[0]?.metadata?.messageType))
+      : '';
+
     if (isPayloadInputEncodingType(currentEncoding)) {
       $encoding = currentEncoding;
       initialEncoding = $encoding;
+      if (currentEncoding === 'json/protobuf' && currentMessageType) {
+        messageType = currentMessageType;
+        initialMessageType = currentMessageType;
+      }
     }
     loading = false;
   };
@@ -41,6 +51,7 @@
       editInput = false;
       input = initialInput;
       $encoding = initialEncoding;
+      messageType = initialMessageType;
     } else {
       editInput = true;
       input;
@@ -53,6 +64,7 @@
     <PayloadInputWithEncoding
       bind:input
       bind:encoding
+      bind:messageType
       bind:loading
       editing={editInput}
       id="schedule-payload-input"

Diff for: src/lib/components/workflow/client-actions/signal-confirmation-modal.svelte

@@ -30,15 +30,17 @@
   let name = '';
   let customSignal = false;
 
-  let encoding: Writable<PayloadInputEncoding> = writable(defaultEncoding);
   let input = '';
+  let encoding: Writable<PayloadInputEncoding> = writable(defaultEncoding);
+  let messageType = '';
 
   const hideSignalModal = () => {
     open = false;
     name = '';
     input = '';
     customSignal = false;
     $encoding = defaultEncoding;
+    messageType = '';
   };
 
   const signal = async () => {
@@ -50,6 +52,7 @@
         workflow,
         input,
         encoding: $encoding,
+        messageType,
         name,
       });
       $refresh = Date.now();
@@ -114,6 +117,6 @@
         bind:value={name}
       />
     {/if}
-    <PayloadInputWithEncoding bind:input bind:encoding />
+    <PayloadInputWithEncoding bind:input bind:encoding bind:messageType />
   </div>
 </Modal>

Diff for: src/lib/i18n/locales/en/workflows.ts

@@ -268,6 +268,7 @@ export const Strings = {
   'start-workflow-success': 'Workflow started successfully',
   'start-workflow-error': 'Error starting Workflow',
   encoding: 'Encoding',
+  'message-type': 'Message Type',
   'user-metadata': 'User Metadata',
   'markdown-supported': 'Markdown Supported',
   'markdown-description':

Diff for: src/lib/layouts/workflow-run-layout.svelte

@@ -102,7 +102,7 @@
 
     workflowRunController = new AbortController();
 
-    if (workflow.isRunning) {
+    if (workflow.isRunning && workers?.pollers?.length) {
       getWorkflowMetadata(
         {
           namespace,

Diff for: src/lib/pages/schedule-edit.svelte

@@ -37,6 +37,7 @@
       taskQueue,
       input,
       encoding,
+      messageType,
       hour,
       minute,
       second,
@@ -56,6 +57,7 @@
       taskQueue,
       input,
       encoding,
+      messageType,
       searchAttributes,
     };
     const spec: Partial<ScheduleSpecParameters> = {

Diff for: src/lib/pages/schedules-create.svelte

@@ -24,6 +24,7 @@
       taskQueue,
       input,
       encoding,
+      messageType,
       hour,
       minute,
       second,
@@ -44,6 +45,7 @@
       taskQueue,
       input,
       encoding,
+      messageType,
       searchAttributes,
     };
     const spec: Partial<ScheduleSpecParameters> = {

Diff for: src/lib/pages/start-workflow.svelte

@@ -49,6 +49,7 @@
   let summary = '';
   let details = '';
   let encoding: Writable<PayloadInputEncoding> = writable('json/plain');
+  let messageType = '';
   let inputRetrieved = 0;
 
   let initialWorkflowId = '';
@@ -86,6 +87,7 @@
         summary,
         details,
         encoding: $encoding,
+        messageType,
         searchAttributes,
       });
       toaster.push({
@@ -132,6 +134,8 @@
       workflowType: type,
     });
     input = initialValues.input;
+    encoding.set(initialValues.encoding);
+    messageType = initialValues.messageType;
     inputRetrieved = Date.now();
     summary = initialValues.summary;
     details = initialValues.details;
@@ -262,7 +266,7 @@
       on:blur={(e) => onInputChange(e, 'workflowType')}
     />
     {#key inputRetrieved}
-      <PayloadInputWithEncoding bind:input bind:encoding />
+      <PayloadInputWithEncoding bind:input bind:encoding bind:messageType />
     {/key}
     {#if viewAdvancedOptions}
       <Card class="flex flex-col gap-2">

Diff for: src/lib/pages/workflow-query.svelte

@@ -85,7 +85,11 @@
 
     try {
       encodePayloadResult = input
-        ? encodePayloads(input, 'json/plain', false)
+        ? encodePayloads({
+            input,
+            encoding: 'json/plain',
+            encodeWithCodec: false,
+          })
         : Promise.resolve(null);
       payloads = await encodePayloadResult;
     } catch (e) {