Remove quotes from date value and add tests (#2819)

Author: laurakwhit

src/lib/components/search-attribute-filter/filter-list.svelte

@@ -11,14 +11,11 @@
   import { translate } from '$lib/i18n/translate';
   import type { SearchAttributeFilter } from '$lib/models/search-attribute-filters';
   import { isWorkflowStatusType } from '$lib/models/workflow-status';
-  import {
-    relativeTime,
-    timeFormat,
-    type TimeFormat,
-  } from '$lib/stores/time-format';
+  import { relativeTime, timeFormat } from '$lib/stores/time-format';
   import { formatDate } from '$lib/utilities/format-date';
   import { isNullConditional, isStartsWith } from '$lib/utilities/is';
   import {
+    formatDateTimeRange,
     isDateTimeFilter,
     isTextFilter,
   } from '$lib/utilities/query/search-attribute-filter';
@@ -70,21 +67,6 @@
       return translate('common.after').toLowerCase();
     return conditional;
   };
-
-  const formatDateTimeRange = (
-    value: string,
-    format: TimeFormat,
-    relative: boolean,
-  ) => {
-    const [conditon, start, operator, end] = value.split(' ');
-    return `${conditon.toLowerCase()} ${formatDate(start, format, {
-      relative,
-      abbrFormat: true,
-    })} ${operator.toLowerCase()} ${formatDate(end, format, {
-      relative,
-      abbrFormat: true,
-    })}`;
-  };
 </script>
 
 <div class="flex flex-wrap gap-2" class:pt-2={visibleFilters.length}>

src/lib/utilities/query/search-attribute-filter.test.ts

@@ -5,6 +5,7 @@ import { describe, expect, it } from 'vitest';
 import type { SearchAttributes } from '$lib/types/workflows';
 
 import {
+  formatDateTimeRange,
   formatListFilterValue,
   isBooleanFilter,
   isDateTimeFilter,
@@ -174,3 +175,32 @@ describe('formatListFilterValue', () => {
     expect(formatListFilterValue('example')).toStrictEqual(['example']);
   });
 });
+
+describe('formatDateTimeRange', () => {
+  it('should format a date range between two dates', () => {
+    expect(
+      formatDateTimeRange(
+        'BETWEEN "2025-07-17T00:00:00.000Z" AND "2025-07-17T00:00:00.000Z"',
+        'UTC',
+        false,
+      ),
+    ).toStrictEqual('between 2025-07-17 00:00 AM and 2025-07-17 00:00 AM');
+    expect(
+      formatDateTimeRange(
+        'BETWEEN 2025-07-17T00:00:00.000Z AND 2025-07-17T00:00:00.000Z',
+        'UTC',
+        false,
+      ),
+    ).toStrictEqual('between 2025-07-17 00:00 AM and 2025-07-17 00:00 AM');
+  });
+
+  it('should format a date range between two dates with a different time format', () => {
+    expect(
+      formatDateTimeRange(
+        'BETWEEN "2025-07-17T00:00:00.000Z" AND "2025-07-17T00:00:00.000Z"',
+        'Pacific Daylight Time',
+        false,
+      ),
+    ).toStrictEqual('between 2025-07-16 17:00 PM and 2025-07-16 17:00 PM');
+  });
+});

src/lib/utilities/query/search-attribute-filter.ts

@@ -2,7 +2,9 @@ import { get } from 'svelte/store';
 
 import type { SearchAttributeFilter } from '$lib/models/search-attribute-filters';
 import { searchAttributes } from '$lib/stores/search-attributes';
+import type { TimeFormat } from '$lib/stores/time-format';
 import { SEARCH_ATTRIBUTE_TYPE } from '$lib/types/workflows';
+import { formatDate } from '$lib/utilities/format-date';
 
 export function isStatusFilter({ attribute }: SearchAttributeFilter) {
   return attribute === 'ExecutionStatus';
@@ -97,3 +99,22 @@ export function formatListFilterValue(value: string): string[] {
   if (value) return [value];
   return [];
 }
+
+export const formatDateTimeRange = (
+  value: string,
+  format: TimeFormat,
+  relative: boolean,
+) => {
+  const [conditon, start, operator, end] = value.split(' ');
+  return `${conditon.toLowerCase()} ${formatDate(
+    start.replace(/"/g, ''),
+    format,
+    {
+      relative,
+      abbrFormat: true,
+    },
+  )} ${operator.toLowerCase()} ${formatDate(end.replace(/"/g, ''), format, {
+    relative,
+    abbrFormat: true,
+  })}`;
+};