Skip to content

Commit 980d5a7

Browse files
authored
Remove unused page, refactor expand logic to be a prop and remove unused expandAll prop (#2651)
1 parent 06bee67 commit 980d5a7

File tree

4 files changed

+4
-91
lines changed

4 files changed

+4
-91
lines changed

src/lib/components/event/event-summary-row.svelte

+3-4
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
export let initialItem: IterableEvent | undefined;
4444
export let index = 0;
4545
export let compact = false;
46-
export let expandAll = false;
46+
export let expanded = false;
4747
export let typedError = false;
4848
export let active = false;
4949
export let onRowClick: () => void = () => {};
@@ -52,14 +52,13 @@
5252
? Array.from(event.events.keys()).shift()
5353
: event.id;
5454
55-
$: ({ workflow, run, namespace, id } = $page.params);
55+
$: ({ workflow, run, namespace } = $page.params);
5656
$: href = routeForEventHistoryEvent({
5757
eventId: event.id,
5858
namespace,
5959
workflow,
6060
run,
6161
});
62-
$: expanded = expandAll || id === event.id;
6362
$: attributes = formatAttributes(event);
6463
6564
$: currentEvent = isEventGroup(event) ? event.events.get(selectedId) : event;
@@ -127,7 +126,7 @@
127126
<tr
128127
class="row dense"
129128
id={`${event.id}-${index}`}
130-
class:expanded={expanded && !expandAll}
129+
class:expanded
131130
class:active
132131
class:failure
133132
class:canceled

src/lib/components/event/event-summary-table.svelte

-5
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
export let loading = false;
3030
export let compact = false;
3131
export let minimized = true;
32-
export let expandAll = false;
3332
export let showGraph = !compact;
3433
3534
$: initialItem = $fullEventHistory?.[0];
@@ -64,7 +63,6 @@
6463
{index}
6564
group={event}
6665
{compact}
67-
{expandAll}
6866
{initialItem}
6967
/>
7068
{:else if isPendingActivity(event)}
@@ -75,7 +73,6 @@
7573
(g) =>
7674
isPendingActivity(event) && g?.pendingActivity?.id === event.id,
7775
)}
78-
{expandAll}
7976
/>
8077
{:else if isPendingNexusOperation(event)}
8178
<PendingNexusSummaryRow
@@ -87,15 +84,13 @@
8784
g?.pendingNexusOperation?.scheduledEventId ===
8885
event.scheduledEventId,
8986
)}
90-
{expandAll}
9187
/>
9288
{:else}
9389
<EventSummaryRow
9490
{event}
9591
{index}
9692
group={groups.find((g) => isEvent(event) && g.eventIds.has(event.id))}
9793
{compact}
98-
{expandAll}
9994
{initialItem}
10095
/>
10196
{/if}

src/lib/pages/workflow-history-event-group.svelte

-82
This file was deleted.

src/lib/pages/workflow-history-event.svelte

+1
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@
108108
<EventSummaryRow
109109
{event}
110110
{index}
111+
expanded={event.id === eventId}
111112
group={groups.find((g) => isEvent(event) && g.eventIds.has(event.id))}
112113
initialItem={$fullEventHistory[0]}
113114
/>

0 commit comments

Comments
 (0)