Skip to content

Commit b337abc

Browse files
authored
DT-58 - consistent copy icon sizes (#1057)
* fix filter icon - it was using stroke instead of fill * update snapshot
1 parent ef7dbaa commit b337abc

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

Diff for: src/lib/holocene/filter-or-copy-buttons.svelte

+2-6
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
class:filtered
2929
>
3030
{#key filtered}
31-
<Icon name="filter" class="h-5 w-5" />
31+
<Icon name="filter" />
3232
{/key}
3333
</button>
3434
{/if}
@@ -37,11 +37,7 @@
3737
class="copy-or-filter-button"
3838
on:click|preventDefault|stopPropagation={(e) => copy(e, content)}
3939
>
40-
<Icon
41-
name={$copied ? 'checkmark' : 'copy'}
42-
stroke="#000"
43-
class="h-5 w-5"
44-
/>
40+
<Icon name={$copied ? 'checkmark' : 'copy'} stroke="#000" />
4541
</button>
4642
{/if}
4743
</div>

Diff for: src/lib/holocene/icon/__snapshots__/icon.test.ts.snap

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ exports[`Icon > file-import renders 1`] = `"<svg width=\\"24\\" height=\\"24\\"
6868
6969
exports[`Icon > file-upload renders 1`] = `"<svg width=\\"24\\" height=\\"24\\" viewBox=\\"0 0 24 24\\" fill=\\"none\\" xmlns=\\"http://www.w3.org/2000/svg\\"><path d=\\"M7.8125 8.875L11.5 5.625V15.5C11.5 15.7812 11.7188 16 12 16C12.25 16 12.5 15.7812 12.5 15.5V5.625L16.1562 8.875C16.25 8.96875 16.375 9 16.5 9C16.625 9 16.75 8.96875 16.8438 8.84375C17.0312 8.65625 17.0312 8.3125 16.8125 8.15625L12.3125 4.15625C12.125 3.96875 11.8438 3.96875 11.6562 4.15625L7.15625 8.15625C6.9375 8.3125 6.9375 8.625 7.125 8.84375C7.28125 9.0625 7.625 9.0625 7.8125 8.875ZM18 14H14.5C14.2188 14 14 14.25 14 14.5C14 14.7812 14.2188 15 14.5 15H18C18.5312 15 19 15.4688 19 16V18C19 18.5625 18.5312 19 18 19H6C5.4375 19 5 18.5625 5 18V16C5 15.4688 5.4375 15 6 15H9.5C9.75 15 10 14.7812 10 14.5C10 14.25 9.75 14 9.5 14H6C4.875 14 4 14.9062 4 16V18C4 19.125 4.875 20 6 20H18C19.0938 20 20 19.125 20 18V16C20 14.9062 19.0938 14 18 14ZM17.75 17C17.75 16.5938 17.4062 16.25 17 16.25C16.5625 16.25 16.25 16.5938 16.25 17C16.25 17.4375 16.5625 17.75 17 17.75C17.4062 17.75 17.75 17.4375 17.75 17Z\\" fill=\\"currentcolor\\"></path></svg>"`;
7070
71-
exports[`Icon > filter renders 1`] = `"<svg width=\\"24\\" height=\\"24\\" viewBox=\\"0 0 24 24\\" fill=\\"none\\" xmlns=\\"http://www.w3.org/2000/svg\\"><path d=\\"M5.5 7.5H18.5C18.75 7.5 19 7.28125 19 7.03125C19 6.78125 18.75 6.5 18.5 6.5H5.5C5.21875 6.5 5 6.75 5 7C5 7.25 5.21875 7.5 5.5 7.5ZM16.5 11.5H7.5C7.21875 11.5 7 11.75 7 12C7 12.2812 7.21875 12.5 7.5 12.5H16.5C16.75 12.5 17 12.2812 17 12.0312C17 11.75 16.75 11.5 16.5 11.5ZM13.5 16.5H10.5C10.2188 16.5 10 16.75 10 17C10 17.25 10.2188 17.5 10.5 17.5H13.5C13.75 17.5 14 17.2812 14 17.0312C14 16.7812 13.75 16.5 13.5 16.5Z\\" stroke=\\"currentcolor\\"></path></svg>"`;
71+
exports[`Icon > filter renders 1`] = `"<svg width=\\"24\\" height=\\"24\\" viewBox=\\"0 0 24 24\\" fill=\\"none\\" xmlns=\\"http://www.w3.org/2000/svg\\"><path d=\\"M5.5 7.5H18.5C18.75 7.5 19 7.28125 19 7.03125C19 6.78125 18.75 6.5 18.5 6.5H5.5C5.21875 6.5 5 6.75 5 7C5 7.25 5.21875 7.5 5.5 7.5ZM16.5 11.5H7.5C7.21875 11.5 7 11.75 7 12C7 12.2812 7.21875 12.5 7.5 12.5H16.5C16.75 12.5 17 12.2812 17 12.0312C17 11.75 16.75 11.5 16.5 11.5ZM13.5 16.5H10.5C10.2188 16.5 10 16.75 10 17C10 17.25 10.2188 17.5 10.5 17.5H13.5C13.75 17.5 14 17.2812 14 17.0312C14 16.7812 13.75 16.5 13.5 16.5Z\\" fill=\\"currentcolor\\"></path></svg>"`;
7272
7373
exports[`Icon > filter-solid renders 1`] = `"<svg width=\\"24\\" height=\\"24\\" viewBox=\\"0 0 24 24\\" fill=\\"none\\" xmlns=\\"http://www.w3.org/2000/svg\\"><path d=\\"M3.99961 3H19.9997C20.552 3 20.9997 3.44764 20.9997 3.99987L20.9999 5.58569C21 5.85097 20.8946 6.10538 20.707 6.29295L14.2925 12.7071C14.105 12.8946 13.9996 13.149 13.9996 13.4142L13.9996 19.7192C13.9996 20.3698 13.3882 20.8472 12.7571 20.6894L10.7571 20.1894C10.3119 20.0781 9.99961 19.6781 9.99961 19.2192L9.99961 13.4142C9.99961 13.149 9.89425 12.8946 9.70672 12.7071L3.2925 6.29289C3.10496 6.10536 2.99961 5.851 2.99961 5.58579V4C2.99961 3.44772 3.44732 3 3.99961 3Z\\" fill=\\"currentcolor\\"></path></svg>"`;
7474

Diff for: src/lib/holocene/icon/svg/filter.svelte

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
<Svg {...$$props}>
66
<path
77
d="M5.5 7.5H18.5C18.75 7.5 19 7.28125 19 7.03125C19 6.78125 18.75 6.5 18.5 6.5H5.5C5.21875 6.5 5 6.75 5 7C5 7.25 5.21875 7.5 5.5 7.5ZM16.5 11.5H7.5C7.21875 11.5 7 11.75 7 12C7 12.2812 7.21875 12.5 7.5 12.5H16.5C16.75 12.5 17 12.2812 17 12.0312C17 11.75 16.75 11.5 16.5 11.5ZM13.5 16.5H10.5C10.2188 16.5 10 16.75 10 17C10 17.25 10.2188 17.5 10.5 17.5H13.5C13.75 17.5 14 17.2812 14 17.0312C14 16.7812 13.75 16.5 13.5 16.5Z"
8-
stroke="currentcolor"
8+
fill="currentcolor"
99
/>
1010
</Svg>

0 commit comments

Comments
 (0)