fix: handle legacy verification job payloads

Author: o-az

apps/contract-verification/src/job-runner.ts

@@ -7,6 +7,13 @@ import { runVerificationJob } from '#route.verify.ts'
 
 const logger = getLogger(['tempo', 'job-runner'])
 
+type LegacyStoredJob = Pick<
+	VerificationJob,
+	'jobId' | 'chainId' | 'address'
+> & {
+	body: Omit<VerificationJob, 'jobId' | 'chainId' | 'address'>
+}
+
 export class VerificationJobRunner extends DurableObject<Cloudflare.Env> {
 	async enqueue(job: VerificationJob): Promise<void> {
 		logger.info('job_enqueued', {
@@ -20,12 +27,27 @@ export class VerificationJobRunner extends DurableObject<Cloudflare.Env> {
 	}
 
 	override async alarm(): Promise<void> {
-		const job = await this.ctx.storage.get<VerificationJob>('job')
-		if (!job) {
+		const storedJob = await this.ctx.storage.get<
+			VerificationJob | LegacyStoredJob
+		>('job')
+		if (!storedJob) {
 			logger.warn('alarm_job_missing')
 			return
 		}
 
+		const job =
+			'body' in storedJob
+				? {
+						jobId: storedJob.jobId,
+						chainId: storedJob.chainId,
+						address: storedJob.address,
+						stdJsonInput: storedJob.body.stdJsonInput,
+						compilerVersion: storedJob.body.compilerVersion,
+						contractIdentifier: storedJob.body.contractIdentifier,
+						creationTransactionHash: storedJob.body.creationTransactionHash,
+					}
+				: storedJob
+
 		logger.info('job_started', {
 			jobId: job.jobId,
 			chainId: job.chainId,

apps/contract-verification/test/unit/job-runner-do.test.ts

@@ -182,6 +182,34 @@ describe('VerificationJobRunner Durable Object', () => {
 			expect(row?.errorCode).toBe('internal_error')
 		})
 
+		it('handles legacy stored job payloads written before the schema flattening change', async () => {
+			const jobId = globalThis.crypto.randomUUID()
+			await insertJobRow(jobId)
+
+			const stub = getStub(jobId)
+			await runInDurableObject(stub, async (_instance, state) => {
+				const job = makeJob(jobId)
+				await state.storage.put('job', {
+					jobId: job.jobId,
+					chainId: job.chainId,
+					address: job.address,
+					body: {
+						stdJsonInput: job.stdJsonInput,
+						compilerVersion: job.compilerVersion,
+						contractIdentifier: job.contractIdentifier,
+						creationTransactionHash: job.creationTransactionHash,
+					},
+				})
+				await state.storage.setAlarm(Date.now() + 60_000)
+			})
+
+			await runDurableObjectAlarm(stub)
+
+			const row = await getJobRow(jobId)
+			expect(row).not.toBeNull()
+			expect(row?.completedAt).not.toBeNull()
+		})
+
 		it('does not leave a dangling alarm after processing', async () => {
 			const jobId = globalThis.crypto.randomUUID()
 			await insertJobRow(jobId)