Conversation
|
|
||
| The old selector must revert as an unknown function selector after activation. | ||
|
|
||
| `scopes` uses the existing TIP-1011 schema: |
There was a problem hiding this comment.
need to bench if this RLP decoding needs to be metered, or existing input gas is enough
📊 Tempo Precompiles CoverageprecompilesCoverage: 6452/10597 lines (60.89%) File details
contractsCoverage: 1/202 lines (0.50%) File details
Total: 6453/10799 lines (59.76%) |
|
|
cyclops audit super-fast |
tempoxyz-bot
left a comment
tempoxyz-bot
left a comment
There was a problem hiding this comment.
👁️ Cyclops Review — No actionable findings.
| /// @notice Creates or replaces call scopes for an existing key. | ||
| /// @param keyId The key whose scopes are updated. | ||
| /// @param scopes Canonical RLP encoding of a non-empty CallScope list. | ||
| function setAllowedCalls(address keyId, bytes calldata scopes) external; |
There was a problem hiding this comment.
it may be worth noting for integrators that calldata decoding is insufficient e.g. explorer can no longer render args. maybe we should add events in t11 for setAllowedCalls?
ofc there is getAllowedCalls
There was a problem hiding this comment.
yeah but we don't emit the configured scopes during key authorization either so this feels like a separate issue
|
+1 |
![tempo-voight-kampff[bot]](https://avatars.githubusercontent.com/in/3551435?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approving on behalf of @0xalpharush, who approved this pull request with a +1 comment via Voight-Kampff (head 0a23e1610591).
GitHub branch protection considers pull request reviews, not +1 comments. Voight-Kampff is recording this approval on the reviewer's behalf so branch protection requirements are met.
Prerequisite for tempoxyz#7269. Adds TIP-1100 and raises the precompile input charge from 6 to 30 gas per 32-byte word at T11 while preserving pre-T11 replay behavior.
|
Hi @klkvr — your review approval was detected by Voight-Kampff, but this repository configures Ask another reviewer to |
5 participants
Depends on #7281.
Removes the direct AccountKeychain authorization entrypoints and replaces nested setAllowedCalls ABI input with TIP-1011 RLP. The RLP payload pays another 50 gas per 32-byte word on top of TIP-1100 input pricing.