Merge pull request #1036 from ArlonHelps/aa/5.x-laravel-10

ArlonAntonius · web-flow · commit 13146f4c1bf1 · 2023-07-11T09:22:50.000+02:00
[5.x] Laravel 10 Support
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -6,7 +6,7 @@ references:
         steps:
             - checkout
             - run: apt-get -yqq update
-            - run: apt-get -yqq install git unzip zip libpq-dev default-mysql-client libpng-dev
+            - run: apt-get -yqq install git unzip zip libpq-dev default-mysql-client libpng-dev postgresql
             - run: docker-php-ext-install pdo_pgsql pdo_mysql gd
             - run: curl -sS https://getcomposer.org/installer | php
             - run: chmod +x composer.phar
@@ -19,6 +19,7 @@ references:
             - run: mysql --host=mysql -e "grant all privileges on *.* to 'testing'@'%' with grant option;"
             - run: mysql --host=mariadb2 -e "grant all privileges on *.* to 'testing'@'%' with grant option;"
             - run: mysql --host=mysql2 -e "grant all privileges on *.* to 'testing'@'%' with grant option;"
+            - run: PGPASSWORD=testing psql --host=pgsql --user=testing -c "GRANT ALL ON SCHEMA public TO testing;"
             - run: |
                 if [[ "${CIRCLE_JOB}" == *-nginx ]]; then
                     apt-get -yqq install nginx
@@ -54,14 +55,14 @@ references:
         name: mariadb2
         environment: *mysql_environment
     pgsql: &pgsql
-        image: postgres:latest
+        image: postgres:14
         name: pgsql
         environment:
             - POSTGRES_DB: testing
             - POSTGRES_USER: testing
             - POSTGRES_PASSWORD: testing
     pgsql2: &pgsql2
-        image: postgres:latest
+        image: postgres:14
         name: pgsql2
         environment:
             - POSTGRES_DB: testing
@@ -74,9 +75,20 @@ references:
         - APP_KEY: deela5kinohw0haekoothahSh8eexach
 
 jobs:
-    "php-8.0-apache":
+    "php-8.1-apache":
+        docker:
+            - image: php:8.1-apache
+              environment: *environment
+            - *mysql
+            - *mariadb
+            - *pgsql
+            - *mysql2
+            - *mariadb2
+            - *pgsql2
+        <<: *steps
+    "php-8.1-nginx":
         docker:
-            - image: php:8.0-apache
+            - image: php:8.1-fpm
               environment: *environment
             - *mysql
             - *mariadb
@@ -85,9 +97,20 @@ jobs:
             - *mariadb2
             - *pgsql2
         <<: *steps
-    "php-8.0-nginx":
+    "php-8.2-apache":
         docker:
-            - image: php:8.0-fpm
+            - image: php:8.2-apache
+              environment: *environment
+            - *mysql
+            - *mariadb
+            - *pgsql
+            - *mysql2
+            - *mariadb2
+            - *pgsql2
+        <<: *steps
+    "php-8.2-nginx":
+        docker:
+            - image: php:8.2-fpm
               environment: *environment
             - *mysql
             - *mariadb
@@ -98,7 +121,7 @@ jobs:
         <<: *steps
     coverage:
         docker:
-            - image: php:8.0-fpm
+            - image: php:8.1-fpm
               environment: *environment
             - *mariadb
             - *mariadb2
@@ -127,12 +150,20 @@ workflows:
     version: 2
     test:
         jobs:
-            - "php-8.0-apache"
-            - "php-8.0-nginx"
+            - "php-8.1-apache"
+            - "php-8.1-nginx":
+                requires:
+                    - "php-8.1-apache"
+            - "php-8.2-apache":
+                  requires:
+                      - "php-8.1-nginx"
+            - "php-8.2-nginx":
+                  requires:
+                      - "php-8.2-apache"
             - coverage:
                 filters:
                     branches:
                         only: /^([0-9]+)\.x$/
                 requires:
-                    - "php-8.0-apache"
-                    - "php-8.0-nginx"
+                    - "php-8.1-apache"
+                    - "php-8.1-nginx"
diff --git a/ci.phpunit.xml b/ci.phpunit.xml
@@ -27,8 +27,6 @@
         <env name="APP_ENV" value="testing"/>
         <env name="APP_KEY" value="Phei9thoong3ai8aqu4ieHie6kee1zee"/>
         <env name="DB_DATABASE" value="testing"/>
-        <env name="DB_PASSWORD" value="root"/>
-        <env name="DB_USERNAME" value="root"/>
         <env name="IN_CI" value="1"/>
         <env name="LIMIT_UUID_LENGTH_32" value="1"/>
         <env name="MAIL_MAILER" value="log"/>
diff --git a/composer.json b/composer.json
@@ -26,11 +26,11 @@
         "php": "^8.0",
         "doctrine/dbal": "~2.5|~3.0",
         "ramsey/uuid": "^4.0",
-        "laravel/framework": "^9.0"
+        "laravel/framework": "^10.0"
     },
     "require-dev": {
         "fakerphp/faker": "^1.12",
-        "laravel/laravel": "^9.0",
+        "laravel/laravel": "^10.0",
         "mockery/mockery": "^1.0",
         "phpunit/phpunit": "^9.0",
         "symfony/dom-crawler": "~3.1"
diff --git a/src/Middleware/HostnameActions.php b/src/Middleware/HostnameActions.php
@@ -22,7 +22,6 @@
 use Hyn\Tenancy\Events\Hostnames\Secured;
 use Hyn\Tenancy\Events\Hostnames\UnderMaintenance;
 use Hyn\Tenancy\Traits\DispatchesEvents;
-use Illuminate\Foundation\Http\Exceptions\MaintenanceModeException;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 use Illuminate\Routing\Redirector;
@@ -104,7 +103,12 @@ protected function secure(Hostname $hostname, Request $request)
     protected function maintenance(Hostname $hostname)
     {
         $this->emitEvent(new UnderMaintenance($hostname));
-        throw new MaintenanceModeException($hostname->under_maintenance_since->timestamp, null, "");
+
+        throw new \Symfony\Component\HttpKernel\Exception\HttpException(
+            503,
+            'Service Unavailable',
+            null
+        );
     }
 
     /**
diff --git a/src/Models/Hostname.php b/src/Models/Hostname.php
@@ -36,7 +36,9 @@ class Hostname extends SystemModel implements HostnameContract
 {
     use SoftDeletes;
 
-    protected $dates = ['under_maintenance_since'];
+    protected $casts = [
+        'under_maintenance_since' => 'datetime',
+    ];
 
     public function website(): BelongsTo
     {
diff --git a/tests/unit-tests/Filesystem/LoadsTranslationsTest.php b/tests/unit-tests/Filesystem/LoadsTranslationsTest.php
@@ -32,6 +32,8 @@ protected function duringSetUp(Application $app)
 
         $this->directory = $app->make(Directory::class);
         $this->directory->setWebsite($this->website);
+
+        $this->artisan('lang:publish');
     }
 
     /**
diff --git a/tests/unit-tests/Middleware/HostnameActionsTest.php b/tests/unit-tests/Middleware/HostnameActionsTest.php
@@ -21,10 +21,10 @@
 use Hyn\Tenancy\Middleware\HostnameActions;
 use Hyn\Tenancy\Tests\Test;
 use Illuminate\Contracts\Foundation\Application;
-use Illuminate\Foundation\Http\Exceptions\MaintenanceModeException;
 use Illuminate\Http\Request;
 use Illuminate\Routing\Redirector;
 use Illuminate\Support\Carbon;
+use Symfony\Component\HttpKernel\Exception\HttpException;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 class HostnameActionsTest extends Test
@@ -43,8 +43,8 @@ public function under_maintenance()
             $this->middleware($this->hostname);
 
             $this->fail('Middleware didn\'t fire maintenance exception');
-        } catch (MaintenanceModeException $e) {
-            $this->assertEquals($e->wentDownAt->timestamp, $this->hostname->under_maintenance_since->timestamp);
+        } catch (HttpException $e) {
+            $this->assertEquals(503, $e->getStatusCode());
         }
 
         $this->hostname->under_maintenance_since = null;
diff --git a/tests/unit-tests/Queue/TenantAwareJobTest.php b/tests/unit-tests/Queue/TenantAwareJobTest.php
@@ -102,50 +102,50 @@ public function current_website_id_is_included_in_notification_job_payload()
     }
 
     /** @test */
-    public function dispatch_now_without_identified()
+    public function dispatch_sync_without_identified()
     {
         $job = new TestJob();
-        dispatch_now($job);
+        dispatch_sync($job);
 
         $this->assertNull(resolve(Environment::class)->tenant());
     }
 
     /** @test */
-    public function dispatch_now_overrides_without_identified()
+    public function dispatch_sync_overrides_without_identified()
     {
         $second = new Website;
         $this->websites->create($second);
 
         $id = $second->id;
         $job = new TestJob($id);
-        dispatch_now($job);
+        dispatch_sync($job);
 
         $this->assertEquals($id, resolve(Environment::class)->tenant()->id);
     }
 
     /** @test */
-    public function dispatch_now_identified()
+    public function dispatch_sync_identified()
     {
         $this->activateTenant();
 
         $id = resolve(Environment::class)->tenant()->id;
 
         $job = new TestJob();
-        dispatch_now($job);
+        dispatch_sync($job);
 
         $this->assertEquals($id, resolve(Environment::class)->tenant()->id);
     }
 
     /** @test */
-    public function dispatch_now_overrides_identified()
+    public function dispatch_sync_overrides_identified()
     {
         $second = new Website;
         $this->websites->create($second);
         $this->activateTenant();
 
         $id = $second->id;
         $job = new TestJob($id);
-        dispatch_now($job);
+        dispatch_sync($job);
 
         $this->assertEquals($id, resolve(Environment::class)->tenant()->id);
     }
diff --git a/tests/unit-tests/Repositories/HostnameRepositoryTest.php b/tests/unit-tests/Repositories/HostnameRepositoryTest.php
@@ -149,7 +149,7 @@ public function hostname_regex_validation()
             try {
                 $this->hostnames->create($this->hostname);
             } catch (ModelValidationException $e) {
-                $this->assertStringContainsString("The fqdn format is invalid.", $e->getMessage());
+                $this->assertStringContainsString("The fqdn field format is invalid.", $e->getMessage());
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,9 @@ class Hostname extends SystemModel implements HostnameContract`
`36`	`36`	`{`
`37`	`37`	`use SoftDeletes;`
`38`	`38`
`39`		`- protected $dates = ['under_maintenance_since'];`
	`39`	`+ protected $casts = [`
	`40`	`+ 'under_maintenance_since' => 'datetime',`
	`41`	`+ ];`
`40`	`42`
`41`	`43`	`public function website(): BelongsTo`
`42`	`44`	`{`
Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,8 @@ protected function duringSetUp(Application $app)`
`32`	`32`
`33`	`33`	`$this->directory = $app->make(Directory::class);`
`34`	`34`	`$this->directory->setWebsite($this->website);`
	`35`	`+`
	`36`	`+ $this->artisan('lang:publish');`
`35`	`37`	`}`
`36`	`38`
`37`	`39`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -102,50 +102,50 @@ public function current_website_id_is_included_in_notification_job_payload()`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`/** @test */`
`105`		`- public function dispatch_now_without_identified()`
	`105`	`+ public function dispatch_sync_without_identified()`
`106`	`106`	`{`
`107`	`107`	`$job = new TestJob();`
`108`		`- dispatch_now($job);`
	`108`	`+ dispatch_sync($job);`
`109`	`109`
`110`	`110`	`$this->assertNull(resolve(Environment::class)->tenant());`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`/** @test */`
`114`		`- public function dispatch_now_overrides_without_identified()`
	`114`	`+ public function dispatch_sync_overrides_without_identified()`
`115`	`115`	`{`
`116`	`116`	`$second = new Website;`
`117`	`117`	`$this->websites->create($second);`
`118`	`118`
`119`	`119`	`$id = $second->id;`
`120`	`120`	`$job = new TestJob($id);`
`121`		`- dispatch_now($job);`
	`121`	`+ dispatch_sync($job);`
`122`	`122`
`123`	`123`	`$this->assertEquals($id, resolve(Environment::class)->tenant()->id);`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`/** @test */`
`127`		`- public function dispatch_now_identified()`
	`127`	`+ public function dispatch_sync_identified()`
`128`	`128`	`{`
`129`	`129`	`$this->activateTenant();`
`130`	`130`
`131`	`131`	`$id = resolve(Environment::class)->tenant()->id;`
`132`	`132`
`133`	`133`	`$job = new TestJob();`
`134`		`- dispatch_now($job);`
	`134`	`+ dispatch_sync($job);`
`135`	`135`
`136`	`136`	`$this->assertEquals($id, resolve(Environment::class)->tenant()->id);`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`/** @test */`
`140`		`- public function dispatch_now_overrides_identified()`
	`140`	`+ public function dispatch_sync_overrides_identified()`
`141`	`141`	`{`
`142`	`142`	`$second = new Website;`
`143`	`143`	`$this->websites->create($second);`
`144`	`144`	`$this->activateTenant();`
`145`	`145`
`146`	`146`	`$id = $second->id;`
`147`	`147`	`$job = new TestJob($id);`
`148`		`- dispatch_now($job);`
	`148`	`+ dispatch_sync($job);`
`149`	`149`
`150`	`150`	`$this->assertEquals($id, resolve(Environment::class)->tenant()->id);`
`151`	`151`	`}`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ public function hostname_regex_validation()`
`149`	`149`	`try {`
`150`	`150`	`$this->hostnames->create($this->hostname);`
`151`	`151`	`} catch (ModelValidationException $e) {`
`152`		`- $this->assertStringContainsString("The fqdn format is invalid.", $e->getMessage());`
	`152`	`+ $this->assertStringContainsString("The fqdn field format is invalid.", $e->getMessage());`
`153`	`153`	`}`
`154`	`154`	`}`
`155`	`155`	`}`