SFTP updates

This PR:
  1. Creates `known_hosts` file and adds data team's host info to it
  2. Creates `id_rsa` file

Author: acirikTT

.github/workflows/run-tests.yaml

@@ -345,11 +345,17 @@ jobs:
             git push
           fi
           
+          # Add to known hosts and create id_rsa file
+          mkdir -p ~/.ssh && touch ~/.ssh/known_hosts
+          ssh-keyscan ${{ secrets.SFTP_OPTEST_HOST }} >> ~/.ssh/known_hosts
+          echo ${{ secrets.SFTP_OPTEST_PRIVATE_KEY }} > ~/.ssh/id_rsa
+          chmod 400 ~/.ssh/id_rsa
+
           python3 tools/send_to_data_team.py \
               --github_workflow_id ${{ github.run_id }} \
               --sftp_host ${{ secrets.SFTP_OPTEST_HOST }} \
               --sftp_user ${{ secrets.SFTP_OPTEST_USER }} \
-              --sftp_private_key ${{ secrets.SFTP_OPTEST_PRIVATE_KEY }}
+              --sftp_private_key_path ${{ secrets.SFTP_OPTEST_PRIVATE_KEY }}
 
   tests-passed:
     if: ${{ always() }}

tools/send_to_data_team.py

@@ -17,13 +17,13 @@ def __init__(
         github_workflow_id: int,
         sftp_host: str,
         sftp_user: str,
-        sftp_private_key: str,
+        sftp_private_key_path: str,
         metrics_directory_name: str = "metrics",
     ):
         self.github_workflow_id = github_workflow_id
         self.sftp_host = sftp_host
         self.sftp_user = sftp_user
-        self.sftp_private_key = sftp_private_key
+        self.sftp_private_key_path = sftp_private_key_path
         self.metrics_dir = Path(metrics_directory_name)
 
     def run(self):
@@ -45,13 +45,10 @@ def send_file(self, file_path: Path):
         Args:
             file_path: Path to the file to send.
         """
-        with tempfile.NamedTemporaryFile() as private_key_file:
-            private_key_file.write(bytes(self.sftp_private_key, "utf-8"))
-            private_key_file.flush()
-            with pysftp.Connection(
-                host=self.sftp_host, username=self.sftp_user, private_key=private_key_file.name
-            ) as sftp:
-                sftp.put(str(file_path))
+        with pysftp.Connection(
+            host=self.sftp_host, username=self.sftp_user, private_key=self.sftp_private_key_path
+        ) as sftp:
+            sftp.put(str(file_path))
 
     @staticmethod
     def write_file(pydantic_objects: List[OpTest], file_path: Path):
@@ -168,15 +165,15 @@ def collect_metrics(self, files: Dict[str, List[Path]]) -> List[OpTest]:
     parser.add_argument("--github_workflow_id", type=int, help="Github workflow id associated with the run.")
     parser.add_argument("--sftp_host", type=str, help="Sftp host.")
     parser.add_argument("--sftp_user", type=str, help="Sftp user.")
-    parser.add_argument("--sftp_private_key", type=str, help="Path to private key.")
+    parser.add_argument("--sftp_private_key_path", type=str, help="Path to private key.")
 
     args = parser.parse_args()
 
     sender = SendToDataTeam(
         github_workflow_id=args.github_workflow_id,
         sftp_host=args.sftp_host,
         sftp_user=args.sftp_user,
-        sftp_private_key=args.sftp_private_key,
+        sftp_private_key_path=args.sftp_private_key_path,
     )
 
     sender.run()