Skip to content

Commit ef6db23

Browse files
committed
Add TODO
1 parent ca035be commit ef6db23

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tests/lowering/embedding/test_embedding.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def test_embedding_tile_layout(device, batch_size, sentence_size, vocabulary_siz
7777
[
7878
(1, 384, 160, 1024, True),
7979
(8, 384, 256, 512, True),
80-
# TODO(TODO): Not support vocabulary size > 256
80+
# TODO(#248): Not support vocabulary size > 256
8181
(8, 384, 512, 1024, False),
8282
],
8383
)

torch_ttnn/passes/lowering/to_tt_pass.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,7 @@ def rewrite_node(node):
626626

627627
if node.target == torch.ops.aten.embedding_dense_backward.default:
628628
grad_output, indices, num_weights, padding_idx, scale_grad_by_freq = args
629-
# TODO(TODO): Not support padding_idx and scale_grad_by_freq
629+
# TODO(#248): Not support padding_idx and scale_grad_by_freq
630630
if padding_idx != -1 or scale_grad_by_freq:
631631
return None
632632
if num_weights > 256:

0 commit comments

Comments
 (0)