Skip to content

Commit 76142ec

Browse files
Update group & priority tags in unet model (#2961)
### Ticket - Fixes #2960 ### Problem description - UNet tests in tt-forge-fe using two UNet implementations currently. The goal is to determine which one mimics the [target tensorflow implementation](https://github.com/hassanlougithub/brain-tumor-seg) and keep only that test in red. - [vgg19_unet/pytorch/loader.py](https://github.com/tenstorrent/tt-forge-models/blob/main/vgg19_unet/pytorch/loader.py) - [unet/pytorch/loader.py](https://github.com/tenstorrent/tt-forge-models/blob/57faf96e6050915e4fc6f22454e32609479ca4b6/unet/pytorch/loader.py#L69C13-L69C63) ### What's changed - Red tag removed from the test using [unet/pytorch/loader.py](https://github.com/tenstorrent/tt-forge-models/blob/57faf96e6050915e4fc6f22454e32609479ca4b6/unet/pytorch/loader.py#L69C13-L69C63) as it fails to mimic target implementation - Added red tag to the test using [vgg19_unet/pytorch/loader.py](https://github.com/tenstorrent/tt-forge-models/blob/main/vgg19_unet/pytorch/loader.py) as it exactly matches the target TensorFlow implementation. for more context refer - tenstorrent/tt-forge-models#152 (comment) ### Checklist - [x] New/Existing tests provide coverage for changes
1 parent 6bf215c commit 76142ec

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

forge/test/models/pytorch/vision/unet/test_unet.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ def test_unet_torchhub_pytorch():
8888
model=ModelArch.UNET,
8989
source=Source.TORCH_HUB,
9090
task=Task.IMAGE_SEGMENTATION,
91-
group=ModelGroup.RED,
92-
priority=ModelPriority.P1,
9391
)
9492
pytest.xfail(reason="https://github.com/tenstorrent/tt-forge-fe/issues/2956")
9593

forge/test/models/pytorch/vision/unet/test_vgg19_unet.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ def test_vgg19_unet():
3232
variant="default",
3333
task=Task.SEMANTIC_SEGMENTATION,
3434
source=Source.GITHUB,
35+
group=ModelGroup.RED,
36+
priority=ModelPriority.P1,
3537
)
3638
pytest.xfail(reason="https://github.com/tenstorrent/tt-forge-fe/issues/2888")
3739

0 commit comments

Comments
 (0)