Skip to content

Commit b16a0d9

Browse files
authored
[skip ci] Fix Galaxy Quick hard coded test params (#35093)
### Ticket N/A ### Problem description Galaxy Quick WH was failing due to parameterization change ### What's changed Fixed ### Checklist - [x] https://github.com/tenstorrent/tt-metal/actions/runs/20528754048/job/58976919342
1 parent d61e6c0 commit b16a0d9

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

.github/workflows/galaxy-quick-impl.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,11 +169,11 @@ jobs:
169169
./build/tools/scaleout/run_fabric_manager --mesh-shape 8x4 --fabric-config FABRIC_1D --initialize-fabric
170170
pytest "tests/nightly/tg/ccl/test_minimal_all_gather_async.py::test_all_gather_async[wormhole_b0-mesh_device0-normal-2-2-20-fabric_manager_enabled_linear-DRAM_memconfig-sd35_prompt_check-3links]" --timeout=300;
171171
pytest "tests/nightly/tg/ccl/test_minimal_reduce_scatter_async.py::test_reduce_scatter_async[wormhole_b0-mesh_device0-8-2-2-fabric_manager_enabled_linear-mem_config_input0-mem_config_rs0-batch_8-perf-3links]" --timeout=300;
172-
pytest "tests/nightly/tg/ccl/test_all_to_all_dispatch_6U.py::test_all_to_all_dispatch_8x4[wormhole_b0-l1_in_dram_out-dtype0-None-4-s2-7168-8-256-32-8x4_grid-False-fabric_manager_enabled_1d_line]" --timeout=300;
172+
pytest "tests/nightly/tg/ccl/test_all_to_all_dispatch_6U.py::test_all_to_all_dispatch_8x4[wormhole_b0-l1_in_dram_out-DataType.BFLOAT16-None-4-s2-7168-8-256-32-8x4_grid-False-fabric_manager_enabled_1d_line]" --timeout=300;
173173
./build/tools/scaleout/run_fabric_manager --mesh-shape 8x4 --fabric-config FABRIC_1D --terminate-fabric
174174
175175
pytest "tests/nightly/tg/ccl/test_all_broadcast.py::test_all_broadcast_trace[wormhole_b0-mesh_device0-device_params0-3-mem_config0-deepseek_1]" --timeout=300;
176-
pytest "tests/nightly/tg/ccl/test_all_reduce.py::test_line_all_reduce_on_TG_rows_post_commit[wormhole_b0-device_params0-math_op0-8x4_grid-8-buffer_type0-input_dtype0-4-2-per_chip_output_shape0-layout0]" --timeout=300;
176+
pytest "tests/nightly/tg/ccl/test_all_reduce.py::test_line_all_reduce_on_TG_rows_post_commit[wormhole_b0-device_params0-ReduceType.Sum-8x4_grid-8-BufferType.DRAM-DataType.BFLOAT16-4-2-per_chip_output_shape0-Layout.TILE]" --timeout=300;
177177
- uses: tenstorrent/tt-metal/.github/actions/slack-report@main
178178
if: ${{ failure() }}
179179
with:

contributing/Nanobind.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,18 @@ If we search for `report_path` in `ttnn/cpp/ttnn-nanobind`, we find the binding
165165
The error message identifies the types `std::optional` and `std::filesystem::__cxx11::path`, so we know
166166
that the typecaster headers required are `#include <nanobind/stl/optional.h>` and `#include <nanobind/stl/filesystem.h>`.
167167
168+
#### CI pytest fails because parameterization does not exist
169+
170+
Nanobind Enums, when used in a pytest, will have the actual enum value show in the test parameterization instead of
171+
a generic name and index.
172+
173+
```git
174+
- pytest "tests/nightly/tg/ccl/test_all_to_all_dispatch_6U.py::test_all_to_all_dispatch_8x4[wormhole_b0-l1_in_dram_out-dtype0-None-4-s2-7168-8-256-32-8x4_grid-False-fabric_manager_enabled_1d_line]" --timeout=300;
175+
+ pytest "tests/nightly/tg/ccl/test_all_to_all_dispatch_6U.py::test_all_to_all_dispatch_8x4[wormhole_b0-l1_in_dram_out-DataType.BFLOAT16-None-4-s2-7168-8-256-32-8x4_grid-False-fabric_manager_enabled_1d_line]" --timeout=300;
176+
177+
- pytest "tests/nightly/tg/ccl/test_all_reduce.py::test_line_all_reduce_on_TG_rows_post_commit[wormhole_b0-device_params0-math_op0-8x4_grid-8-buffer_type0-input_dtype0-4-2-per_chip_output_shape0-layout0]" --timeout=300;
178+
+ pytest "tests/nightly/tg/ccl/test_all_reduce.py::test_line_all_reduce_on_TG_rows_post_commit[wormhole_b0-device_params0-ReduceType.Sum-8x4_grid-8-BufferType.DRAM-DataType.BFLOAT16-4-2-per_chip_output_shape0-Layout.TILE]" --timeout=300;
179+
```
168180
169181
---
170182

0 commit comments

Comments
 (0)