Skip to content

#0: Fix noc_async_write_multicast to pass noc when using one packet version#37918

Merged
tt-aho merged 1 commit intomainfrom
aho/noc
Feb 16, 2026
Merged

#0: Fix noc_async_write_multicast to pass noc when using one packet version#37918
tt-aho merged 1 commit intomainfrom
aho/noc

Conversation

@tt-aho
Copy link
Contributor

@tt-aho tt-aho commented Feb 15, 2026

Ticket

Link to Github Issue

Problem description

noc_async_write_multicast does not pass user specified noc to underlying one packet api call.

What's changed

Pass noc to one packet api call.

Checklist

  • All post-commit tests
  • Blackhole Post commit
  • cpp-unit-tests
  • New/Existing tests provide coverage for changes

Model tests

If your changes cover model-related code, you should run tests corresponding to affected models and platforms (Single card, T3K, Galaxy). "Choose your pipeline" workflows facilitate running multiple kinds of tests in a single run. Each offers models-mandatory and models-extended presets.
The former includes a minimal set of tests, to be run always. The latter extends that with additional ones - use your best judgement in deciding which is the most appropriate for your PR.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes noc_async_write_multicast so that when the “one packet” path is selected, the user-specified noc argument is correctly forwarded to the underlying noc_async_write_multicast_one_packet call (instead of silently falling back to noc_index).

Changes:

  • Forward noc into noc_async_write_multicast_one_packet<false>(...) when max_page_size <= NOC_MAX_BURST_SIZE.

@tt-aho
Copy link
Contributor Author

tt-aho commented Feb 15, 2026

/codeowners ping

@tenstorrent-github-bot
Copy link

CodeOwners Group Analysis

This PR requires approval from one member of each of the following groups:

Summary: 1 pending groups, 0 approved groups

Group Information:

  • tt_metal/hw/inc/ (Group) - Members: Almeet Bhullar, Arik Yaacob, Ata Tuzuner, John Bauman, Kevin Stevens, Nathan Sidwell, Rui Zhang, Vuk Vukomanovic | Pending approval

    📁 Files owned by this group (1 files)

Note: At least one approval from each group is sufficient.

@tenstorrent-github-bot
Copy link

Hi John Bauman (@jbaumanTT), Rui Zhang (@ruizhangTT), this PR #0: Fix noc_async_write_multicast to pass noc when using one packet version by Austin Ho (@tt-aho) needs your approval/review to merge this.

@tt-aho tt-aho enabled auto-merge February 16, 2026 00:44
@tt-aho tt-aho added this pull request to the merge queue Feb 16, 2026
Merged via the queue into main with commit 26bdadf Feb 16, 2026
131 checks passed
@tt-aho tt-aho deleted the aho/noc branch February 16, 2026 05:38
pavlejosipovic pushed a commit that referenced this pull request Feb 16, 2026
…ersion (#37918)

### Ticket
Link to Github Issue

### Problem description
`noc_async_write_multicast` does not pass user specified noc to
underlying one packet api call.

### What's changed
Pass noc to one packet api call.

### Checklist

- [ ] [![All post-commit
tests](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml/badge.svg?branch=aho/noc)](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml?query=branch:aho/noc)
- [ ] [![Blackhole Post
commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml/badge.svg?branch=aho/noc)](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml?query=branch:aho/noc)
- [ ]
[![cpp-unit-tests](https://github.com/tenstorrent/tt-metal/actions/workflows/tt-metal-l2-nightly.yaml/badge.svg?branch=aho/noc)](https://github.com/tenstorrent/tt-metal/actions/workflows/tt-metal-l2-nightly.yaml?query=branch:aho/noc)
- [ ] New/Existing tests provide coverage for changes


#### Model tests

If your changes cover model-related code, you should run tests
corresponding to affected models and platforms (Single card, T3K,
Galaxy). "Choose your pipeline" workflows facilitate running multiple
kinds of tests in a single run. Each offers `models-mandatory` and
`models-extended` presets.
The former includes a minimal set of tests, to be run always. The latter
extends that with additional ones - use your best judgement in deciding
which is the most appropriate for your PR.

- [ ] [![(Single) Choose your
pipeline](https://github.com/tenstorrent/tt-metal/actions/workflows/pipeline-select.yaml/badge.svg?branch=aho/noc)](https://github.com/tenstorrent/tt-metal/actions/workflows/pipeline-select.yaml?query=branch:aho/noc)
- [ ] `models-mandatory` preset (runs: [Device perf
regressions](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml)
and [Frequent model and ttnn
tests](https://github.com/tenstorrent/tt-metal/actions/workflows/fast-dispatch-full-regressions-and-models.yaml))
- [ ] `models-extended` preset (runs: the mandatory tests, plus
[Demo](https://github.com/tenstorrent/tt-metal/actions/workflows/single-card-demo-tests.yaml)
and [Model
perf](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml)
tests)
  - [ ] other selection - specify runs

- [ ] [![(T3K) Choose your
pipeline](https://github.com/tenstorrent/tt-metal/actions/workflows/pipeline-select-t3k.yaml/badge.svg?branch=aho/noc)](https://github.com/tenstorrent/tt-metal/actions/workflows/pipeline-select-t3k.yaml?query=branch:aho/noc)
- [ ] `models-mandatory` preset (runs: [Unit
tests](https://github.com/tenstorrent/tt-metal/actions/workflows/t3000-unit-tests.yaml))
- [ ] `models-extended` preset (runs: the mandatory tests, plus
[Demo](https://github.com/tenstorrent/tt-metal/actions/workflows/t3000-demo-tests.yaml)
and [Model
perf](https://github.com/tenstorrent/tt-metal/actions/workflows/t3000-model-perf-tests.yaml)
tests)
  - [ ] other selection - specify runs

- [ ] [![(Galaxy) Choose your
pipeline](https://github.com/tenstorrent/tt-metal/actions/workflows/pipeline-select-galaxy.yaml/badge.svg?branch=aho/noc)](https://github.com/tenstorrent/tt-metal/actions/workflows/pipeline-select-galaxy.yaml?query=branch:aho/noc)
- [ ] `models-mandatory` preset (runs: [Quick
tests](https://github.com/tenstorrent/tt-metal/actions/workflows/galaxy-quick.yaml))
- [ ] `models-extended` preset (runs: the mandatory tests, plus
[Demo](https://github.com/tenstorrent/tt-metal/actions/workflows/galaxy-demo-tests.yaml)
and [Model
perf](https://github.com/tenstorrent/tt-metal/actions/workflows/galaxy-perf-tests.yaml)
tests)
  - [ ] other selection - specify runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants