-
Notifications
You must be signed in to change notification settings - Fork 117
Open
Labels
Description
After receiving this comment and further discussion with @rpavlovicTT and @odjuricicTT, we decided to break the PR in two parts:
- Just supporting
D2M_SubgraphOpthrough optimizer and treat the op as a single op that reads/writes to DRAM. That is what this PR does. - Support adding
D2M_SubgraphOpto an existing L1 chain.- One way to support this is to modify
getUniqueTestConfigsfunction inOptimizerUtils.cpp(as done here). Though this could break the existing logic of the Optimizer. - One other way is to modify call site and special-case
D2M_SubgraphOpinShardSolver.cpp, eg:
- One way to support this is to modify
// ShardSolver.cpp
llvm::SmallVector<OpConfig> testConfigs;
if (llvm::isa<ttnn::D2MSubgraphOp>(consumerOp)) {
for (const OpConfig &c : consumerConfigs) {
testConfigs.push_back(c);
}
} else {
testConfigs = optimizer_utils::getUniqueTestConfigs(
consumerConfigs, shouldUseIgnorePhysicalLayout(consumerOp));
}There might be better ways to support this as well.
This issue tracks the resolution of number 2 mentioned above.
Reactions are currently unavailable