Improve spec resiliency to resolve random failures

Author: tylerhunt

spec/acceptance/user_manages_triggers_spec.rb

@@ -1,6 +1,11 @@
 require "acceptance_helper"
 
 RSpec.describe "User manages triggers" do
+  before do
+    connection = ActiveRecord::Base.connection
+    connection.execute "DROP TABLE IF EXISTS users;"
+  end
+
   it "handles simple triggers" do
     successfully "rails generate model user name:string upper_name:string"
     successfully "rails generate fx:function uppercase_users_name"
@@ -15,7 +20,7 @@
     EOS
     successfully "rails generate fx:trigger uppercase_users_name table_name:users"
     write_trigger_definition "uppercase_users_name_v01", <<~EOS
-      CREATE TRIGGER uppercase_users_name
+      CREATE OR REPLACE TRIGGER uppercase_users_name
           BEFORE INSERT ON users
           FOR EACH ROW
           EXECUTE FUNCTION uppercase_users_name();
@@ -33,7 +38,7 @@
 
     successfully "rails generate fx:trigger uppercase_users_name table_name:users"
     write_trigger_definition "uppercase_users_name_v02", <<~EOS
-      CREATE TRIGGER uppercase_users_name
+      CREATE OR REPLACE TRIGGER uppercase_users_name
           BEFORE UPDATE ON users
           FOR EACH ROW
           EXECUTE FUNCTION uppercase_users_name();

spec/features/triggers/migrations_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe "Trigger migrations", :db do
   around do |example|
     connection.execute <<~EOS
-      CREATE TABLE users (
+      CREATE TABLE IF NOT EXISTS users (
           id int PRIMARY KEY,
           name varchar(256),
           upper_name varchar(256)
@@ -19,7 +19,7 @@
       $$ LANGUAGE plpgsql;
     EOS
     sql_definition = <<~EOS
-      CREATE TRIGGER uppercase_users_name
+      CREATE OR REPLACE TRIGGER uppercase_users_name
           BEFORE INSERT ON users
           FOR EACH ROW
           EXECUTE FUNCTION uppercase_users_name();

spec/features/triggers/revert_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe "Reverting migrations", :db do
   around do |example|
     connection.execute <<~EOS
-      CREATE TABLE users (
+      CREATE TABLE IF NOT EXISTS users (
           id int PRIMARY KEY,
           name varchar(256),
           upper_name varchar(256)
@@ -19,7 +19,7 @@
       $$ LANGUAGE plpgsql;
     EOS
     sql_definition = <<~EOS
-      CREATE TRIGGER uppercase_users_name
+      CREATE OR REPLACE TRIGGER uppercase_users_name
           BEFORE INSERT ON users
           FOR EACH ROW
           EXECUTE FUNCTION uppercase_users_name();
@@ -68,7 +68,7 @@ def change
     connection.create_trigger(:uppercase_users_name)
 
     sql_definition = <<~EOS
-      CREATE TRIGGER uppercase_users_name
+      CREATE OR REPLACE TRIGGER uppercase_users_name
           BEFORE UPDATE ON users
           FOR EACH ROW
           EXECUTE FUNCTION uppercase_users_name();

spec/fx/adapters/postgres/functions_spec.rb

@@ -15,10 +15,8 @@
 
       functions = Fx::Adapters::Postgres::Functions.new(connection).all
 
-      first = functions.first
-      expect(functions.size).to eq(1)
-      expect(first.name).to eq("test")
-      expect(first.definition).to eq(<<~EOS)
+      expect(functions.map(&:name)).to include("test")
+      expect(functions.detect { |f| f.name == "test" }.definition).to eq(<<~EOS)
         CREATE OR REPLACE FUNCTION public.test()
          RETURNS text
          LANGUAGE plpgsql

spec/fx/adapters/postgres/triggers_spec.rb

@@ -5,7 +5,7 @@
     it "returns `Trigger` objects" do
       connection = ActiveRecord::Base.connection
       connection.execute <<~EOS
-        CREATE TABLE users (
+        CREATE TABLE IF NOT EXISTS users (
             id int PRIMARY KEY,
             name varchar(256),
             upper_name varchar(256)
@@ -21,7 +21,7 @@
         $$ LANGUAGE plpgsql;
       EOS
       connection.execute <<~EOS
-        CREATE TRIGGER uppercase_users_name
+        CREATE OR REPLACE TRIGGER uppercase_users_name
             BEFORE INSERT ON users
             FOR EACH ROW
             EXECUTE FUNCTION uppercase_users_name();

spec/fx/adapters/postgres_spec.rb

@@ -22,7 +22,7 @@
   describe "#create_trigger" do
     it "successfully creates a trigger" do
       connection.execute <<~EOS
-        CREATE TABLE users (
+        CREATE TABLE IF NOT EXISTS users (
             id int PRIMARY KEY,
             name varchar(256),
             upper_name varchar(256)
@@ -40,7 +40,7 @@
       EOS
       adapter.create_trigger(
         <<~EOS
-          CREATE TRIGGER uppercase_users_name
+          CREATE OR REPLACE TRIGGER uppercase_users_name
               BEFORE INSERT ON users
               FOR EACH ROW
               EXECUTE FUNCTION uppercase_users_name();
@@ -107,14 +107,14 @@
         EOS
       )
 
-      expect(adapter.functions.map(&:name)).to eq ["test"]
+      expect(adapter.functions.map(&:name)).to include("test")
     end
   end
 
   describe "#triggers" do
     it "finds triggers and builds Fx::Trigger objects" do
       connection.execute <<~EOS
-        CREATE TABLE users (
+        CREATE TABLE IF NOT EXISTS users (
             id int PRIMARY KEY,
             name varchar(256),
             upper_name varchar(256)
@@ -131,7 +131,7 @@
         $$ LANGUAGE plpgsql;
       EOS
       sql_definition = <<~EOS
-        CREATE TRIGGER uppercase_users_name
+        CREATE OR REPLACE TRIGGER uppercase_users_name
             BEFORE INSERT ON users
             FOR EACH ROW
             EXECUTE FUNCTION uppercase_users_name()

spec/fx/definition_spec.rb

@@ -58,7 +58,7 @@
     context "representing a trigger definition" do
       it "returns the content of a trigger definition" do
         sql_definition = <<~EOS
-          CREATE TRIGGER check_update
+          CREATE OR REPLACE TRIGGER check_update
           BEFORE UPDATE ON accounts
           FOR EACH ROW
           EXECUTE FUNCTION check_account_update();

spec/fx/schema_dumper_spec.rb

@@ -11,7 +11,7 @@
       $$ LANGUAGE plpgsql;
     EOS
     connection.create_function :my_function, sql_definition: sql_definition
-    connection.create_table :my_table
+    connection.create_table :my_table, if_not_exists: true
     stream = StringIO.new
     output = stream.string
 
@@ -33,7 +33,7 @@
       $$ LANGUAGE plpgsql;
     EOS
     connection.create_function :my_function, sql_definition: sql_definition
-    connection.create_table :my_table
+    connection.create_table :my_table, if_not_exists: true
     stream = StringIO.new
     output = stream.string
 
@@ -48,7 +48,7 @@
 
   it "does not dump a create_function for aggregates in the database" do
     sql_definition = <<~EOS
-      CREATE OR REPLACE FUNCTION test(text, text)
+      CREATE OR REPLACE FUNCTION test_with_args(text, text)
       RETURNS text AS $$
       BEGIN
           RETURN 'test';
@@ -57,9 +57,9 @@
     EOS
 
     aggregate_sql_definition = <<~EOS
-      CREATE AGGREGATE aggregate_test(text)
+      CREATE OR REPLACE AGGREGATE aggregate_test(text)
       (
-          sfunc = test,
+          sfunc = test_with_args,
           stype = text
       );
     EOS
@@ -71,14 +71,14 @@
     dump(connection: connection, stream: stream)
 
     output = stream.string
-    expect(output).to include("create_function :test, sql_definition: <<-'SQL'")
+    expect(output).to include("create_function :test_with_args, sql_definition: <<-'SQL'")
     expect(output).to include("RETURN 'test';")
     expect(output).not_to include("aggregate_test")
   end
 
   it "dumps a create_trigger for a trigger in the database" do
     connection.execute <<~EOS
-      CREATE TABLE users (
+      CREATE TABLE IF NOT EXISTS users (
           id int PRIMARY KEY,
           name varchar(256),
           upper_name varchar(256)
@@ -94,7 +94,7 @@
       $$ LANGUAGE plpgsql;
     EOS
     sql_definition = <<~EOS
-      CREATE TRIGGER uppercase_users_name
+      CREATE OR REPLACE TRIGGER uppercase_users_name
           BEFORE INSERT ON users
           FOR EACH ROW
           EXECUTE FUNCTION uppercase_users_name();

spec/fx/trigger_spec.rb

@@ -39,12 +39,12 @@
     it "returns a schema compatible version of the trigger" do
       trigger = Fx::Trigger.new(
         "name" => "uppercase_users_name",
-        "definition" => "CREATE TRIGGER uppercase_users_name ..."
+        "definition" => "CREATE OR REPLACE TRIGGER uppercase_users_name ..."
       )
 
       expect(trigger.to_schema).to eq(<<-EOS)
   create_trigger :uppercase_users_name, sql_definition: <<-\SQL
-      CREATE TRIGGER uppercase_users_name ...
+      CREATE OR REPLACE TRIGGER uppercase_users_name ...
   SQL
       EOS
     end