From f2f5f800382a9dacb74b044a9e42d4da6ba9b2c2 Mon Sep 17 00:00:00 2001
From: Teo Ljungberg <teo@teoljungberg.com>
Date: Fri, 19 Dec 2025 11:12:55 +0100
Subject: [PATCH] Use methods over instance variables

---
 lib/fx/command_recorder.rb |  8 +++++---
 lib/fx/definition.rb       | 12 +++++++-----
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/lib/fx/command_recorder.rb b/lib/fx/command_recorder.rb
index a2ec0aa5..8a8c2a25 100644
--- a/lib/fx/command_recorder.rb
+++ b/lib/fx/command_recorder.rb
@@ -68,7 +68,7 @@ def initialize(args)
       end
 
       def function
-        @args[0]
+        args[0]
       end
 
       def version
@@ -84,13 +84,15 @@ def invert_version
       end
 
       def to_a
-        @args.to_a
+        args.to_a
       end
 
       private
 
+      attr_reader :args
+
       def options
-        @options ||= @args[1] || {}
+        @options ||= args[1] || {}
       end
 
       def options_for_revert
diff --git a/lib/fx/definition.rb b/lib/fx/definition.rb
index 38afec53..3a511f56 100644
--- a/lib/fx/definition.rb
+++ b/lib/fx/definition.rb
@@ -14,13 +14,13 @@ def self.trigger(name:, version:)
 
     def initialize(name:, version:, type:)
       @name = name
-      @version = version.to_i
+      @version_number = version.to_i
       @type = type
     end
 
     def to_sql
       content = File.read(find_file || full_path)
-      raise "Define #{@type} in #{path} before migrating." if content.empty?
+      raise "Define #{type} in #{path} before migrating." if content.empty?
 
       content
     end
@@ -30,17 +30,19 @@ def full_path
     end
 
     def path
-      @_path ||= File.join("db", @type.pluralize, filename)
+      @_path ||= File.join("db", type.pluralize, filename)
     end
 
     def version
-      @version.to_s.rjust(2, "0")
+      version_number.to_s.rjust(2, "0")
     end
 
     private
 
+    attr_reader :name, :version_number, :type
+
     def filename
-      @_filename ||= "#{@name}_v#{version}.sql"
+      @_filename ||= "#{name}_v#{version}.sql"
     end
 
     def find_file