Skip to content

Commit ff22989

Browse files
Fix vaulted duplicates method for older ruby versions (spree-contrib#266)
* fix Spree::Address.vaulted_duplicates method for older ruby versions * add newline
1 parent 9eff60a commit ff22989

2 files changed

Lines changed: 19 additions & 1 deletion

File tree

app/models/spree/address_decorator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module Spree
22
module AddressDecorator
33
def self.prepended(base)
44
base.scope :vaulted_duplicates, ->(address) do
5-
where.not(id: address.id).
5+
base.where.not(id: address.id).
66
where.not(braintree_id: nil).
77
where(address.attributes.except('id', 'updated_at', 'created_at', 'braintree_id', 'preferences'))
88
end

spec/models/spree/address_spec.rb

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
require 'spec_helper'
2+
3+
describe Spree::Address do
4+
describe '.vaulted_duplicates' do
5+
subject { described_class.vaulted_duplicates(given_address) }
6+
7+
let(:given_address) { create(:address) }
8+
let(:vaulted_duplicate) do
9+
Spree::Address.create(given_address.attributes.symbolize_keys.except(:id, :updated_at, :created_at, :braintree_id, :preferences).
10+
merge(braintree_id: rand(100)))
11+
end
12+
let(:some_address) { create(:address) }
13+
14+
it 'returns only vaulted duplicates of given address' do
15+
expect(subject).to contain_exactly vaulted_duplicate
16+
end
17+
end
18+
end

0 commit comments

Comments
 (0)