improve test

Author: terion-labs

tests/integration/assertions/browser.test.ts

@@ -140,6 +140,30 @@ describe("browser assertion helpers", () => {
       )
     ).toBe(true);
 
+    expect(
+      isRetryableBlankNavigationError(
+        new Error(
+          [
+            "none of the password selectors were visible after username submit: input[type=\"password\"]",
+            "current URL: https://issuer.example.test/ui/v2/login/password?requestId=oidc_123",
+            "body:\n<empty>"
+          ].join("\n")
+        )
+      )
+    ).toBe(true);
+
+    expect(
+      isRetryableBlankNavigationError(
+        new Error(
+          [
+            "none of the password selectors were visible after username submit: input[type=\"password\"]",
+            "current URL: https://issuer.example.test/ui/v2/login/password?requestId=oidc_123",
+            "body:\nPassword\nEnter your password."
+          ].join("\n")
+        )
+      )
+    ).toBe(false);
+
     expect(
       isRetryableBlankNavigationError(
         new Error(
@@ -250,7 +274,7 @@ describe("browser assertion helpers", () => {
         return this;
       },
       isVisible: async () => selector === '[data-testid="password-text-input"]' && passwordVisible,
-      innerText: async () => ""
+      innerText: async () => passwordVisible ? "Password\nEnter your password." : ""
     });
     const page = {
       url: () => currentUrl,
@@ -280,6 +304,47 @@ describe("browser assertion helpers", () => {
     expect(evaluatedAt).toEqual(["http://issuer.example.test/ui/v2/login/loginname?requestId=oidc_123"]);
   });
 
+  test("reloads a blank ZITADEL password document before waiting for password selectors", async () => {
+    let currentUrl = "https://issuer.example.test/ui/v2/login/password?requestId=oidc_123";
+    let body = "";
+    let reloads = 0;
+    let passwordVisible = false;
+    let waitedForPasswordSelector = false;
+    const page = {
+      url: () => currentUrl,
+      locator: (selector: string) => ({
+        first() {
+          return this;
+        },
+        isVisible: async () => {
+          if (selector === '[data-testid="password-text-input"]') {
+            waitedForPasswordSelector = true;
+            return passwordVisible;
+          }
+          return false;
+        },
+        innerText: async () => body
+      }),
+      reload: async () => {
+        reloads += 1;
+        body = "Password\nEnter your password.";
+        passwordVisible = true;
+      },
+      waitForTimeout: async () => undefined
+    } as unknown as Page;
+
+    const result = await __browserTestHooks.waitForPasswordInputAfterUsernameSubmit(
+      page,
+      '[data-testid="username-text-input"]',
+      "agent@example.test",
+      "app.example.test"
+    );
+
+    expect(result).toEqual({ state: "password", selector: '[data-testid="password-text-input"]' });
+    expect(reloads).toBe(1);
+    expect(waitedForPasswordSelector).toBe(true);
+  });
+
   test("does not treat the target app password field as a ZITADEL password step", async () => {
     const page = {
       url: () => "https://app.example.test/",

tests/integration/assertions/browser.ts

@@ -96,6 +96,11 @@ async function waitForPasswordInputAfterUsernameSubmit(page: Page, usernameSelec
       return { state: "target" };
     }
 
+    if (isPasswordLoginStep(currentUrl) && await reloadBlankLoginDocumentIfNeeded(page)) {
+      await page.waitForTimeout(1000);
+      continue;
+    }
+
     if (isPasswordLoginStep(currentUrl)) {
       const selector = await visiblePasswordInputSelector(page, 5000);
       if (selector) {
@@ -1299,7 +1304,11 @@ export function isRetryableBlankNavigationError(error: unknown): boolean {
     (message.includes("net::ERR_ABORTED") &&
       (message.includes("body:\n<empty>") || message.includes("browser login flow") || message.includes("timed out"))) ||
     (
-      (message.includes("none of the selectors were visible") || message.includes("none of the identity selectors were visible")) &&
+      (
+        message.includes("none of the selectors were visible") ||
+        message.includes("none of the identity selectors were visible") ||
+        message.includes("none of the password selectors were visible after username submit")
+      ) &&
       message.includes("body:\n<empty>") &&
       /https?:\/\/[^/\s]+\/ui\/v2\/login\//.test(message)
     ) ||