From b82a1280110c19fb8b1edb9aa2a91fa620eb10cd Mon Sep 17 00:00:00 2001 From: Will Bosch-Bello Date: Fri, 18 Apr 2025 13:05:12 -0500 Subject: [PATCH 1/2] fix: ensure ECS service tags are propagated This fixes the issue specifically with the `ignore_task_definition` service type. --- modules/service/main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/service/main.tf b/modules/service/main.tf index b7ecef9e..1f92de9a 100644 --- a/modules/service/main.tf +++ b/modules/service/main.tf @@ -381,7 +381,7 @@ resource "aws_ecs_service" "ignore_task_definition" { wait_for_steady_state = var.wait_for_steady_state propagate_tags = var.propagate_tags - tags = var.tags + tags = merge(var.tags, var.service_tags) timeouts { create = try(var.timeouts.create, null) From b610f5d46a0470adeab23147a931693e7141ed03 Mon Sep 17 00:00:00 2001 From: Bryant Biggs Date: Fri, 18 Apr 2025 18:20:51 -0500 Subject: [PATCH 2/2] fix: Sync both serice definitions --- .pre-commit-config.yaml | 2 +- modules/service/main.tf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 7e4e7daf..7900442e 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,6 +1,6 @@ repos: - repo: https://github.com/antonbabenko/pre-commit-terraform - rev: v1.96.1 + rev: v1.99.0 hooks: - id: terraform_fmt - id: terraform_wrapper_module_for_each diff --git a/modules/service/main.tf b/modules/service/main.tf index 1f92de9a..c69c12da 100644 --- a/modules/service/main.tf +++ b/modules/service/main.tf @@ -285,7 +285,7 @@ resource "aws_ecs_service" "ignore_task_definition" { dynamic "network_configuration" { # Set by task set if deployment controller is external - for_each = var.network_mode == "awsvpc" ? [{ for k, v in local.network_configuration : k => v if !local.is_external_deployment }] : [] + for_each = var.network_mode == "awsvpc" && !local.is_external_deployment ? [local.network_configuration] : [] content { assign_public_ip = network_configuration.value.assign_public_ip