feat!: Expose output addresses and also validate the input variable and make names required (#173)

Author: Umm-E-Kulsum

README.md

@@ -197,7 +197,7 @@ Terraform may change this fact, but this is the current limitation.
 | global | The scope in which the address should live. If set to true, the IP address will be globally scoped. Defaults to false, i.e. regionally scoped. When set to true, do not provide a subnetwork. | `bool` | `false` | no |
 | ip\_version | The IP Version that will be used by this address. | `string` | `"IPV4"` | no |
 | labels | Labels to apply to this address. | `map(string)` | `{}` | no |
-| names | A list of IP address resource names to create.  This is the GCP resource name and not the associated hostname of the IP address.  Existing resource names may be found with `gcloud compute addresses list` (e.g. ["gusw1-dev-fooapp-fe-0001-a-001-ip"]) | `list(string)` | `[]` | no |
+| names | A list of IP address resource names to create. This is the GCP resource name and not the associated hostname of the IP address. Existing resource names may be found with `gcloud compute addresses list` (e.g. ["gusw1-dev-fooapp-fe-0001-a-001-ip"]) | `list(string)` | n/a | yes |
 | network\_tier | The networking tier used for configuring this address. | `string` | `"PREMIUM"` | no |
 | prefix\_length | The prefix length of the IP range. | `number` | `16` | no |
 | project\_id | The project ID to create the address in | `string` | n/a | yes |

metadata.display.yaml

@@ -75,7 +75,8 @@ spec:
         names:
           name: names
           title: Names
-          level: 1
+          regexValidation: "^[a-z]([-a-z0-9]*[a-z0-9])?$"
+          validation: "Each name must be 1-63 chars, start with lowercase, and be RFC1035 compliant."
         network_tier:
           name: network_tier
           title: Network Tier
@@ -95,3 +96,7 @@ spec:
           name: subnetwork
           title: Subnetwork
           level: 1
+    runtime:
+      outputs:
+        addresses:
+          visibility: VISIBILITY_ROOT

metadata.yaml

@@ -61,7 +61,7 @@ spec:
       - name: names
         description: A list of IP address resource names to create.  This is the GCP resource name and not the associated hostname of the IP address.  Existing resource names may be found with `gcloud compute addresses list` (e.g. ["gusw1-dev-fooapp-fe-0001-a-001-ip"])
         varType: list(string)
-        defaultValue: []
+        required: true
       - name: addresses
         description: A list of IP addresses to create.  GCP will reserve unreserved addresses if given the value "".  If multiple names are given the default value is sufficient to have multiple addresses automatically picked for each name.
         varType: list(string)

variables.tf

@@ -25,9 +25,15 @@ variable "region" {
 }
 
 variable "names" {
-  description = "A list of IP address resource names to create.  This is the GCP resource name and not the associated hostname of the IP address.  Existing resource names may be found with `gcloud compute addresses list` (e.g. [\"gusw1-dev-fooapp-fe-0001-a-001-ip\"])"
+  description = "A list of IP address resource names to create. This is the GCP resource name and not the associated hostname of the IP address. Existing resource names may be found with `gcloud compute addresses list` (e.g. [\"gusw1-dev-fooapp-fe-0001-a-001-ip\"])"
   type        = list(string)
-  default     = []
+
+  validation {
+    condition = alltrue([
+      for n in var.names : can(regex("^[a-z]([-a-z0-9]*[a-z0-9])?$", n)) && length(n) <= 63
+    ])
+    error_message = "Each name must be 1-63 chars, start with lowercase, and be RFC1035 compliant."
+  }
 }
 
 variable "addresses" {