Skip to content

Commit 22c076a

Browse files
authored
feat: ACL rules created by the DA will be updated in place. It is not a breaking change. You will see this log when upgrading to the new version in the DA. Current ACL rules have a bug where client side ports are restricted to same as server side port which is wrong as client side port is generated dynamically. With this change, that bug will be corrected. No existing traffic is blocked, only extra traffic will be allowed after this change. (#1106)
1 parent 03e8ce6 commit 22c076a

File tree

1 file changed

+20
-32
lines changed

1 file changed

+20
-32
lines changed

solutions/fully-configurable/variables.tf

Lines changed: 20 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -199,79 +199,67 @@ variable "network_acls" {
199199
prepend_ibm_rules = true
200200
rules = [
201201
{
202-
name = "allow-all-443-inbound"
202+
name = "allow-22-inbound"
203203
action = "allow"
204204
direction = "inbound"
205205
tcp = {
206-
port_min = 443
207-
port_max = 443
208-
source_port_min = 443
209-
source_port_max = 443
206+
port_min = 22
207+
port_max = 22
210208
}
211209
destination = "0.0.0.0/0"
212210
source = "0.0.0.0/0"
213211
},
214212
{
215-
name = "allow-all-80-inbound"
213+
name = "allow-22-inbound-response"
216214
action = "allow"
217-
direction = "inbound"
215+
direction = "outbound"
218216
tcp = {
219-
port_min = 80
220-
port_max = 80
221-
source_port_min = 80
222-
source_port_max = 80
217+
source_port_min = 22
218+
source_port_max = 22
223219
}
224220
destination = "0.0.0.0/0"
225221
source = "0.0.0.0/0"
226222
},
227223
{
228-
name = "allow-all-22-inbound"
224+
name = "allow-80-inbound"
229225
action = "allow"
230226
direction = "inbound"
231227
tcp = {
232-
port_min = 22
233-
port_max = 22
234-
source_port_min = 22
235-
source_port_max = 22
228+
port_min = 80
229+
port_max = 80
236230
}
237231
destination = "0.0.0.0/0"
238232
source = "0.0.0.0/0"
239233
},
240234
{
241-
name = "allow-all-443-outbound"
235+
name = "allow-80-inbound-response"
242236
action = "allow"
243237
direction = "outbound"
244238
tcp = {
245-
source_port_min = 443
246-
source_port_max = 443
247-
port_min = 443
248-
port_max = 443
239+
source_port_min = 80
240+
source_port_max = 80
249241
}
250242
destination = "0.0.0.0/0"
251243
source = "0.0.0.0/0"
252244
},
253245
{
254-
name = "allow-all-80-outbound"
246+
name = "allow-443-inbound"
255247
action = "allow"
256-
direction = "outbound"
248+
direction = "inbound"
257249
tcp = {
258-
source_port_min = 80
259-
source_port_max = 80
260-
port_min = 80
261-
port_max = 80
250+
port_min = 443
251+
port_max = 443
262252
}
263253
destination = "0.0.0.0/0"
264254
source = "0.0.0.0/0"
265255
},
266256
{
267-
name = "allow-all-22-outbound"
257+
name = "allow-443-inbound-response"
268258
action = "allow"
269259
direction = "outbound"
270260
tcp = {
271-
source_port_min = 22
272-
source_port_max = 22
273-
port_min = 22
274-
port_max = 22
261+
source_port_min = 443
262+
source_port_max = 443
275263
}
276264
destination = "0.0.0.0/0"
277265
source = "0.0.0.0/0"

0 commit comments

Comments
 (0)