fix: VPE gateway interface update

[Aayush-Abhyarthi]

Description

Issue: #1129

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

• The terraform-ibm-vpe-gateway module has depricated the parameter allow_dns_resolution_binding and replaced it with dns_resolution_binding_mode in the cloud_services as well as cloud_service_by_crn variables.
• The dns_resolution_binding_mode parameter now supports the following values - primary, disabled and per_resource_binding.
• Following is the default values of the new parameters as per the old ones -
  allow_dns_resolution_binding = "false" -> dns_resolution_binding_mode = "disabled"
allow_dns_resolution_binding = "true" -> dns_resolution_binding_mode = "primary"

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[Aayush-Abhyarthi]

/run pipeline

[ocofaigh]

@Aayush-Abhyarthi why is this a major version release? What is the breaking change? Is there any migration required?
Please be aware that for the next major release (v8.0.0) we need to remove VPN support (as per https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/blob/main/docs/migration_guide.md) however I'm not sure if this really is a major version update is it?

[Aayush-Abhyarthi]

Tests covered against this PR -

1. Tried setting the parameter dns_resolution_binding_mode = "primary" for the variable vpe_gateway_cloud_services and the apply was successful.

2. Tried setting the parameter dns_resolution_binding_mode = "per_resource_binding" for the variable vpe_gateway_cloud_services and the apply was successful.

3. Tried setting the parameter dns_resolution_binding_mode = "disabled" for the variable vpe_gateway_cloud_services and the apply was successful.

[Aayush-Abhyarthi]

@Aayush-Abhyarthi why is this a major version release? What is the breaking change? Is there any migration required? Please be aware that for the next major release (v8.0.0) we need to remove VPN support (as per https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/blob/main/docs/migration_guide.md) however I'm not sure if this really is a major version update is it?

Yes, it is not a breaking change. Updated to a minor release.

[Aayush-Abhyarthi]

/run pipeline

[Aayush-Abhyarthi]

/run pipeline

[rajatagarwal-ibm]

You need to update DA-types.md, too. https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/blob/main/solutions/fully-configurable/DA-types.md?plain=1

[Aayush-Abhyarthi]

/run pipeline

[ocofaigh]

I know this is unrelated to the changes in this PR, but perhaps you could fix it. I just spotted this in the ibm_catalog.json:

{
  "key": "vpe_gateway_cloud_services",
  "type": "array"
},
{
  "key": "vpe_gateway_cloud_service_by_crn",
  "type": "array"
}

These should be using the HCL editor widget. Can you please fix?

[Aayush-Abhyarthi]

/run pipeline

[ocofaigh]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 8.15.0 🎉

The release is available on:

• GitHub release
• v8.15.0

Your semantic-release bot 📦🚀