feat: initial commit for DA

[maheshwarishikha]

Description

VPC DA - fully configurable variant

Issue: https://github.ibm.com/GoldenEye/issues/issues/12217

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

• Fully configurable variant
• Adds vpn_gateways feature in base module

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[ocofaigh]

I know it is still under development, but I left a few comments to make sure we address them. We should talk about the variation name. simple is probably not what we will go with

[maheshwarishikha]

I know it is still under development, but I left a few comments to make sure we address them. We should talk about the variation name. simple is probably not what we will go with

I created this draft PR with the intent of early review. Thanks for this. Yes, name will be changed once we decide.

[maheshwarishikha]

Currently,

• this simple variation does not support existing_cos_kms_key_crn scenario.
• it does not support the existing COS buckets.
  More secured version can have both of these. Let me know your thoughts.

[ocofaigh]

We really need to make use of cross variable validation in the variables.tf file. For example, if person sets kms_encryption_enabled_bucket or enable_vpc_flow_logs then other inputs become required.

Also question - should we support creating VPEs? Or are we planning to have a standalone VPE DA? (cc @vburckhardt )

[ocofaigh]

@maheshwarishikha FYI these are the variation names we will go with:

1. label: Fully configurable, name: fully-configurable
2. label: Security-enforced, name: security-enforced

[ocofaigh]

• As per our most recent discussions, we should no longer support creating a resource group, but instead we should require an existing resource group name (using input existing_resource_group_name).
  • We can still use our terraform-ibm-resource-group module in the code to return the resource group ID.
  • We should use the catalog resource group picker in the ibm_catalog.json for this input:

      {
          "key": "existing_resource_group_name",
          "custom_config": {
              "type": "resource_group",
              "grouping": "deployment",
              "original_grouping": "deployment",
              "config_constraints": {
                  "identifier": "rg_name"
              }
          }
      }
    

• Add support for VPE (using https://github.com/terraform-ibm-modules/terraform-ibm-vpe-gateway)
• Add support for VPN (see current code at https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/blob/main/vpn.tf)

[Khuzaima05]

/run pipeline

[Khuzaima05]

/run pipeline

[Khuzaima05]

Tested the updated tile:

• With all add-ons checked (Deployed Successfully)

• With Account Infra add-on only, with flow_log and kms_encryption enabled , passing existing values for cos and kms crn (Deployed Successfully)

• With Account infra and cos add-ons , passing kms key crn for encryption ( Deployed Successfully)

• With Kms add-on and cos from existing crn (Deployed Sucessfully)

[maheshwarishikha]

/run pipeline

[rajatagarwal-ibm]

LGTM

[ocofaigh]

/run pipeline

[ocofaigh]

@maheshwarishikha This is a subcategory tag. We are missing a main category tag. I'm going to add the network tag or it will prevent us from publishing. FYI you can see all tags by running ibmcloud catalog filter options --all

[ocofaigh]

@maheshwarishikha I think we need to remove this and add the ibm_beta tag. We are not supporting this tile via IBM Cloud - its only experimental beta

[ocofaigh]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 7.21.0 🎉

The release is available on:

• GitHub release
• v7.21.0

Your semantic-release bot 📦🚀