fix: correct resource_instance_id handling to prevent unnecessary resource_key recreation (#312)

Aayush-Abhyarthi · web-flow · commit 894baf9447b2 · 2026-02-24T08:47:19.000Z
diff --git a/solutions/fully-configurable/main.tf b/solutions/fully-configurable/main.tf
@@ -24,7 +24,7 @@ module "instance_crn_parser" {
 resource "ibm_resource_key" "key" {
   count                = local.create_access_key
   name                 = "${local.prefix}key"
-  resource_instance_id = module.instance_crn_parser.service_instance
+  resource_instance_id = var.instance_crn
   role                 = "Manager"
 }
 
diff --git a/tests/pr_test.go b/tests/pr_test.go
@@ -268,7 +268,6 @@ func TestFullyConfigurableUpgradeSolution(t *testing.T) {
 			{Name: "cluster_id", Value: terraform.Output(t, existingTerraformOptions, "cluster_id"), DataType: "string"},
 			{Name: "cluster_resource_group_id", Value: terraform.Output(t, existingTerraformOptions, "cluster_resource_group_id"), DataType: "string"},
 			{Name: "instance_crn", Value: terraform.Output(t, existingTerraformOptions, "instance_crn"), DataType: "string", Secure: true},
-			{Name: "access_key", Value: terraform.Output(t, existingTerraformOptions, "access_key"), DataType: "string", Secure: true},
 		}
 
 		err := options.RunSchematicUpgradeTest()

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ module "instance_crn_parser" {`
`24`	`24`	`resource "ibm_resource_key" "key" {`
`25`	`25`	`count = local.create_access_key`
`26`	`26`	`name = "${local.prefix}key"`
`27`		`- resource_instance_id = module.instance_crn_parser.service_instance`
	`27`	`+ resource_instance_id = var.instance_crn`
`28`	`28`	`role = "Manager"`
`29`	`29`	`}`
`30`	`30`
Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,6 @@ func TestFullyConfigurableUpgradeSolution(t *testing.T) {`
`268`	`268`	`{Name: "cluster_id", Value: terraform.Output(t, existingTerraformOptions, "cluster_id"), DataType: "string"},`
`269`	`269`	`{Name: "cluster_resource_group_id", Value: terraform.Output(t, existingTerraformOptions, "cluster_resource_group_id"), DataType: "string"},`
`270`	`270`	`{Name: "instance_crn", Value: terraform.Output(t, existingTerraformOptions, "instance_crn"), DataType: "string", Secure: true},`
`271`		`- {Name: "access_key", Value: terraform.Output(t, existingTerraformOptions, "access_key"), DataType: "string", Secure: true},`
`272`	`271`	`}`
`273`	`272`
`274`	`273`	`err := options.RunSchematicUpgradeTest()`