-
Notifications
You must be signed in to change notification settings - Fork 51
Expand file tree
/
Copy pathMakefile
More file actions
197 lines (165 loc) · 7.61 KB
/
Copy pathMakefile
File metadata and controls
197 lines (165 loc) · 7.61 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
SHELL := bash
LOCALBIN ?= $(CURDIR)/bin
LOCALBIN_ABS := $(abspath $(LOCALBIN))
MODULE_REGISTRY := terraform-redhat/rosa-hcp/rhcs
# renovate: datasource=github-releases depName=google/addlicense
ADDLICENSE_VERSION ?= v1.2.0
# renovate: datasource=github-releases depName=terraform-docs/terraform-docs
TERRAFORM_DOCS_VERSION ?= v0.24.0
# renovate: datasource=github-releases depName=terraform-linters/tflint
TFLINT_VERSION ?= v0.63.1
# renovate: datasource=github-releases depName=vale-cli/vale
VALE_VERSION ?= v3.15.1
# renovate: datasource=github-releases depName=bridgecrewio/checkov
CHECKOV_VERSION ?= 3.2.529
# renovate: datasource=github-releases depName=gitleaks/gitleaks
GITLEAKS_VERSION ?= v8.30.1
CHECKOV_CONFIG ?= checkov.yaml
GITLEAKS_CONFIG ?= .gitleaks.toml
ifeq ($(shell go env GOOS 2>/dev/null),windows)
BIN_EXT=.exe
else
BIN_EXT=
endif
ADDLICENSE := $(LOCALBIN)/addlicense$(BIN_EXT)
TERRAFORM_DOCS := $(LOCALBIN)/terraform-docs$(BIN_EXT)
TFLINT := $(LOCALBIN)/tflint$(BIN_EXT)
VALE := $(LOCALBIN)/vale$(BIN_EXT)
CHECKOV := $(LOCALBIN)/checkov$(BIN_EXT)
GITLEAKS := $(LOCALBIN)/gitleaks$(BIN_EXT)
export PATH := $(LOCALBIN_ABS):$(PATH)
$(LOCALBIN):
mkdir -p "$(LOCALBIN)"
$(ADDLICENSE): | $(LOCALBIN)
bash hack/install-release-tool.sh addlicense "$(ADDLICENSE_VERSION)" "$(LOCALBIN_ABS)"
$(VALE): | $(LOCALBIN)
bash hack/install-release-tool.sh vale "$(VALE_VERSION)" "$(LOCALBIN_ABS)"
$(TFLINT): | $(LOCALBIN)
bash hack/install-release-tool.sh tflint "$(TFLINT_VERSION)" "$(LOCALBIN_ABS)"
$(TERRAFORM_DOCS): | $(LOCALBIN)
bash hack/install-release-tool.sh terraform-docs "$(TERRAFORM_DOCS_VERSION)" "$(LOCALBIN_ABS)"
$(CHECKOV): | $(LOCALBIN)
bash hack/install-release-tool.sh checkov "$(CHECKOV_VERSION)" "$(LOCALBIN_ABS)"
$(GITLEAKS): | $(LOCALBIN)
bash hack/install-release-tool.sh gitleaks "$(GITLEAKS_VERSION)" "$(LOCALBIN_ABS)"
.PHONY: tools addlicense vale tflint terraform-docs-bin license-check-bin security-check-bin checkov gitleaks
tools: $(ADDLICENSE) $(VALE) $(TFLINT) $(TERRAFORM_DOCS)
addlicense: $(ADDLICENSE)
vale: $(VALE)
tflint: $(TFLINT)
terraform-docs-bin: $(TERRAFORM_DOCS)
license-check-bin: $(ADDLICENSE)
security-check-bin: $(CHECKOV) $(GITLEAKS)
checkov: $(CHECKOV)
gitleaks: $(GITLEAKS)
# Merge gate: verify, verify-gen, lint, unit-tests, license-check, docs-lint (fail-fast).
# Intended single OpenShift Prow presubmit after openshift/release switches from verify + verify-gen.
.PHONY: pre-push-checks
pre-push-checks: tools
@$(MAKE) --no-print-directory license-check
@$(MAKE) --no-print-directory docs-lint
@$(MAKE) --no-print-directory verify-gen
@$(MAKE) --no-print-directory unit-tests
@$(MAKE) --no-print-directory lint
@$(MAKE) --no-print-directory verify
# Prow today (until consolidated): verify-format → make verify, verify-gen → make verify-gen.
# https://github.com/openshift/release/tree/master/ci-operator/config/terraform-redhat/terraform-rhcs-rosa-hcp
.PHONY: verify
verify:
@set -euo pipefail; \
for d in examples/*/; do \
echo "!! Validating $$d !!"; \
( cd "$$d" && rm -rf .terraform .terraform.lock.hcl && terraform init -backend=false -input=false && terraform validate ); \
done
.PHONY: verify-gen
verify-gen: $(TERRAFORM_DOCS)
@TERRAFORM_DOCS_BIN="$(TERRAFORM_DOCS)" TERRAFORM_DOCS_VERSION="$(TERRAFORM_DOCS_VERSION)" bash scripts/verify-gen.sh
.PHONY: lint
lint:
terraform fmt -check -recursive
@command -v tflint >/dev/null 2>&1 || { echo "tflint not found; see https://github.com/terraform-linters/tflint"; exit 1; }
@set -euo pipefail; \
for d in examples/*/; do \
echo "!! rm -rf .terraform .terraform.lock.hcl && terraform init $$d (tflint) !!"; \
( cd "$$d" && rm -rf .terraform .terraform.lock.hcl && terraform init -backend=false -input=false ); \
done
tflint --init
tflint --recursive \
--minimum-failure-severity=error \
--disable-rule=terraform_required_providers \
--disable-rule=terraform_unused_declarations \
--disable-rule=terraform_unused_required_providers
.PHONY: unit-tests
unit-tests:
@set -e; \
for submodule in modules/*; do \
echo "== $$submodule =="; \
cd "$$submodule/tests" 2>/dev/null || continue; \
echo "== running tests for $$submodule =="; \
(cd .. && rm -rf .terraform .terraform.lock.hcl && terraform init -backend=false -input=false && terraform test); \
cd ../../..; \
done
.PHONY: license-check
license-check: $(ADDLICENSE)
@ADDLICENSE_BIN="$(ADDLICENSE)" ADDLICENSE_VERSION="$(ADDLICENSE_VERSION)" bash scripts/add-license-header.sh -check
.PHONY: license-add
license-add: $(ADDLICENSE)
@ADDLICENSE_BIN="$(ADDLICENSE)" ADDLICENSE_VERSION="$(ADDLICENSE_VERSION)" bash scripts/add-license-header.sh
.PHONY: docs-lint
docs-lint: $(VALE)
@echo "Note: README and module docs are generated with 'make terraform-docs'; fix descriptions in *.tf, then run 'make verify-gen'."
@docs=$$(find . -name '*.md' \
-not -path './.vale/*' \
-not -path '*/.terraform/*' \
-not -path './.terraform-docs-cache/*' \
-not -path './bin/*'); \
if [ -z "$$docs" ]; then \
echo "No Markdown files found for docs-lint"; \
exit 1; \
fi; \
"$(VALE)" --minAlertLevel=error $$docs
# Security (not in pre-push-checks): Gitleaks secret scan + Checkov Terraform static analysis.
# Excludes modules/rosa-cluster-hcp (Checkov cannot parse multiline lifecycle preconditions there).
.PHONY: security-check
security-check: $(GITLEAKS) $(CHECKOV)
@set -euo pipefail; \
echo "== Gitleaks secret scan =="; \
"$(GITLEAKS)" detect --source . --config "$(GITLEAKS_CONFIG)" --no-banner --no-git; \
echo "== Checkov Terraform static analysis =="; \
echo "Note: Checkov cannot parse modules/rosa-cluster-hcp/main.tf (lifecycle preconditions). That file is skipped directly; examples may still report one parsing error via the root module — use make verify for cluster wiring."; \
"$(CHECKOV)" -d examples --config-file "$(CHECKOV_CONFIG)" --skip-download --quiet; \
for d in modules/*/; do \
case "$$d" in */rosa-cluster-hcp/) \
echo "Skipping Checkov for $$d (lifecycle precondition parse limitation; use make verify)"; \
continue ;; \
esac; \
"$(CHECKOV)" -d "$$d" --config-file "$(CHECKOV_CONFIG)" --skip-download --quiet; \
done; \
root_tf=$$(find . -maxdepth 1 -name '*.tf' -print); \
if [ -n "$$root_tf" ]; then \
"$(CHECKOV)" $$(printf ' -f %s' $$root_tf) --config-file "$(CHECKOV_CONFIG)" --skip-download --quiet; \
fi
.PHONY: terraform-docs
terraform-docs: $(TERRAFORM_DOCS)
@TERRAFORM_DOCS_BIN="$(TERRAFORM_DOCS)" TERRAFORM_DOCS_VERSION="$(TERRAFORM_DOCS_VERSION)" bash scripts/terraform-docs.sh
.PHONY: commits/check
commits/check:
@./hack/commit-msg-verify.sh
# OpenShift Prow example jobs (rhcs-module-run-example-hcp): make run-example EXAMPLE_NAME=...
.PHONY: run-example
run-example:
bash scripts/run-example.sh $(EXAMPLE_NAME)
# Maintainer utilities (not part of pre-push-checks).
.PHONY: dev-environment registry-environment change-ocp-version change-module-version
dev-environment:
find . -type f -name "versions.tf" -exec sed -i -e "s/terraform-redhat\/rhcs/terraform.local\/local\/rhcs/g" -- {} +
registry-environment:
find . -type f -name "versions.tf" -exec sed -i -e "s/terraform.local\/local\/rhcs/terraform-redhat\/rhcs/g" -- {} +
change-ocp-version:
find . -type f -name "variables.tf" -exec sed -i -e 's/default = "$(OLD_VER)"/default = "$(NEW_VER)"/g' -- {} +
change-module-version:
find ./examples -type f -name '*.tf' -exec sed -i 's^source\s*= "\.\./\.\./"^source = "$(MODULE_REGISTRY)"\n version = "$(MODULE_VERSION)"^g' -- {} +
find ./examples -type f -name '*.tf' -exec sed -E -i 's^source\s*= "\.\./\.\./modules/([^"]+)"^source = "$(MODULE_REGISTRY)//modules/\1"\n version = "$(MODULE_VERSION)"^g' -- {} +
.PHONY: tests
tests:
sh tests.sh