ROSAENG-59431 | docs: add agent agnostic documentation

Signed-off-by: Amanda Hager Lopes de Andrade Katz <amanda.katz@redhat.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: amandahla

.coderabbit.yaml

@@ -1,69 +1,15 @@
 inheritance: true
+
+knowledge_base:
+  code_guidelines:
+    filePatterns:
+      - "developer-docs/**"
+
 reviews:
   path_filters:
     - "!**/.terraform/**"
     - "!**/terraform.tfstate*"
 
-  path_instructions:
-    - path: "**/*.tf"
-      instructions: |
-        **ROSA HCP only** — not ROSA Classic (see terraform-rhcs-rosa-classic).
-        **rhcs** registry schemas are authoritative; do not invent attributes.
-        Root **versions.tf** sets minimum **rhcs** / **aws** / other providers
-        for the **entire** tree; raise root when any submodule raises a floor.
-        AWS-only work must match **Module scope** in
-        .cursor/rules/rosa-hcp-terraform.mdc. Variables: snake_case;
-        **sensitive** on secrets; no long-lived keys in HCL. Finer points
-        (validation, import-safe count/for_each): see **AGENTS.md** and
-        .cursor/rules.
-
-    - path: "modules/**"
-      instructions: |
-        Submodule changes affect root, **examples/**, and downstream users.
-
-        1. **Breaking changes:** No silent renames/retypes of variables or
-           outputs; migration plan or explicit PR callout (AGENTS.md).
-
-        2. **Provider floor:** **required_providers** changes → update root
-           **versions.tf** for the whole module tree.
-
-        3. **IAM / STS / OIDC / IRSA:** Least privilege; link non-obvious
-           cross-account or shared-VPC patterns to official ROSA HCP docs.
-
-        4. **Ordering:** IAM/STS eventual consistency — **depends_on** /
-           waits / preconditions where immediate effect is assumed.
-
-        5. **Tests / examples:** Update **modules/*/tests/*.tftest.hcl** and
-           keep **make verify** green for touched **examples/**.
-
-        6. **modules/rosa-cluster-hcp:** **rhcs_cluster_rosa_hcp** (and
-           related rhcs resources) — match provider docs; document minimum
-           OpenShift version for version-gated features.
-
-        7. **modules/shared-vpc-resources:** RAM, endpoints, IAM trust per
-           shared VPC docs; prefer narrow bindings over broad IAM.
-
-    - path: "examples/**/*.tf"
-      instructions: |
-        **make verify** (init + validate per example) must stay passing.
-        No embedded credentials; follow existing auth patterns.
-
-    - path: "**/*.tftest.hcl"
-      instructions: |
-        Per **CONTRIBUTING.md** / **AGENTS.md**: mocks where the repo does;
-        branch on booleans → cover both outcomes. Tests live under
-        **modules/<name>/tests/** (see **make unit-tests** / README).
-
-    - path: "scripts/**"
-      instructions: |
-        No secret leakage. Behavior must stay aligned with **CONTRIBUTING.md**
-        (fmt, terraform-docs, verify-gen, verify).
-
-    - path: ".github/workflows/**"
-      instructions: |
-        CI changes affect every PR: keep **make verify**, lint, and doc
-        generation behavior consistent with **CONTRIBUTING.md**; avoid
-        weakening checks without an explicit rationale in the PR.
   tools:
     checkov:
       enabled: true

.cursor/rules/rosa-hcp-terraform.mdc

@@ -76,7 +76,7 @@ For details, see: ./CONTRIBUTING.md
 Examples: variable rename/removal, output rename/removal, default value change, resource behavior changes, provider/version requirement changes. -->
 
 ## Developer Verification Checklist
-- [ ] **AWS-only changes:** If this PR is mainly **AWS-only** (no `rhcs` resources/variables), I linked **official Red Hat or cited ROSA HCP documentation** that supports reference alignment, or I explained why the change still belongs in-repo per **`Module scope (AWS-only vs core HCP)`** in [`.cursor/rules/rosa-hcp-terraform.mdc`](.cursor/rules/rosa-hcp-terraform.mdc).
+- [ ] **AWS-only changes:** If this PR is mainly **AWS-only** (no `rhcs` resources/variables), I linked **official Red Hat or cited ROSA HCP documentation** that supports reference alignment, or I explained why the change still belongs in-repo per [`developer-docs/submodules.md`](developer-docs/submodules.md).
 - [ ] I checked if this affects terraform-rhcs-rosa-classic and submitted (or already submitted) a companion PR when needed.
 - [ ] Commit subject/title follows `[JIRA-TICKET] | [TYPE]: <MESSAGE>`.
 - [ ] PR description clearly explains both **what** changed and **why**.