fix: pycodestlye issues

Author: ahennr

connection/networkaccessmanager.py

@@ -22,16 +22,16 @@
 """
 
 
-__author__ = "Alessandro Pasotti"
-__date__ = "August 2016"
-
 import sys
 import urllib
 
 from qgis.core import QgsAuthManager, QgsMessageLog, QgsNetworkAccessManager
 from qgis.PyQt.QtCore import QEventLoop, QUrl
 from qgis.PyQt.QtNetwork import QNetworkReply, QNetworkRequest
 
+__author__ = "Alessandro Pasotti"
+__date__ = "August 2016"
+
 # FIXME: ignored
 DEFAULT_MAX_REDIRECTS = 4
 

connection/shogunressource.py

@@ -4,8 +4,6 @@
  This code is licensed under the GPL 2.0 license.
 """
 
-__author__ = "ntreff"
-__date__ = "July 2025"
 
 import json
 import os
@@ -18,15 +16,8 @@
 from qgis.PyQt.QtGui import QIcon
 from qgis.PyQt.QtNetwork import QHttpMultiPart, QHttpPart, QNetworkRequest
 from qgis.PyQt.QtXml import QDomDocument
-from qgis.PyQt.QtNetwork import QNetworkRequest, QHttpPart, QHttpMultiPart
-from qgis.PyQt.QtCore import QFile, QIODevice, QSize
-
-from qgis.core import QgsApplication
-from qgis.gui import QgsMessageBar
 
-from .networkaccessmanager import NetworkAccessManager, RequestsExceptionConnectionError, RequestsException
 from ..layerutils import createAndParseSld
-
 from .networkaccessmanager import (
     NetworkAccessManager,
     RequestsException,
@@ -35,6 +26,9 @@
 
 PYTHON_VERSION = sys.version_info[0]
 
+__author__ = "ntreff"
+__date__ = "July 2025"
+
 
 class ShogunRessource:
     """This class controls all interactions between QGIS and the Shogun ressource,
@@ -87,18 +81,17 @@ def checkConnection(self):
             if testresponse[0]["status"] > 199 and testresponse[0]["status"] < 210:
                 return (True, "")
         except RequestsException as e:
+            print('Error during connection test: ' + str(e))
             if self.baseurl.startswith("https"):
-                # if the first try with 'https' was not successfull try http:
+                # if the first try with 'https' was not successful try http:
                 testurl = "http" + testurl[5:]
                 try:
                     testresponse = self.http.request(testurl, method="HEAD")
-                    if (
-                        testresponse[0]["status"] > 199
-                        and testresponse[0]["status"] < 210
-                    ):
+                    if testresponse[0]["status"] > 199 and testresponse[0]["status"] < 210:
                         self.baseurl = "http" + self.baseurl[5:]
                         return (True, "")
                 except RequestsException as e:
+                    print('Could not fetch fetch applications ' + str(e))
                     pass
         return (False, "Error : Failed to connect to the server")
 
@@ -450,17 +443,17 @@ def uploadLayer(self, pathToZipFile, dataType):
     def requestCrsUpdateOnLayer(self, importJobId):
         url = self.baseurl + "/import/update-crs-for-import.action"
         data = (
-            "importJobId="
-            + str(importJobId)
-            + "&taskId=0&fileProjection=EPSG%3A3857&layerName=&dataType=Vector"
+            "importJobId=" +
+            str(importJobId) +
+            "&taskId=0&fileProjection=EPSG%3A3857&layerName=&dataType=Vector"
         )
         h = {"Content-type": "application/x-www-form-urlencoded; charset=UTF-8"}
         response = self.http.request(url, method="POST", body=data, headers=h)
 
     def getFieldNamesFromWfs(self, layerRessourceName):
         url = (
-            self.baseurl
-            + "geoserver-noauth.action?service=WFS&request=DescribeFeatureType&typeName="
+            self.baseurl +
+            "geoserver-noauth.action?service=WFS&request=DescribeFeatureType&typeName="
         )
         url += layerRessourceName + "&outputFormat=application/json"
         response = self.http.request(url)

gui/dialog_bases/addraster.py

@@ -3,10 +3,6 @@
 (c) 2025 terrestris GmbH & Co. KG, https://www.terrestris.de/en/
  This code is licensed under the GPL 2.0 license.
 """
-
-__author__ = "ntreff"
-__date__ = "July 2025"
-
 import sys
 
 if sys.version_info[0] >= 3:
@@ -16,6 +12,9 @@
     from PyQt4 import QtCore
     from PyQt4.QtGui import QDialog, QLabel, QPushButton
 
+__author__ = "ntreff"
+__date__ = "July 2025"
+
 
 class AddRasterDialog(QDialog):
     def __init__(self):

gui/dialog_bases/applicationSettings.py

@@ -4,9 +4,6 @@
  This code is licensed under the GPL 2.0 license.
 """
 
-__author__ = "ntreff"
-__date__ = "July 2025"
-
 import sys
 
 from qgis.gui import QgsExtentGroupBox
@@ -18,6 +15,10 @@
 from qgis.PyQt.QtGui import QFont
 
 
+__author__ = "ntreff"
+__date__ = "July 2025"
+
+
 class LayerListItem(QtGui.QListWidgetItem):
     def __init__(self, text, layerId):
         super(LayerListItem, self).__init__(text)
@@ -51,12 +52,8 @@ class LayerTreeItem(QtGui.QTreeWidgetItem):
     def __init__(self, parent):
         super(LayerTreeItem, self).__init__(parent)
         self.setFlags(
-            Qt.ItemIsEnabled
-            | Qt.ItemIsSelectable
-            | Qt.ItemIsDragEnabled
-            | Qt.ItemIsSelectable
-            | Qt.ItemIsUserCheckable
-            | Qt.ItemIsDropEnabled
+            Qt.ItemIsEnabled | Qt.ItemIsSelectable | Qt.ItemIsDragEnabled |
+            Qt.ItemIsSelectable | Qt.ItemIsUserCheckable | Qt.ItemIsDropEnabled
         )
         self.savedAttributes = {}
         self.newAttributes = {}
@@ -70,7 +67,7 @@ def setSavedAttributes(self, savedAttributes):
         self.id = self.savedAttributes["id"]
         if self.savedAttributes["root"]:
             return
-        if self.savedAttributes["checked"] == True:
+        if self.savedAttributes["checked"]:
             self.setCheckState(0, Qt.Checked)
         else:
             self.setCheckState(0, Qt.Unchecked)
@@ -179,7 +176,7 @@ def getLayerTreeChanges(self):
             treeitem.updateNewAttributes()
             change = treeitem.getItemChange()
             if change is not None:
-                if not "id" in change:
+                if "id" not in change:
                     allChanges["newItems"].append(change)
                 else:
                     allChanges["changeItems"].append(change)
@@ -388,13 +385,13 @@ def setupUi(self):
             self.tabWidget.addTab(t, tab[0])
 
             for label in tab[1]:
-                l = QtGui.QLabel(t)
-                l.setText(label[0])
-                l.setGeometry(QRect(label[1][0], label[1][1], label[1][2], label[1][3]))
+                l2 = QtGui.QLabel(t)
+                l2.setText(label[0])
+                l2.setGeometry(QRect(label[1][0], label[1][1], label[1][2], label[1][3]))
                 if tab[0] == "Layer":
                     font = QFont("Arial", 12)
                     font.setBold(True)
-                    l.setFont(font)
+                    l2.setFont(font)
 
         self.tabWidget.setCurrentIndex(0)
 

gui/dialog_bases/connectdlg.py

@@ -4,9 +4,6 @@
  This code is licensed under the GPL 2.0 license.
 """
 
-__author__ = "ntreff"
-__date__ = "July 2025"
-
 import sys
 
 if sys.version_info[0] >= 3:
@@ -16,6 +13,9 @@
     from PyQt4.QtCore import QRect
     from PyQt4.QtGui import QDialog, QLabel, QLineEdit, QPushButton
 
+__author__ = "ntreff"
+__date__ = "July 2025"
+
 
 class ConnectDialog(QDialog):
     def __init__(self):

gui/dialog_bases/dockwidget.py

@@ -4,9 +4,6 @@
  This code is licensed under the GPL 2.0 license.
 """
 
-__author__ = "ntreff"
-__date__ = "July 2025"
-
 import sys
 
 if sys.version_info[0] >= 3:
@@ -16,6 +13,9 @@
     from PyQt4.QtCore import QRect, Qt
     from PyQt4.QtGui import QDockWidget, QPushButton, QTreeWidget, QWidget
 
+__author__ = "ntreff"
+__date__ = "July 2025"
+
 
 class DockWidget(QDockWidget):
     def __init__(self):

gui/dialog_bases/layerSettings.py

@@ -4,10 +4,8 @@
  This code is licensed under the GPL 2.0 license.
 """
 
-__author__ = "ntreff"
-__date__ = "July 2025"
-
 import sys
+from qgis.gui import QgsMapLayerComboBox
 
 if sys.version_info[0] >= 3:
     # we are faking the old way of QtGui, not the best style, but makes it easier
@@ -19,7 +17,8 @@
     from PyQt4.QtCore import QRect, Qt
     from PyQt4 import QtGui
 
-from qgis.gui import QgsMapLayerComboBox
+__author__ = "ntreff"
+__date__ = "July 2025"
 
 
 class LayerSettingsDialog(QtGui.QDialog):
@@ -72,13 +71,13 @@ def setupUi(self):
             self.tabWidget.addTab(t, tab[0])
 
             for label in tab[1]:
-                l = QtGui.QLabel(t)
-                l.setGeometry(QRect(label[1][0], label[1][1], label[1][2], label[1][3]))
+                l2 = QtGui.QLabel(t)
+                l2.setGeometry(QRect(label[1][0], label[1][1], label[1][2], label[1][3]))
                 if label[0] == "explanation":
-                    l.setText(expl)
-                    l.setAlignment(Qt.AlignTop)
+                    l2.setText(expl)
+                    l2.setAlignment(Qt.AlignTop)
                 else:
-                    l.setText(label[0])
+                    l2.setText(label[0])
 
         self.tabWidget.setCurrentIndex(0)
 

gui/editor.py

@@ -4,21 +4,17 @@
  This code is licensed under the GPL 2.0 license.
 """
 
-__author__ = "ntreff"
-__date__ = "July 2025"
-
-import sys
-
 from qgis.core import QgsNetworkAccessManager
-from qgis.gui import QgsMessageBar
 from qgis.PyQt.QtCore import QObject, Qt, QTimer
 from qgis.PyQt.QtWidgets import QAction, QMenu, QMessageBox, QTreeWidgetItemIterator
-from qgis_shogun_editor_plugin.connection.shogunressource import ShogunRessource
 
+from ..connection.shogunressource import ShogunRessource
 from .dialog_bases.connectdlg import ConnectDialog
 from .dialog_bases.dockwidget import DockWidget
-from .editoritems import EditorItem, EditorTopItem, QgisLayerItem, ApplicationItem, LayerItem
-from ..connection.shogunressource import ShogunRessource
+from .editoritems import ApplicationItem, EditorItem, EditorTopItem, LayerItem, QgisLayerItem
+
+__author__ = "ntreff"
+__date__ = "July 2025"
 
 
 class Editor(QObject):
@@ -53,12 +49,13 @@ def __init__(self, iface):
          'authenticationRequired' (inherited from QNetworkAccessManager) to a
          method where a dialog in QGIS pops up asking for the users credentials
          (when working with Basic Auth). We disable the signal here as the
-         case of wrong identifacation credentials is treated separately
+         case of wrong identification credentials is treated separately
          in def: checkConnection(self)
          """
         try:
             QgsNetworkAccessManager.instance().authenticationRequired.disconnect()
-        except:
+        except Exception as e:
+            print('Error occurred: ' + str(e))
             pass
 
     def on_context_menu(self, point):
@@ -138,7 +135,8 @@ def on_tree_item_double_clicked(self, item):
         if isinstance(item, QgisLayerItem):
             try:
                 self.iface.showLayerProperties(item.layer)
-            except:
+            except Exception as e:
+                print('Error occurred: ' + str(e))
                 pass
 
     def showDialog(self, item):
@@ -158,7 +156,8 @@ def showDialog(self, item):
         try:
             dialog.setWindowState(Qt.WindowActive)
             dialog.activateWindow()
-        except:
+        except Exception as e:
+            print('Error occurred: ' + str(e))
             pass
 
     def setupNewConnection(self):
@@ -175,7 +174,7 @@ def setupNewConnection(self):
         pw = self.connectdlg.passwordIn.text()
 
         if len(url) == 0 or len(name) == 0:
-            self.showWarning(self.connectdlg, "Please fill in all necessary " "fields")
+            self.showWarning(self.connectdlg, "Please fill in all necessary fields")
             self.connectdlg.show()
             return
 
@@ -195,10 +194,10 @@ def setupNewConnection(self):
             self.connectdlg.show()
             return
 
-        bool = newRessource.updateData()
-        if not bool:
+        result = newRessource.updateData()
+        if not result:
             self.showWarning(
-                self.connectdlg, "Error: Could not retrieve all " "data from Shogun"
+                self.connectdlg, "Error: Could not retrieve all data from Shogun"
             )
 
         self.connectdlg.hide()
@@ -223,7 +222,7 @@ def refreshConnection(self, item):
         self.expandEditorTree(item)
 
     def showWarning(self, parent, text):
-        warn = QMessageBox.warning(parent, "Warning", text, QMessageBox.Ok)
+        QMessageBox.warning(parent, "Warning", text, QMessageBox.Ok)
 
     def uploadStyle(self, item):
         success = item.uploadStyle()
@@ -249,9 +248,9 @@ def loadAllAppLayers(self, item):
                 layer.addQgsLayer(self.iface)
 
     def expandEditorTree(self, connectionItem):
-        iter = QTreeWidgetItemIterator(connectionItem)
-        val = iter.value()
+        iterator = QTreeWidgetItemIterator(connectionItem)
+        val = iterator.value()
         while val:
             val.setExpanded(True)
-            iter += 1
-            val = iter.value()
+            iterator += 1
+            val = iterator.value()