[Groupcast] Fix an issue where replaceEndpoints field was allowed for a Sender only (project-chip#43362)

* Fix a issue where replaceEndpoints field was alloew for a Sender only

* Update src/app/clusters/groupcast/GroupcastLogic.cpp

Co-authored-by: Sergio Soares <sergiosoares@google.com>

* Restyled by clang-format

---------

Co-authored-by: Sergio Soares <sergiosoares@google.com>
Co-authored-by: Restyled.io <commits@restyled.io>

Author: 3 people

src/app/clusters/groupcast/GroupcastLogic.cpp

@@ -145,6 +145,9 @@ Status GroupcastLogic::JoinGroup(FabricIndex fabric_index, const Groupcast::Comm
         VerifyOrReturnError(mFeatures.Has(Groupcast::Feature::kListener), Status::ConstraintError);
     }
 
+    // ReplaceEndpoints can only be present if kListener feature is supported
+    VerifyOrReturnError(!data.replaceEndpoints.HasValue() || mFeatures.Has(Groupcast::Feature::kListener), Status::ConstraintError);
+
     // Check endpoints
     size_t endpoint_count = 0;
     err                   = data.endpoints.ComputeSize(&endpoint_count);

src/app/clusters/groupcast/tests/TestGroupcastCluster.cpp

@@ -788,6 +788,25 @@ TEST_F(TestGroupcastCluster, TestJoinGroupCommand)
         EXPECT_EQ(result.status.value().GetStatusCode().GetStatus(), // NOLINT(bugprone-unchecked-optional-access)
                   Protocols::InteractionModel::Status::Success);
 
+        // Join group: ReplaceEndpoints
+        data.replaceEndpoints = MakeOptional(true);
+        result                = tester.Invoke(Commands::JoinGroup::Id, data);
+        ASSERT_TRUE(result.status.has_value());
+        EXPECT_EQ(result.status.value().GetStatusCode().GetStatus(), // NOLINT(bugprone-unchecked-optional-access)
+                  Protocols::InteractionModel::Status::ConstraintError);
+
+        data.replaceEndpoints = MakeOptional(false);
+        result                = tester.Invoke(Commands::JoinGroup::Id, data);
+        ASSERT_TRUE(result.status.has_value());
+        EXPECT_EQ(result.status.value().GetStatusCode().GetStatus(), // NOLINT(bugprone-unchecked-optional-access)
+                  Protocols::InteractionModel::Status::ConstraintError);
+
+        data.replaceEndpoints.ClearValue();
+        result = tester.Invoke(Commands::JoinGroup::Id, data);
+        ASSERT_TRUE(result.status.has_value());
+        EXPECT_EQ(result.status.value().GetStatusCode().GetStatus(), // NOLINT(bugprone-unchecked-optional-access)
+                  Protocols::InteractionModel::Status::Success);
+
         // Join group: Non-empty endpoints
         data.groupID   = 3;
         data.endpoints = DataModel::List<const EndpointId>(kEndpoints, MATTER_ARRAY_SIZE(kEndpoints));