Skip to content

Commit 4438dec

Browse files
juandediosgr-recchiacecille
authored
TC-SU-4.1 python test (project-chip#39980)
* Initial commit.. * Initial commit with partial implementation. * Implemented Step 1, still not functional. * Implemented Steps from 2 to 4, partial functional. * Refactor: Implemented Steps from 1 to 2 functional, with TH3 added and commissioning. * Refactor: Implemented Steps from 1 to 4 working as expected. * Implemented Step 5. * Refactor: Implemented Step 5. * Refactor: Implemented partial Step 6. * Refactor: Implemented partial Step 4 debbuging for potential bug. * Debug: Investigate potential bug in step 4 impacting step 6. * Debug: Investigate potential bug in step 5 impacting step 6. * Refactor: Updated Step 4 based on bug 40294. * Updated Step 6 * Updated Step 7 * Updated Step 8 * Step 9 skipped per test plan refinement. * Fix: Restyle errors. * Fix: Restyle errors v2. * Fix: code-lints errors. * Fix: Restyle errors v3. * Fix: code-lints errors v2. * Fix: Corrected CI test arguments to use endpoint 0. * Fix: Updated CI test arguments. * docs: Added docstring. * docs: add comment explaining unused OTA cluster variable kept for future reference. * Fix: Use self.cluster_otar instead of direct reference. * Fix: Replace assert_equal with assert_true. * Fix: Updated CI arguments for app. * CI: Added OTA_REQUESTOR and OTA_PROVIDER to 'Generate an argument environment file' workflow to file 'test_env.yaml'. * CI: Added build step for chip-ota-requestor-app. * Fix: Refactor build step for linux-x64-ota-requestor to enable test run. * Clean branch: revert accidental merges; restore branch to correct state. * Fix: Address Ruff. * Fix: Updated test to be compatible with latest master. * Refactor: In Step 5 reuse create_acl_entry for TH4 with Admin + View permissions. * Refactor: - Updated CI test arguments to remove --nodeId, vendor and product ID, and port. - Removed unused imports and the write_acl() function; now using acl_entry for ACLs. - Reordered and restyled library calls for consistent style. * Refactor and test improvements: - Refactor steps 1, 3, and 5 to use set_default_ota_providers_list fn and improve logging. - Add explanatory note in step 6 regarding multiple providers and ConstraintError. - Update teardown_test to clear KVS after test. - Include OTA_REQUESTOR_APP environment variable in CI. * Update: Added clarifications in Step 7 feedback. * Update: Clean up test comments and logging,and address Copilot suggestions. * Update: Code-lints and restyled. * Update: Addressed and clarified Copilot comments, no functional changes to test logic. * Refactor based on feedback: - Refactor the Provider NodeIDs to use variables th2_node_id, th3_node_id, and th4_node_id for clarity and maintainability.. - Extract the FabricID for TH3 to a variable th2_fabric_id. * Update: Removed comments for clean-up. * Update: Include an assertion in Step 7 to check that UpdatePossible is True. * Refactor based on feedback to align with test plan and verification: - Use TH as the admin controller across the test - Refactor Step 5 to match test verification (no TH4 controller) - Update Step 6 to validate fabric when clearing DefaultOTAProviders - Update Steps 7 and 8 to read attributes via TH on Fabric 1 - Clarify comments to align with test expectations. * Update: Copilot comments suggestions. * Update: Step 5 now verifies DefaultOTAProviders on both fabrics after ConstraintError. * Solve comments for TC_SU_4_1 * Revert "Solve comments for TC_SU_4_1" This reverts commit 8e0d115. * Solve comments for TC_SU_4_1 * restore third party * Fix imports * fix imports * Fix imports --------- Co-authored-by: Ramiro Recchia <rrecchia@google.com> Co-authored-by: C Freeman <cecille@google.com>
1 parent f8a1093 commit 4438dec

2 files changed

Lines changed: 448 additions & 332 deletions

File tree

src/app/tests/suites/certification/Test_TC_SU_4_1.yaml

Lines changed: 0 additions & 332 deletions
This file was deleted.

0 commit comments

Comments
 (0)