Thread: disable security when Thread not started (project-chip#43076)

* Thread: disable security when Thread not started

* Update GenericThreadStackManagerImpl_OpenThread_LwIP.cpp

Author: bukepo

src/inet/UDPEndPointImplOpenThread.cpp

@@ -262,18 +262,8 @@ CHIP_ERROR UDPEndPointImplOT::SendMsgImpl(const IPPacketInfo * aPktInfo, System:
 
     LockOpenThread();
 
-    switch (otThreadGetDeviceRole(mOTInstance))
-    {
-    case OT_DEVICE_ROLE_DISABLED:
-    case OT_DEVICE_ROLE_DETACHED:
-        settings.mLinkSecurityEnabled = false;
-        break;
-    default:
-        settings.mLinkSecurityEnabled = true;
-        break;
-    }
-
-    settings.mPriority = OT_MESSAGE_PRIORITY_NORMAL;
+    settings.mPriority            = OT_MESSAGE_PRIORITY_NORMAL;
+    settings.mLinkSecurityEnabled = otThreadGetDeviceRole(mOTInstance) != OT_DEVICE_ROLE_DISABLED;
 
     message = otUdpNewMessage(mOTInstance, &settings);
     VerifyOrExit(message != NULL, error = OT_ERROR_NO_BUFS);

src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread_LwIP.cpp

@@ -290,14 +290,17 @@ err_t GenericThreadStackManagerImpl_OpenThread_LwIP<ImplClass>::SendPacket(struc
 {
     err_t lwipErr = ERR_OK;
     otError otErr;
-    otMessage * pktMsg                  = NULL;
-    const otMessageSettings msgSettings = { true, OT_MESSAGE_PRIORITY_NORMAL };
+    otMessage * pktMsg            = NULL;
+    otMessageSettings msgSettings = {};
     uint16_t remainingLen;
 
     // Lock the OpenThread stack.
     // Note that at this point the LwIP core lock is also held.
     ThreadStackMgrImpl().LockThreadStack();
 
+    msgSettings.mLinkSecurityEnabled = otThreadGetDeviceRole(ThreadStackMgrImpl().OTInstance()) != OT_DEVICE_ROLE_DISABLED;
+    msgSettings.mPriority            = OT_MESSAGE_PRIORITY_NORMAL;
+
     // Allocate an OpenThread message
     pktMsg = otIp6NewMessage(ThreadStackMgrImpl().OTInstance(), &msgSettings);
     VerifyOrExit(pktMsg != NULL, lwipErr = ERR_MEM);