Move defaults vars to its own file. (project-chip#39696)

* Moved _DEFAULTS_ to single file

* Update file name

* Trying new import type

* Fix lint

* Removed _ prefix from DEFAULT variables

* Updated name from matter_global_defaults to matter_testing_defaults

* isort fix

* Update matter_test_config to use variables from matter_testing_defaults

* Restyled by isort

* Restyled by isort

* Conflict typo

* Fix from CI jo

* Restyled by gn

* Restyled by isort

* Fix import path

* Restyled by gn

* Restyled by isort

* Update file name to match new path matter/testing instead of chip

* Restyled by gn

---------

Co-authored-by: Restyled.io <commits@restyled.io>

Author: jtrejoespinoza-grid

src/python_testing/matter_testing_infrastructure/BUILD.gn

@@ -46,6 +46,7 @@ pw_python_package("matter-testing-module") {
     "matter/testing/conformance.py",
     "matter/testing/conversions.py",
     "matter/testing/decorators.py",
+    "matter/testing/defaults.py",
     "matter/testing/event_attribute_reporting.py",
     "matter/testing/global_attribute_ids.py",
     "matter/testing/global_stash.py",

src/python_testing/matter_testing_infrastructure/matter/testing/defaults.py

@@ -0,0 +1,31 @@
+#
+#    Copyright (c) 2025 Project CHIP Authors
+#    All rights reserved.
+#
+#    Licensed under the Apache License, Version 2.0 (the "License");
+#    you may not use this file except in compliance with the License.
+#    You may obtain a copy of the License at
+#
+#        http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS,
+#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#    See the License for the specific language governing permissions and
+#    limitations under the License.
+#
+
+"""
+This module contains global variables that are used across several scripts and classes.
+"""
+from typing import final
+
+
+class TestingDefaults:
+
+    ADMIN_VENDOR_ID: final = 0xFFF1
+    STORAGE_PATH: final = "admin_storage.json"
+    LOG_PATH: final = "/tmp/matter_testing/logs"
+    CONTROLLER_NODE_ID: final = 112233
+    DUT_NODE_ID: final = 0x12344321
+    TRUST_ROOT_INDEX: final = 1

src/python_testing/matter_testing_infrastructure/matter/testing/matter_test_config.py

@@ -20,9 +20,7 @@
 from datetime import timedelta
 from typing import List, Optional
 
-_DEFAULT_ADMIN_VENDOR_ID = 0xFFF1
-_DEFAULT_CONTROLLER_NODE_ID = 112233
-_DEFAULT_TRUST_ROOT_INDEX = 1
+from matter.testing.defaults import TestingDefaults
 
 
 @dataclass
@@ -33,7 +31,7 @@ class MatterTestConfig:
     ble_controller: Optional[int] = None
     commission_only: bool = False
 
-    admin_vendor_id: int = _DEFAULT_ADMIN_VENDOR_ID
+    admin_vendor_id: int = TestingDefaults.ADMIN_VENDOR_ID
     case_admin_subject: Optional[int] = None
     global_test_params: dict = field(default_factory=dict)
     # List of explicit tests to run by name. If empty, all tests will run
@@ -68,7 +66,7 @@ class MatterTestConfig:
     # Node ID for basic DUT
     dut_node_ids: List[int] = field(default_factory=list)
     # Node ID to use for controller/commissioner
-    controller_node_id: int = _DEFAULT_CONTROLLER_NODE_ID
+    controller_node_id: int = TestingDefaults.CONTROLLER_NODE_ID
     # CAT Tags for default controller/commissioner
     # By default, we commission with CAT tags specified for RR-1.1
     # so the cert tests can be run without re-commissioning the device
@@ -79,7 +77,7 @@ class MatterTestConfig:
     fabric_id: int = 1
 
     # "Alpha" by default
-    root_of_trust_index: int = _DEFAULT_TRUST_ROOT_INDEX
+    root_of_trust_index: int = TestingDefaults.TRUST_ROOT_INDEX
 
     # If this is set, we will reuse root of trust keys at that location
     chip_tool_credentials_path: Optional[pathlib.Path] = None

src/python_testing/matter_testing_infrastructure/matter/testing/runner.py

@@ -42,6 +42,8 @@
 import matter.testing.global_stash as global_stash
 from matter.clusters import Attribute
 # Add imports for argument parsing dependencies
+from matter.testing.defaults import TestingDefaults
+# Add imports for argument parsing dependencies
 from matter.testing.pics import read_pics_from_file
 
 try:
@@ -67,15 +69,6 @@ def StartFromString(self, destination):
 if TYPE_CHECKING:
     from matter.testing.matter_test_config import MatterTestConfig
 
-_DEFAULT_LOG_PATH = "/tmp/matter_testing/logs"
-
-# Default constants for argument parsing
-_DEFAULT_ADMIN_VENDOR_ID = 0xFFF1
-_DEFAULT_STORAGE_PATH = "admin_storage.json"
-_DEFAULT_CONTROLLER_NODE_ID = 112233
-_DEFAULT_DUT_NODE_ID = 0x12344321
-_DEFAULT_TRUST_ROOT_INDEX = 1
-
 
 def default_paa_rootstore_from_root(root_path: pathlib.Path) -> Optional[pathlib.Path]:
     """Attempt to find a PAA trust store following SDK convention at `root_path`
@@ -287,7 +280,7 @@ def generate_mobly_test_config(matter_test_config):
     test_run_config.testbed_name = "MatterTest"
 
     log_path = matter_test_config.logs_path
-    log_path = _DEFAULT_LOG_PATH if log_path is None else log_path
+    log_path = TestingDefaults.LOG_PATH if log_path is None else log_path
     if ENV_MOBLY_LOGPATH in os.environ:
         log_path = os.environ[ENV_MOBLY_LOGPATH]
 
@@ -659,7 +652,7 @@ def populate_commissioning_args(args: argparse.Namespace, config) -> bool:
     device_descriptors = config.qr_code_content + config.manual_code + config.discriminators
 
     if not config.dut_node_ids:
-        config.dut_node_ids = [_DEFAULT_DUT_NODE_ID]
+        config.dut_node_ids = [TestingDefaults.DUT_NODE_ID]
 
     if args.commissioning_method is None:
         return True
@@ -733,8 +726,8 @@ def convert_args_to_matter_config(args: argparse.Namespace):
     if not populate_commissioning_args(args, config):
         sys.exit(1)
 
-    config.storage_path = pathlib.Path(_DEFAULT_STORAGE_PATH) if args.storage_path is None else args.storage_path
-    config.logs_path = pathlib.Path(_DEFAULT_LOG_PATH) if args.logs_path is None else args.logs_path
+    config.storage_path = pathlib.Path(TestingDefaults.STORAGE_PATH) if args.storage_path is None else args.storage_path
+    config.logs_path = pathlib.Path(TestingDefaults.LOG_PATH) if args.logs_path is None else args.logs_path
     config.paa_trust_store_path = args.paa_trust_store_path
     config.ble_controller = args.ble_controller
     if args.PICS is None:
@@ -802,12 +795,12 @@ def parse_matter_test_args(argv: Optional[List[str]] = None):
                              metavar="CONTROLLER_ID", help="BLE controller selector, see example or platform docs for details")
     basic_group.add_argument('-N', '--controller-node-id', type=int_decimal_or_hex,
                              metavar='NODE_ID',
-                             default=_DEFAULT_CONTROLLER_NODE_ID,
-                             help='NodeID to use for initial/default controller (default: %d)' % _DEFAULT_CONTROLLER_NODE_ID)
+                             default=TestingDefaults.CONTROLLER_NODE_ID,
+                             help='NodeID to use for initial/default controller (default: %d)' % TestingDefaults.CONTROLLER_NODE_ID)
     basic_group.add_argument('-n', '--dut-node-id', '--nodeId', type=int_decimal_or_hex,
                              metavar='NODE_ID', dest='dut_node_ids', default=[],
                              help='Node ID for primary DUT communication, '
-                             'and NodeID to assign if commissioning (default: %d)' % _DEFAULT_DUT_NODE_ID, nargs="+")
+                             'and NodeID to assign if commissioning (default: %d)' % TestingDefaults.DUT_NODE_ID, nargs="+")
     basic_group.add_argument('--endpoint', type=int, default=None, help="Endpoint under test")
     basic_group.add_argument('--app-pipe', type=str, default=None, help="The full path of the app to send an out-of-band command")
     basic_group.add_argument('--timeout', type=int, help="Test timeout in seconds")
@@ -848,9 +841,9 @@ def parse_matter_test_args(argv: Optional[List[str]] = None):
                                   metavar='OPERATIONAL_DATASET_HEX',
                                   help='Thread operational dataset as a hex string for ble-thread commissioning')
 
-    commission_group.add_argument('--admin-vendor-id', action="store", type=int_decimal_or_hex, default=_DEFAULT_ADMIN_VENDOR_ID,
+    commission_group.add_argument('--admin-vendor-id', action="store", type=int_decimal_or_hex, default=TestingDefaults.ADMIN_VENDOR_ID,
                                   metavar="VENDOR_ID",
-                                  help="VendorID to use during commissioning (default 0x%04X)" % _DEFAULT_ADMIN_VENDOR_ID)
+                                  help="VendorID to use during commissioning (default 0x%04X)" % TestingDefaults.ADMIN_VENDOR_ID)
     commission_group.add_argument('--case-admin-subject', action="store", type=int_decimal_or_hex,
                                   metavar="CASE_ADMIN_SUBJECT",
                                   help="Set the CASE admin subject to an explicit value (default to commissioner Node ID)")
@@ -876,9 +869,9 @@ def parse_matter_test_args(argv: Optional[List[str]] = None):
                               help='Fabric ID on which to operate under the root of trust')
 
     fabric_group.add_argument('-r', '--root-index', type=root_index,
-                              metavar='ROOT_INDEX_OR_NAME', default=_DEFAULT_TRUST_ROOT_INDEX,
+                              metavar='ROOT_INDEX_OR_NAME', default=TestingDefaults.TRUST_ROOT_INDEX,
                               help='Root of trust under which to operate/commission for single-fabric basic usage. '
-                              'alpha/beta/gamma are aliases for 1/2/3. Default (%d)' % _DEFAULT_TRUST_ROOT_INDEX)
+                              'alpha/beta/gamma are aliases for 1/2/3. Default (%d)' % TestingDefaults.TRUST_ROOT_INDEX)
 
     fabric_group.add_argument('-c', '--chip-tool-credentials-path', type=pathlib.Path,
                               metavar='PATH',